Skip to content

[Bugfix:RainbowGrades] Gradebook Format Fix#12754

Merged
bmcutler merged 2 commits into
mainfrom
gradebook-format-fix
Apr 30, 2026
Merged

[Bugfix:RainbowGrades] Gradebook Format Fix#12754
bmcutler merged 2 commits into
mainfrom
gradebook-format-fix

Conversation

@Eli-J-Schwartz

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

This is a minor styling change related to PR#86 in Submitty/RainbowGrades, that prevents the table from overflowing past the sticky columns.

What is the New Behavior?

Before:
Screenshot_20260406_173230
After:
Screenshot_20260406_173456

What steps should a reviewer take to reproduce or test the bug or new feature?

Follow the same steps as in PR#86 in Submitty/RainbowGrades.

Automated Testing & Documentation

N/A (style change)

Other information

None

@codecov

codecov Bot commented Apr 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.64%. Comparing base (9e19128) to head (560dd29).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12754   +/-   ##
=========================================
  Coverage     21.64%   21.64%           
  Complexity     9654     9654           
=========================================
  Files           268      268           
  Lines         36244    36244           
  Branches        487      487           
=========================================
  Hits           7845     7845           
  Misses        27916    27916           
  Partials        483      483           
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.04% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.66% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@John-Roy123 John-Roy123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After speaking in person, I was able to get the changes to work correctly, however you should update the reviewer instructions so that it matches the extra steps required to test this change.

@github-project-automation github-project-automation Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Apr 7, 2026
@Eli-J-Schwartz

Eli-J-Schwartz commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

Hi @John-Roy123,
Is the first column of the gradebook the User ID? If not, then the updated version of RainbowGrades is not being used. I probably should have included this before, but here are instructions for fetching the changes I made on the RainbowGrades repo:

  1. run git clone https://github.com/Submitty/RainbowGrades.git in the directory above Submitty. The resulting file structure should look like:
RCOS_Submitty/ (or some other name)
├─ Submitty/
│  ├─ site/
│  ├─ grading/
│  ├─ bin/
│  ├─ ...
├─ RainbowGrades/
│  ├─ student.cpp
│  ├─ table.cpp
│  ├─ output.cpp
│  ├─ ...
├─ ...
  1. in the RainbowGrades folder, run git checkout sticky-columns
  2. in the Submitty folder, run vagrant halt, then vagrant up, to link the RainbowGrades folder to the VM. If this worked correctly you should see the line
    ubuntu-22.04: /home/username_example/RCOS_Submitty/RainbowGrades => /usr/local/submitty/GIT_CHECKOUT/RainbowGrades
  3. run vagrant ssh, the run submitty_install, to fetch re-compile rainbow grades.
  4. follow the build and test instructions from the other PR.

If you have fully built the modified version, please take a screenshot of the devtools style information for one of the cells that is suposed to be sticky, as that would help me debug the issue.

@roye2
roye2 self-requested a review April 7, 2026 20:01
@automateprojectmangement automateprojectmangement Bot moved this from Work in Progress to In Review in Submitty Development Apr 7, 2026
@dagemcn

dagemcn commented Apr 7, 2026

Copy link
Copy Markdown
Member

See my review on rainbow grades PR#86

@roye2 roye2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my review on RainbowGrades #86

@dagemcn dagemcn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here and on PR#86 look good!

@Rkoester47 Rkoester47 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving along with PR#86

@bmcutler
bmcutler merged commit c0153d3 into main Apr 30, 2026
25 checks passed
@bmcutler
bmcutler deleted the gradebook-format-fix branch April 30, 2026 19:33
@github-project-automation github-project-automation Bot moved this from In Review to Done in Submitty Development Apr 30, 2026
bmcutler pushed a commit to Submitty/RainbowGrades that referenced this pull request May 1, 2026
<!-- ** Please remove all comment blocks in the description before
submitting this PR. ** -->

<!-- NOTE: Please ensure your title and description align with Submitty
conventions (see
https://submitty.org/developer/getting_started/make_a_pull_request for
more details).
Each title has a prefix, and a limit of 40 chars. A description template
has been
provided and must be completed in full. Please also ensure that all CI
tests
are passing. Pull requests that do not meet these requirements are
ineligible for
review and may be closed. -->
### Why is this Change Important & Necessary?
Partially addresses [Issue #10273 In
Submitty/Submitty](Submitty/Submitty#10273)

### What is the New Behavior?
The leftmost 4 rows, which contain the User ID, Numeric ID, First Name,
& Last Name, stay in place when scrolling to the right.

Before:


https://github.com/user-attachments/assets/35260e4f-8a84-482f-b9b5-422e95516b5a


After:


https://github.com/user-attachments/assets/3d761ea3-1ab3-4047-a671-09c0b81219fd

### What steps should a reviewer take to reproduce or test the bug or
new feature?

1. As an instructor, visit the grades configuration tab and rebuild the
rainbow grades.
2. Visit the gradebook page and try scrolling the table of grades left
and right.
3. Observe the new behavior or sticky columns.

Edit: Since multiple people noted issues with testing this PR due to the
changes existing in two different repositories, here are instructions
for setting up Submitty to read the changes in the RainbowGrades
repository.

1. run `git clone https://github.com/Submitty/RainbowGrades.git` in the
directory above Submitty. The resulting file structure should look like:
```
RCOS_Submitty/ (or some other name)
├─ Submitty/
│  ├─ site/
│  ├─ grading/
│  ├─ bin/
│  ├─ ...
├─ RainbowGrades/
│  ├─ student.cpp
│  ├─ table.cpp
│  ├─ output.cpp
│  ├─ ...
├─ ...
```
2. in the RainbowGrades folder, run `git checkout sticky-columns`
3. in the Submitty folder, run `git checkout gradebook-format-fix`
4. in the Submitty folder, run `vagrant halt`, then `vagrant up`, to
link the RainbowGrades folder to the VM. If this worked correctly you
should see the line
`ubuntu-22.04: /home/username_example/RCOS_Submitty/RainbowGrades =>
/usr/local/submitty/GIT_CHECKOUT/RainbowGrades`
5. run `vagrant ssh`, the run `submitty_install`, to fetch re-compile
rainbow grades.
6. follow the build and test instructions listed above.

### Automated Testing & Documentation
No testing or documentation is needed, as the change is purely visual.

### Other information
Due to a small styling issue, I had to make a 1-line PR in the
Submitty/Submitty repository, which can be found
[here](Submitty/Submitty#12754). Reviewers
should review both PR's simultaneously.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants