[Bugfix:TAGrading] Fix header overlap on team names#12749
Merged
Conversation
Contributor
|
Tested this locally. Everything looks good to me. File changes also look minimal and good. |
roye2
self-requested a review
April 7, 2026 01:51
automateprojectmangement
Bot
moved this from Seeking Reviewer
to In Review
in Submitty Development
roye2
requested changes
Apr 7, 2026
Contributor
There was a problem hiding this comment.
As you can see here, the scrolling functionality on the team member list appears to be broken. As it is right now, the team member list is compressing the main panel of the page. Please update this PR to fix that. Good job so far on fixing the overlap bug though!
github-project-automation
Bot
moved this from In Review
to Work in Progress
in Submitty Development
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12749 +/- ##
=========================================
Coverage 21.64% 21.64%
Complexity 9654 9654
=========================================
Files 268 268
Lines 36244 36244
Branches 487 487
=========================================
Hits 7845 7845
Misses 27916 27916
Partials 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thanks @roye2 for catching that! I've pushed an update that adds a max height constraint to the team member list container. By keeping it restrained, overflow-y: auto successfully triggers again, restoring the native scrolling functionality when a team has many members (without reverting back to the absolute positioning bug). Here is a quick look at the reinstated scrolling behavior: Before: After: Let me know if everything looks good now! |
automateprojectmangement
Bot
moved this from Work in Progress
to In Review
in Submitty Development
roye2
approved these changes
Apr 7, 2026
roye2
left a comment
roye2
left a comment
Contributor
There was a problem hiding this comment.
Good work fixing the scrolling, everything looks good to me now!
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
GarvitKhandelwal31
pushed a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Apr 13, 2026
Fixes Submitty#12748 ### Why is this Change Important & Necessary? Fixes a UI bug in the TA Grading interface where long lists of team member names (or singular long names) would overlap with the navigation buttons (specifically the "Autograding" button). This occurred because the student name container was using absolute positioning, which removed it from the document flow and prevented the header from expanding to accommodate the text. ### What is the New Behavior? The `#bar_wrapper` now uses a CSS Grid layout (`1fr auto 1fr`), and absolute positioning has been removed from `#grading-panel-student-name`. This allows the header to naturally expand its height if the name list is long, pushing the buttons down instead of overlapping them. **Before:** <img width="2559" height="1258" alt="image" src="https://github.com/user-attachments/assets/85c71fd3-faaa-4fac-a2cf-a479cee928de" /> **After:** <img width="1919" height="877" alt="image" src="https://github.com/user-attachments/assets/27ced200-efd5-42bb-bd54-13dda29298fd" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Open a Team Gradeable in the TA Grading interface on your local VM. 2. Select a team with a large number of members (or manually edit a team to have 5+ members). 3. Observe that the team names now correctly push the "Autograding", "Rubric", and "Files" buttons downward rather than rendering on top of them. 4. Verify that the navigation buttons remains centered in the middle column of the grid. ### Automated Testing & Documentation No new automated tests were added as this is a CSS-only layout fix. Manual verification was performed in the Vagrant development environment to ensure consistent behavior across different name lengths and team sizes. ### Other information - **Breaking Change?** No. - **Includes Migrations?** No. - **Security Concerns?** No. --------- Co-authored-by: Emma Roy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12748
Why is this Change Important & Necessary?
Fixes a UI bug in the TA Grading interface where long lists of team member names (or singular long names) would overlap with the navigation buttons (specifically the "Autograding" button). This occurred because the student name container was using absolute positioning, which removed it from the document flow and prevented the header from expanding to accommodate the text.
What is the New Behavior?
The
#bar_wrappernow uses a CSS Grid layout (1fr auto 1fr), and absolute positioning has been removed from#grading-panel-student-name. This allows the header to naturally expand its height if the name list is long, pushing the buttons down instead of overlapping them.Before:
After:
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
No new automated tests were added as this is a CSS-only layout fix. Manual verification was performed in the Vagrant development environment to ensure consistent behavior across different name lengths and team sizes.
Other information