[Bugfix:InstructorUI] notebook builder MC vertical resize#12744
Conversation
|
I have tested this, works fine as shown in the recording of the description. The changes also looks direct and minimal. Why is this Change Important & Necessary?What is the New Behavior?What steps should a reviewer take to reproduce or test the bug or new feature?Automated Testing & DocumentationOther information |
|
@GarvitKhandelwal31 Thank you for testing. I will update the description part to include all the part. |
|
One more thing you can do is that when I resize along the vertical direction the other buttons are also coming down (I mean the buttons in choice control and Up, Down, Remove). |
|
I fixed it. Now those button stays same while resizing. Screenshots:
|
|
Yep, the up, down, remove buttons are now fixed, but can we also choice control buttons and the whole select multiple [ I mean that whole column], because that is still flowing. |
|
Those buttons and others also working as expected. Thank you for pointing it out. Screenshot
|
|
Hey, I have tested again and yes most of the buttons are fixed but the plus (or add button) is still moving. |
|
I think that should be the desired behavior. Where the resizing of the description box ends the plus button should appear there so that user can add another mcq. Should this not be the case? what do you think? |
|
Yeah, I overlooked that. I think you are right and that should be the correct feature. Let's see what the other reviewers have in mind. Everything looks good to me. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12744 +/- ##
=========================================
Coverage 21.64% 21.64%
Complexity 9654 9654
=========================================
Files 268 268
Lines 36244 36244
Branches 487 487
=========================================
Hits 7845 7845
Misses 27916 27916
Partials 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
|
Hi! @dagemcn Thank you for reviewing it. Currently, There is no open issue regarding this.I found it out when i was examining notebook builder ui. Should i open a issue and liked with it? or its just fine? |
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
…2744) ## Why is this Change Important & Necessary? In the Notebook Builder UI, when creating a multiple choice question, the description box resizes both vertically and horizontally, making the UI look inconsistent. Using `resize: vertical;` fixes this issue. This is a simple CSS fix. ## What is the New Behavior? The description box in the multiple choice question now only resizes vertically. ## What Steps Should a Reviewer Take to Reproduce or Test? 1. Open the Notebook Builder UI. 2. Create a new multiple choice question. 3. Try resizing the description box — it should only resize vertically(after the change). ## Automated Testing & Documentation - No automated tests required for this CSS-only fix. - No documentation changes needed. ## Video ### Before https://github.com/user-attachments/assets/a1bf514c-ce3d-481c-a083-2ce0bc0aad9c ### After https://github.com/user-attachments/assets/66ebd2f2-6ffb-45a4-aa89-5a9827b21af1 ## Other Information - **Breaking changes:** No - **Fix type:** Simple CSS change --------- Co-authored-by: dagemcn <[email protected]>
4 participants
Why is this Change Important & Necessary?
In the Notebook Builder UI, when creating a multiple choice question, the description box
resizes both vertically and horizontally, making the UI look inconsistent.
Using
resize: vertical;fixes this issue. This is a simple CSS fix.What is the New Behavior?
The description box in the multiple choice question now only resizes vertically.
What Steps Should a Reviewer Take to Reproduce or Test?
Automated Testing & Documentation
Video
Before
2026-04-04.15-53-51.mp4
After
2026-04-04.16-02-03.mp4
Other Information