Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.64%. Comparing base (f532a4f) to head (a7f8651).
⚠️ Report is 10 commits behind head on main.

@@            Coverage Diff            @@
##               main   #12715   +/-   ##
=========================================
  Coverage     21.64%   21.64%           
  Complexity     9654     9654           
=========================================
  Files           268      268           
  Lines         36244    36244           
  Branches        487      487           
=========================================
  Hits           7845     7845           
  Misses        27916    27916           
  Partials        483      483           

The 4 failures in late_submission_warning_messages.spec.js are pre-existing on main (filed as issue #12732) and unrelated to this PR's forum changes. The test appears to be flaky and date-sensitive.

I tested this and noticed some of the features you mentioned did not work.

Posting and liking posts worked like it was supposed to for limited access graders. Merging threads also worked properly. However, it seems that most of this stuff worked before too.

However, limited access graders were not able to view anonymous names.

I am also going to add someone else on here to see if we even need all of these features and what limited access graders should be able to do.

I tested this and noticed some of the features you mentioned did not work.

Posting and liking posts worked like it was supposed to for limited access graders. Merging threads also worked properly. However, it seems that most of this stuff worked before too.

However, limited access graders were not able to view anonymous names.

I am also going to add someone else on here to see if we even need all of these features and what limited access graders should be able to do.

Thanks for testing this, Christian! Good to know posting, liking, and merging threads are working correctly.

Regarding anonymous name visibility — I'll investigate and push a fix tonight. I'll also take another look at the PR description and trim any features that were already working before my changes.

Appreciate the detailed feedback!

I tested this and noticed some of the features you mentioned did not work.

Posting and liking posts worked like it was supposed to for limited access graders. Merging threads also worked properly. However, it seems that most of this stuff worked before too.

However, limited access graders were not able to view anonymous names.

I am also going to add someone else on here to see if we even need all of these features and what limited access graders should be able to do.

Update: I've investigated and pushed the anonymous name visibility fix (commit 328d458). The issue was in ForumThreadView.php — two places where $post->isAnonymous() was setting the display name to "Anonymous" without checking if the viewing user has grading access. Limited access graders should be able to see real names behind anonymous posts, so I added a !$this->core->getUser()->accessGrading() check in both spots.

I've also updated the PR description to remove features that were already working before my changes.

These are not changes that we need/want. The access differences between full access graders and limited access graders are intentional, therefore I am closing this PR.