Skip to content

[Bugfix:TAGrading] comment box formating in ta grading#12713

Merged
bmcutler merged 5 commits into
Submitty:mainfrom
tijaruS:fix/ta-grading-comment-box-formating
Jun 1, 2026
Merged

[Bugfix:TAGrading] comment box formating in ta grading#12713
bmcutler merged 5 commits into
Submitty:mainfrom
tijaruS:fix/ta-grading-comment-box-formating

Conversation

@tijaruS

@tijaruS tijaruS commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Why is this change important & necessary?

Fixes #12712

  • simple css fix
  • removed flex-wrap: wrap from .markdown-mode-buttons
  • added margin-top on .markdown-area-toolbar and .btn-markdown

New behavior

  • image

Other information

  • Breaking change? No
  • Migrations? No.

@github-project-automation github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Mar 31, 2026
@tijaruS tijaruS changed the title fix comment box formating in ta grading [Bugfix:TAGrading] comment box formating in ta grading Mar 31, 2026
@QuackHonk
QuackHonk self-requested a review April 3, 2026 18:22
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to In Review in Submitty Development Apr 3, 2026

@QuackHonk QuackHonk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does fix the main issue of the tabs not staying on the same horizontal axis! There still is the issue with the buttons (bold italic) wrapping around instead of being hidden off the page. Dark Mode/Light Mode issues. Once that's fixed it should be good

@github-project-automation github-project-automation Bot moved this from In Review to Work in Progress in Submitty Development Apr 3, 2026
@tijaruS

tijaruS commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

Hi! @QuackHonk I have made the changes you requested. The buttons look okay in light theme too. And Buttons are now being hidden instead of wrapping.

Screenshots

  • image
  • image

@QuackHonk QuackHonk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Fixes the wrap around issue. The text formatting is legible in both light and dark mode.

@github-project-automation github-project-automation Bot moved this from Work in Progress to Awaiting Maintainer Review in Submitty Development Apr 3, 2026
@GarvitKhandelwal31

Copy link
Copy Markdown
Contributor

I have tested this, and have found two issues-

  1. When narrowing the screen width the button text is also visible like Link, Code, Bold and all. In my opinion that is taking a lot of space which is making things looking cramped. I mean can we just have the icon only. In that way we could save some space.
image
  1. Another thing is that when narrowing down the screen width we are removing Blockquote and Italics functionality, it does not feel right to me. Can we have an kebab button written "More" so Write/Preview remain stable while hidden actions are still accessible?

@bmcutler bmcutler moved this from Awaiting Maintainer Review to In Review in Submitty Development Apr 6, 2026
@elsume

elsume commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Display of issue onmain:

Screenshot 2026-04-10 at 12 30 47 PM

Display of changes:

Screenshot 2026-04-10 at 12 28 50 PM

The test here shows that the changes are working as intended. The write and preview tabs stay fixed, which looks nice and organized. Additionally, the surplus formatting buttons hide when there's no longer space for them.

I will comment that I think this behavior won't be helpful to users who may not know Markdown as they would benefit from the formatting buttons being available. A dropdown menu for the formatting options would be a good solution to this.

An example of how Github implements it:
Screenshot 2026-04-10 at 12 42 02 PM

@GarvitKhandelwal31

Copy link
Copy Markdown
Contributor

Display of issue onmain:

Screenshot 2026-04-10 at 12 30 47 PM ### Display of changes: Screenshot 2026-04-10 at 12 28 50 PM The test here shows that the changes are working as intended. The write and preview tabs stay fixed, which looks nice and organized. Additionally, the surplus formatting buttons hide when there's no longer space for them.

I will comment that I think this behavior won't be helpful to users who may not know Markdown as they would benefit from the formatting buttons being available. A dropdown menu for the formatting options would be a good solution to this.

An example of how Github implements it: Screenshot 2026-04-10 at 12 42 02 PM

I agree with this, in my opinion this drop-down menu should be implemented, the view will not look cramped also the functionalities will be available for the user to use.

@tijaruS

tijaruS commented Apr 11, 2026

Copy link
Copy Markdown
Contributor Author

Hi! @elsume @GarvitKhandelwal31 I have made it so that it look like github comment box i.e when a dropdown menu appears and those buttons are available there for the user to click.

Video

2026-04-11.17-52-52.mp4

@GarvitKhandelwal31

GarvitKhandelwal31 commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

Looks good to me.

@JManion32 JManion32 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is an elegant and well-implemented solution. I have a few functionality changes, the code looks good:

  1. When I make the screen narrow and toggle the kebab button, then make the screen wide again, the popup appears (on toggle), then disappears (when the screen gets wide), as expected. When I make the screen narrow again, the popup appears automatically without the need to click the button.
  2. I'm not a fan of the UI for the dropdown elements. I think they should be more simple, without the individual box for each entry:
Image

@github-project-automation github-project-automation Bot moved this from In Review to Work in Progress in Submitty Development May 1, 2026
@tijaruS

tijaruS commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for the suggestion. I will look into it and let you know when i am done.

@github-actions github-actions Bot added the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label May 21, 2026
@tijaruS

tijaruS commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

Hi @JManion32! I fixed the auto popup and made the ui as u asked.

Screenshots

  • image

@codecov

codecov Bot commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.67%. Comparing base (4ca4e71) to head (0908b94).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12713   +/-   ##
=========================================
  Coverage     21.67%   21.67%           
  Complexity     9802     9802           
=========================================
  Files           268      268           
  Lines         36724    36724           
  Branches        489      489           
=========================================
  Hits           7960     7960           
  Misses        28279    28279           
  Partials        485      485           
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.02% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.73% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GarvitKhandelwal31 GarvitKhandelwal31 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tijaruS Thanks for the great PR. I have verified the fix and the quality of the comment box is greatly improved. When narrowing down the transitions are smooth. Also I have verified @JManion32 's request and it looks aligned to me now.

@GarvitKhandelwal31 GarvitKhandelwal31 moved this from Work in Progress to Awaiting Maintainer Review in Submitty Development May 22, 2026
@github-actions github-actions Bot removed the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label May 23, 2026
@bmcutler
bmcutler merged commit a01d173 into Submitty:main Jun 1, 2026
22 of 25 checks passed
@github-project-automation github-project-automation Bot moved this from Awaiting Maintainer Review to Done in Submitty Development Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

ta grading overall comment box formatting is unclear on narrow panel

6 participants