[Bugfix:TAGrading] comment box formating in ta grading#12713
Conversation
QuackHonk
left a comment
There was a problem hiding this comment.
Does fix the main issue of the tabs not staying on the same horizontal axis! There still is the issue with the buttons (bold italic) wrapping around instead of being hidden off the page. Dark Mode/Light Mode issues. Once that's fixed it should be good
|
Hi! @QuackHonk I have made the changes you requested. The buttons look okay in light theme too. And Buttons are now being hidden instead of wrapping. Screenshots |
QuackHonk
left a comment
There was a problem hiding this comment.
Looks great! Fixes the wrap around issue. The text formatting is legible in both light and dark mode.
|
Hi! @elsume @GarvitKhandelwal31 I have made it so that it look like github comment box i.e when a dropdown menu appears and those buttons are available there for the user to click. Video2026-04-11.17-52-52.mp4 |
|
Looks good to me. |
JManion32
left a comment
There was a problem hiding this comment.
Overall, this is an elegant and well-implemented solution. I have a few functionality changes, the code looks good:
- When I make the screen narrow and toggle the kebab button, then make the screen wide again, the popup appears (on toggle), then disappears (when the screen gets wide), as expected. When I make the screen narrow again, the popup appears automatically without the need to click the button.
- I'm not a fan of the UI for the dropdown elements. I think they should be more simple, without the individual box for each entry:
|
Thank you for the suggestion. I will look into it and let you know when i am done. |
|
Hi @JManion32! I fixed the auto popup and made the ui as u asked. Screenshots |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12713 +/- ##
=========================================
Coverage 21.67% 21.67%
Complexity 9802 9802
=========================================
Files 268 268
Lines 36724 36724
Branches 489 489
=========================================
Hits 7960 7960
Misses 28279 28279
Partials 485 485
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
GarvitKhandelwal31
left a comment
There was a problem hiding this comment.
@tijaruS Thanks for the great PR. I have verified the fix and the quality of the comment box is greatly improved. When narrowing down the transitions are smooth. Also I have verified @JManion32 's request and it looks aligned to me now.










Why is this change important & necessary?
Fixes #12712
flex-wrap: wrapfrom.markdown-mode-buttonsmargin-topon.markdown-area-toolbarand.btn-markdownNew behavior
Other information