Skip to content

[Refactor:System] : Remove unused batchImportJSON function#12710

Merged
williamjallen merged 1 commit into
Submitty:mainfrom
ANIRUDH-SJ:remove-unused-batchImportJSON
Apr 30, 2026
Merged

[Refactor:System] : Remove unused batchImportJSON function#12710
williamjallen merged 1 commit into
Submitty:mainfrom
ANIRUDH-SJ:remove-unused-batchImportJSON

Conversation

@ANIRUDH-SJ

Copy link
Copy Markdown
Contributor

Summary

  • Remove the unused batchImportJSON() function from
    site/public/js/server.js
  • The function had a TODO comment noting it may be unused
  • A codebase-wide search confirmed zero references to this
    function

Test plan

  • Verify no JavaScript errors on pages that load server.js
  • Confirm no functionality regression in course management
    pages
    EOF

The function was flagged with a TODO noting it may be unused.
A full codebase search confirms it is never called anywhere.
@codecov

codecov Bot commented Mar 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.64%. Comparing base (02638f6) to head (375c02d).
⚠️ Report is 39 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12710   +/-   ##
=========================================
  Coverage     21.64%   21.64%           
  Complexity     9654     9654           
=========================================
  Files           268      268           
  Lines         36245    36245           
  Branches        487      487           
=========================================
  Hits           7846     7846           
  Misses        27916    27916           
  Partials        483      483           
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.04% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.66% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Apr 15, 2026
@bmcutler
bmcutler requested a review from williamjallen April 30, 2026 19:13
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to In Review in Submitty Development Apr 30, 2026
@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Apr 30, 2026
@williamjallen williamjallen changed the title [Cleanup] : Remove unused batchImportJSON function [Refactor:System] : Remove unused batchImportJSON function Apr 30, 2026
@williamjallen
williamjallen merged commit bee9e37 into Submitty:main Apr 30, 2026
27 of 29 checks passed
@github-project-automation github-project-automation Bot moved this from Awaiting Maintainer Review to Done in Submitty Development Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants