[Bugfix:InstructorUI] Fixed Released Date When Uploading#12699
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12699 +/- ##
=========================================
Coverage 21.64% 21.64%
Complexity 9654 9654
=========================================
Files 268 268
Lines 36245 36245
Branches 487 487
=========================================
Hits 7846 7846
Misses 27916 27916
Partials 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
elsume
changed the title
IDzyre
approved these changes
Mar 30, 2026
IDzyre
left a comment
IDzyre
left a comment
Member
There was a problem hiding this comment.
Fixes (another) bug with uploading a downloaded gradeable JSON file, and adds test to ensure functionality. Tested locally manually, and with Cypress.
Member
There was a problem hiding this comment.
Test looks good, moves the API downlaod test to directly after the upload, instead of after another UI upload, which increases readability.
| expect(test_json.ta_grading).to.eql(true); | ||
| expect(test_json.grade_inquiries).to.eql(true); | ||
| expect(test_json.rubric).to.eql(rubric); | ||
| expect(test_json.dates.has_release_date).to.eql(false); |
Member
There was a problem hiding this comment.
This is the line that adds the new testing functionality. You should create an issue to add testing for the rest of the date values not present here.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
Member
|
Failing test is the leaderboard gradeable test. |
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
bmcutler
pushed a commit
that referenced
this pull request
Jun 4, 2026
### Why is this Change Important & Necessary? Closes #12701 Extension of the test cases mentioned in PR #12699 Date values in the gradeable JSON upload/download cycle were not being tested. ### What is the New Behavior? Added assertions to verify that date values are correctly preserved when api_testing gradeable is downloaded. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. navigate to site directory 2. run the cypress test ### Automated Testing & Documentation This PR adds automated Cypress test coverage for date values in the gradeable JSON upload/download cycle. ### Other information Not a breaking change. No migrations required. No security concerns. Co-authored-by: dagemcn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Downloading and uploading should be consistent with the variables named so that functionality is maintained.
What is the New Behavior?
If the downloaded json file is uploaded, the data matches.
What steps should a reviewer take to reproduce or test the bug or new feature?
Download a Gradeable that does not have release dates and reupload it onto a different course to check if it has a release date. On this PR branch, see if it correctly displays.
Automated Testing & Documentation
Added cypress tests to verify.
Other information