[Refactor:System] Remove unnecessary setup script commits#12691
Merged
Conversation
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12691 +/- ##
=========================================
Coverage 21.64% 21.64%
Complexity 9654 9654
=========================================
Files 268 268
Lines 36245 36245
Branches 487 487
=========================================
Hits 7846 7846
Misses 27916 27916
Partials 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Rkoester47
approved these changes
Mar 31, 2026
Rkoester47
left a comment
Rkoester47
left a comment
Contributor
There was a problem hiding this comment.
These changes look good to me for reducing overhead during setup.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
hyeenaa
self-requested a review
March 31, 2026 21:00
automateprojectmangement
Bot
moved this from Awaiting Maintainer Review
to In Review
in Submitty Development
hyeenaa
approved these changes
Mar 31, 2026
hyeenaa
left a comment
hyeenaa
left a comment
Contributor
There was a problem hiding this comment.
changes are appropriate and properly avoid committing in a for loop, which would be more resource heavy compared to if you do it in one chunk.
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
The setup sample courses script currently commits after almost every database statement. The overhead of committing so frequently is nontrivial.
What is the New Behavior?
The setup sample courses script now commits fewer times inside loops. There's more work to be done here, but it'll require a broader overhaul of these scripts.