[Testing:Developer] Revert Failing Calendar CSS Lint#12673
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12673 +/- ##
=========================================
Coverage 21.64% 21.64%
Complexity 9654 9654
=========================================
Files 268 268
Lines 36245 36245
Branches 487 487
=========================================
Hits 7846 7846
Misses 27916 27916
Partials 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
automateprojectmangement
Bot
moved this from Seeking Reviewer
to In Review
in Submitty Development
Contributor
Author
|
It looks like the new leaderboard gradeable E2E test is also failing... I'll look into that in a separate PR. |
IDzyre
approved these changes
Mar 29, 2026
IDzyre
left a comment
IDzyre
left a comment
Member
There was a problem hiding this comment.
On my VM, retains the fix, but now passes the CSS lint.
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
GarvitKhandelwal31
pushed a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Apr 14, 2026
### Why is this Change Important & Necessary? Closes Submitty#12668 Submitty#12564 Improved the layout of the calendar, and also attempted to improve accessibility on different browsers. It was failing CSS lint since many of the rules were legacy. ### What is the New Behavior? Removed rules, but left functionality the same. If there is still an issue on specific browsers, we should make a new issue to adjust it specifically. ### What steps should a reviewer take to reproduce or test the bug or new feature? Calendar has fixed column widths and is responsive. ### Automated Testing & Documentation N / A ### Other information Not a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Closes #12668
#12564 Improved the layout of the calendar, and also attempted to improve accessibility on different browsers. It was failing CSS lint since many of the rules were legacy.
What is the New Behavior?
Removed rules, but left functionality the same. If there is still an issue on specific browsers, we should make a new issue to adjust it specifically.
What steps should a reviewer take to reproduce or test the bug or new feature?
Calendar has fixed column widths and is responsive.
Automated Testing & Documentation
N / A
Other information
Not a breaking change.