[Feature:Notifications] Auto-Mark Gradeable Notification Status by jeffrey-cordero · Pull Request #12658 · Submitty/Submitty

jeffrey-cordero · 2026-03-26T19:18:13Z

Why is this Change Important & Necessary?

Students previously had to manually click a notification or visit the notification page to mark gradeable release and grade release notifications when visiting the respective page via a link, which is a poor-quality-of-life experience.

What is the New Behavior?

When a student visits a gradeable page, any unseen grading notifications for that gradeable (submission open or grade release) are automatically marked as seen in a single database update.

What steps should a reviewer take to reproduce or test the bug or new feature?

Run the respective course migration.
Trigger a gradeable release or grade release notification via send_notification.py (udo -u "submitty_daemon" python3 sbin/send_notification.py: [Feature:Notifications] Released Gradeable Notification #11897 and [Feature:Notifications] Released grade notification #10358 have more in-depth explanations).
Log in as the notified student (notification bell should show unread).
Navigate to the gradeable page.
Verify the notification is now marked as seen (bell clears, notification panel shows read).

Automated Testing & Documentation

Unit tests have been added, but an issue will be made to extend this notification feature to end-to-end testing coverage.

Other information

N/A

…able

codecov · 2026-03-26T19:19:30Z

Codecov Report

❌ Patch coverage is 45.94595% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.73%. Comparing base (b2db10a) to head (433b1eb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12658      +/-   ##
============================================
+ Coverage     21.64%   21.73%   +0.09%     
- Complexity     9654     9660       +6     
============================================
  Files           268      268              
  Lines         36244    36273      +29     
  Branches        487      487              
============================================
+ Hits           7845     7884      +39     
+ Misses        27916    27906      -10     
  Partials        483      483

Flag	Coverage Δ
autograder	`21.32% <ø> (ø)`
js	`2.04% <ø> (ø)`
migrator	`100.00% <100.00%> (ø)`
php	`20.77% <44.44%> (+0.10%)`	⬆️
python_submitty_utils	`80.08% <ø> (ø)`
submitty_daemon_jobs	`91.13% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JManion32

This is a great quality of life change. I see many students with uncleared notifications, so I like the idea of having a system in place to automatically clear them.

I was unable to replicate the fix with existing notifications (from before I switched to the branch) and new notifications that I pushed with sudo -u "submitty_daemon" python3 sbin/send_notification.p

Also, just a thought. Should we add the gradeable_id field to Notification.ts? It won't get used, but since we are updating the serialize function and sending it, maybe we should.

JManion32 · 2026-03-27T19:37:37Z

+    )
+    database.execute(
+        """
+        ALTER TABLE notifications DROP COLUMN IF EXISTS gradeable_id


Should the down migration remove a data? Why not just leave it in the case of a rollback?

I can clear the down migration. The tied gradeable ID value seemed simple to apply, so clearing it made sense at the time to save space.

jeffrey-cordero · 2026-03-27T20:17:37Z

This is a great quality of life change. I see many students with uncleared notifications, so I like the idea of having a system in place to automatically clear them.

I was unable to replicate the fix with existing notifications (from before I switched to the branch) and new notifications that I pushed with sudo -u "submitty_daemon" python3 sbin/send_notification.p

Also, just a thought. Should we add the gradeable_id field to Notification.ts? It won't get used, but since we are updating the serialize function and sending it, maybe we should.

You ran the migration and updated the server code and still couldn't get notifications to be marked as seen when visiting the respective gradeable submission page? Adding the field makes sense if icons for gradeables are differentiated on the front end or just to be consistent with other features, otherwise it seems like wasted bytes over the network. Are gradeable notification icons unique?

JManion32 · 2026-03-27T20:42:42Z

You ran the migration and updated the server code and still couldn't get notifications to be marked as seen when visiting the respective gradeable submission page? Adding the field makes sense if icons for gradeables are differentiated on the front end or just to be consistent with other features, otherwise it seems like wasted bytes over the network. Are gradeable notification icons unique?

Okay, this clears things up for me and yes, I am able to replicate the feature.

Leaving the gradeable_id field out makes sense to me as well.

The only uncertainty I have now is with the "backfill" migration. Notifications that were created before running the migration do not get marked as seen when I go to that gradeable's submission page. Am I misunderstanding how this should work?

jeffrey-cordero · 2026-03-28T17:58:28Z

You ran the migration and updated the server code and still couldn't get notifications to be marked as seen when visiting the respective gradeable submission page? Adding the field makes sense if icons for gradeables are differentiated on the front end or just to be consistent with other features, otherwise it seems like wasted bytes over the network. Are gradeable notification icons unique?

Okay, this clears things up for me and yes, I am able to replicate the feature.

Leaving the gradeable_id field out makes sense to me as well.

The only uncertainty I have now is with the "backfill" migration. Notifications that were created before running the migration do not get marked as seen when I go to that gradeable's submission page. Am I misunderstanding how this should work?

This is exactly how it should work. I tested with both new gradeables and all base gradeable notifications that are seeded by the notification script after a fresh vagrant up. SELECT * FROM notifications WHERE gradeable_id IS NOT NULL LIMIT 100; within the SQL Toolbox should be non-empty with a variety of unique users after the migration script is run.

JManion32

Functionality is as expected and code code changes are reasonable. I verified that both new notifications and existing ones will always have gradeable_id attached after the migration runs. Great work!

…itty#12658) ### Why is this Change Important & Necessary? Students previously had to manually click a notification or visit the notification page to mark gradeable release and grade release notifications when visiting the respective page via a link, which is a poor-quality-of-life experience. ### What is the New Behavior? When a student visits a gradeable page, any unseen grading notifications for that gradeable (submission open or grade release) are automatically marked as seen in a single database update. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Run the respective course migration. 2. Trigger a gradeable release or grade release notification via `send_notification.py` (`udo -u "submitty_daemon" python3 sbin/send_notification.py`: Submitty#11897 and Submitty#10358 have more in-depth explanations). 3. Log in as the notified student (notification bell should show unread). 4. Navigate to the gradeable page. 5. Verify the notification is now marked as seen (bell clears, notification panel shows read). ### Automated Testing & Documentation  Unit tests have been added, but an issue will be made to extend this notification feature to end-to-end testing coverage. ### Other information N/A --------- Co-authored-by: Justin Manion <[email protected]>

jeffrey-cordero added 9 commits March 26, 2026 09:08

Mark gradeable notification as seen foundations

27b5b79

Working update notification for released grades and submissions avail…

316f07a

…able

Account for existing gradeables

d5f6139

Account for pg_dump 17 adding \[un]restrict <token> lines

c177e4a

Linting

0b133b6

Refactor from grading to gradeable naming convention

bbd813b

Refactoring

c624051

Additional refactoring

6349c7e

Minor fixes

3cc3785

github-project-automation Bot added this to Submitty Development Mar 26, 2026

github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Mar 26, 2026

Fix DB dump

782f0cb

roye2 self-requested a review March 27, 2026 00:56

automateprojectmangement Bot moved this from Seeking Reviewer to In Review in Submitty Development Mar 27, 2026

roye2 removed their request for review March 27, 2026 00:57

JManion32 requested changes Mar 27, 2026

View reviewed changes

github-project-automation Bot moved this from In Review to Work in Progress in Submitty Development Mar 27, 2026

jeffrey-cordero and others added 2 commits March 28, 2026 13:49

Remove down migration

95f927b

Merge branch 'main' into sync-gradeable-notifications

362da94

jeffrey-cordero moved this from Work in Progress to In Review in Submitty Development Mar 28, 2026

jeffrey-cordero and others added 2 commits March 29, 2026 12:40

Merge branch 'main' into sync-gradeable-notifications

e6e8120

Merge branch 'main' into sync-gradeable-notifications

18afe9c

JManion32 approved these changes Mar 31, 2026

View reviewed changes

github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Mar 31, 2026

Merge branch 'main' into sync-gradeable-notifications

433b1eb

bmcutler merged commit 6c55ef3 into main Apr 10, 2026
24 of 25 checks passed

bmcutler deleted the sync-gradeable-notifications branch April 10, 2026 19:07

github-project-automation Bot moved this from Awaiting Maintainer Review to Done in Submitty Development Apr 10, 2026

not-so-shubh mentioned this pull request Apr 12, 2026

Gradeable submission pages crash on main due to invalid notifications.gradeable_id query #12774

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Feature:Notifications] Auto-Mark Gradeable Notification Status#12658

[Feature:Notifications] Auto-Mark Gradeable Notification Status#12658
bmcutler merged 15 commits into
mainfrom
sync-gradeable-notifications

jeffrey-cordero commented Mar 26, 2026

Uh oh!

codecov Bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

JManion32 left a comment

Uh oh!

JManion32 Mar 27, 2026

Uh oh!

jeffrey-cordero Mar 27, 2026

Uh oh!

Uh oh!

jeffrey-cordero commented Mar 27, 2026

Uh oh!

JManion32 commented Mar 27, 2026

Uh oh!

jeffrey-cordero commented Mar 28, 2026

Uh oh!

JManion32 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

jeffrey-cordero commented Mar 26, 2026

Why is this Change Important & Necessary?

What is the New Behavior?

What steps should a reviewer take to reproduce or test the bug or new feature?

Automated Testing & Documentation

Other information

Uh oh!

codecov Bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JManion32 left a comment

Choose a reason for hiding this comment

Uh oh!

JManion32 Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

jeffrey-cordero Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jeffrey-cordero commented Mar 27, 2026

Uh oh!

JManion32 commented Mar 27, 2026

Uh oh!

jeffrey-cordero commented Mar 28, 2026

Uh oh!

JManion32 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Mar 26, 2026 •

edited

Loading