[Testing:Autograding] Add non-zero depends_on_points test by Mohit23490 · Pull Request #12635 · Submitty/Submitty

Mohit23490 · 2026-03-24T00:42:40Z

Why is this Change Important & Necessary?
Fixes #11696

The existing locked gradeable test only covers eg_depends_on_points: 0.
This PR adds tests for non-zero depends_on_points to ensure autograding
point thresholds are correctly enforced.

What is the New Behavior?

Added gradeable locked_homework_points with eg_depends_on_points: 7
in testing.yml
Added Cypress test verifying users without 7+ points cannot access
the locked gradeable
Added Cypress test verifying users with 7+ points can access it

What steps should a reviewer take to reproduce or test the bug or new feature?

Run: recreate_sample_courses --test_only_grading
Run: npx cypress run --spec "site/cypress/e2e/Cypress-Feature/grades.spec.js"
Verify new test "Should test locked gradeable with non-zero depends_on_points" passes

Automated Testing & Documentation
Cypress end-to-end test added in grades.spec.js.
No documentation changes needed.

Other information
Not a breaking change. No migrations needed. No security concerns.

IDzyre · 2026-03-24T18:16:09Z

Hey @Mohit23490 , thank you for your contribution!

Please update your PR title to use our required format
[<TYPE>:<MODULE>] <SUBJECT>, where <SUBJECT> is 40 chars max.
See also: https://submitty.org/developer/getting_started/make_a_pull_request

Please also use our PR description template:
https://raw.githubusercontent.com/Submitty/Submitty/refs/heads/main/.github/PULL_REQUEST_TEMPLATE.md
and ensure the information in your description is accurate.

Also, please address merge conflicts.

Once this pull request adheres to all Submitty conventions, we may run the CI on your PR. If the CI passes we will proceed with a full review.

codecov · 2026-03-25T17:41:09Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.64%. Comparing base (4e310f6) to head (aa0f92f).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12635      +/-   ##
============================================
- Coverage     21.64%   21.64%   -0.01%     
  Complexity     9861     9861              
============================================
  Files           268      268              
  Lines         36918    36920       +2     
  Branches        495      495              
============================================
  Hits           7990     7990              
- Misses        28437    28439       +2     
  Partials        491      491

Flag	Coverage Δ
autograder	`21.32% <ø> (ø)`
js	`2.01% <ø> (ø)`
migrator	`100.00% <ø> (ø)`
php	`20.70% <ø> (-0.01%)`	⬇️
python_submitty_utils	`80.08% <ø> (ø)`
submitty_daemon_jobs	`91.13% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Mohit23490 · 2026-03-26T01:37:56Z

The JavaScript lint errors on lines 2-12 of gradeable.spec.js appear to be pre-existing indentation issues in the upstream code and are not related to my changes. My changes only add a new test at the end of the file.
I have fixed the YAML lint error (missing newline at end of testing.yml).
Should I fix the pre-existing lint issues in gradeable.spec.js as part of this PR or should that be addressed separately?

IDzyre · 2026-03-27T17:54:31Z

Is there a reason your deleting existing tests instead of just adding new tests to the end?

Thank you for the review.
I apologize for the confusion — this was unintentional during merge conflict resolution. I will restore the existing tests immediately.

Apologies again for the confusion. The existing tests were accidentally removed during merge conflict resolution — it was not intentional. I have now restored all original tests and added my new test at the end of the file without modifying anything else.
I am also working on setting up Submitty locally to be able to run and verify the tests before pushing. I will make sure this does not happen again

dandrecollins07-ctrl

Verified that the new test correctly covers non-zero eg_depends_on_points behavior using a 7-point threshold instead of the original 0. Fixed lint issues encountered during review. Approving.

williamschen23

looks good, tested and worked well

IDzyre

One small request for the Cypress test portion.

mattLif

Tested Cypress test and it passed and cleaned up successfully. Code for test and sample data look good, and it seems like the requested changes have been made. Only CI that fail are flaky on main. I'm approving.

IDzyre

The test looks good overall, but didn't pass on CI (Cypress-Gradeable is failing the gradeable.spec, at the "depends_on_points", may be a CI vs local issue, but I haven't tested locally).

github-project-automation Bot added this to Submitty Development Mar 24, 2026

github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Mar 24, 2026

Mohit23490 mentioned this pull request Mar 24, 2026

Cypress test for non-zero autograding lock #11696

Closed

Mohit23490 changed the title ~~Add Cypress test for non-zero depends_on_points (#11696)~~ [Testing:Autograding] Add non-zero depends_on_points test Mar 25, 2026

Add Cypress test for non-zero depends_on_points (Submitty#11696)

4d448e8

Mohit23490 force-pushed the cypress-test-nonzero-depends-on-points branch from eaa0a19 to 4d448e8 Compare March 25, 2026 01:40

Fix missing newline at end of testing.yml

6aec141

Fix indentation in locked gradeable test

d446edb

IDzyre reviewed Mar 27, 2026

View reviewed changes

Mohit23490 added 2 commits March 28, 2026 01:30

Restore original tests and add non-zero depends_on_points test

4e825b0

Merge branch 'main' into cypress-test-nonzero-depends-on-points

3f8a404

github-actions Bot added the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Apr 13, 2026

dandrecollins07-ctrl added 2 commits June 8, 2026 12:03

Merge branch 'main' into cypress-test-nonzero-depends-on-points

05de6d2

Fix lint errors in non-zero depends_on_points test

c44c084

dandrecollins07-ctrl self-assigned this Jun 8, 2026

dandrecollins07-ctrl approved these changes Jun 8, 2026

View reviewed changes

github-project-automation Bot moved this from Seeking Reviewer to Awaiting Maintainer Review in Submitty Development Jun 8, 2026

bmcutler requested a review from williamschen23 June 8, 2026 18:50

automateprojectmangement Bot moved this from Awaiting Maintainer Review to In Review in Submitty Development Jun 8, 2026

Merge branch 'main' into cypress-test-nonzero-depends-on-points

8b298cd

github-actions Bot removed the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Jun 9, 2026

williamschen23 approved these changes Jun 9, 2026

View reviewed changes

github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Jun 9, 2026

IDzyre requested changes Jun 9, 2026

View reviewed changes

Comment thread site/cypress/e2e/Cypress-Gradeable/gradeable.spec.js Outdated

github-project-automation Bot moved this from Awaiting Maintainer Review to Work in Progress in Submitty Development Jun 9, 2026

williamschen23 added 2 commits June 11, 2026 19:14

use .should instead of .contains

f31689a

revert unnecessary changes:

aa0f92f

mattLif approved these changes Jun 18, 2026

View reviewed changes

IDzyre requested changes Jun 18, 2026

View reviewed changes

bmcutler merged commit 5831685 into Submitty:main Jun 19, 2026
23 of 26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Testing:Autograding] Add non-zero depends_on_points test#12635

[Testing:Autograding] Add non-zero depends_on_points test#12635
bmcutler merged 10 commits into
Submitty:mainfrom
Mohit23490:cypress-test-nonzero-depends-on-points

Mohit23490 commented Mar 24, 2026 •

edited

Loading

Uh oh!

IDzyre commented Mar 24, 2026

Uh oh!

codecov Bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

Mohit23490 commented Mar 26, 2026

Uh oh!

IDzyre Mar 27, 2026

Uh oh!

Mohit23490 Mar 28, 2026

Uh oh!

Mohit23490 Mar 28, 2026

Uh oh!

dandrecollins07-ctrl left a comment

Uh oh!

williamschen23 left a comment

Uh oh!

IDzyre left a comment

Uh oh!

Uh oh!

mattLif left a comment

Uh oh!

IDzyre left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Mohit23490 commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IDzyre commented Mar 24, 2026

Uh oh!

codecov Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Mohit23490 commented Mar 26, 2026

Uh oh!

IDzyre Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Mohit23490 Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

Mohit23490 Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

dandrecollins07-ctrl left a comment

Choose a reason for hiding this comment

Uh oh!

williamschen23 left a comment

Choose a reason for hiding this comment

Uh oh!

IDzyre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mattLif left a comment

Choose a reason for hiding this comment

Uh oh!

IDzyre left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Mohit23490 commented Mar 24, 2026 •

edited

Loading

codecov Bot commented Mar 25, 2026 •

edited

Loading

IDzyre left a comment •

edited

Loading