[UI/UX:Submission] Fix scroll lock#12629
Merged
williamjallen merged 5 commits intoMar 28, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12629 +/- ##
=========================================
Coverage 21.65% 21.65%
Complexity 9650 9650
=========================================
Files 268 268
Lines 36231 36231
Branches 487 487
=========================================
Hits 7846 7846
Misses 27902 27902
Partials 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
@GarvitKhandelwal31 Please address failing CI |
Contributor
Author
|
@JManion32 Done. I even verified the JS lint errors locally, they are passing now. |
Rkoester47
approved these changes
Mar 24, 2026
Rkoester47
left a comment
Rkoester47
left a comment
Contributor
There was a problem hiding this comment.
I tested the changes made on this branch and they do seem to have effectively resolved the issue. On main, attempting to upload a profile picture will hide the scrollbar regardless of if it fails or succeeds. On this branch, uploading does not affect the scroll bar at all either way. Good work solving this issue.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
QuackHonk
self-requested a review
March 24, 2026 19:20
QuackHonk
approved these changes
Mar 24, 2026
QuackHonk
left a comment
QuackHonk
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Fixes the bug without creating new ones.
automateprojectmangement
Bot
moved this from Awaiting Maintainer Review
to In Review
in Submitty Development
Farhanxikram
approved these changes
Mar 27, 2026
Farhanxikram
left a comment
Farhanxikram
left a comment
There was a problem hiding this comment.
Functionality review:
everything looks good to me, didn't see any new bugs and this fixed the bug addressed in the issue :)
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
GarvitKhandelwal31
added a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Mar 29, 2026
### Why is this Change Important & Necessary? Closes Submitty#12628. Uploading a new profile photo on My Profile could leave page scrolling disabled until a full reload. This is a UI regression that impacts usability and can make the page feel stuck after a successful upload. ### What is the New Behavior? After submitting the profile photo form (both success and error paths), the modal closes through the shared popup close handler so scroll state is correctly restored. The page remains scrollable immediately, without requiring a refresh. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Start Submitty in Vagrant and log in. 2. Navigate to My Profile. 3. Confirm the page is scrollable (if content exceeds viewport). 4. Click Upload profile photo. 5. Test error path: - Click Submit without selecting a file. - Confirm error message appears. - Confirm page scrolling is still enabled. https://github.com/user-attachments/assets/b716d45f-603d-46a6-bac6-a5222c2ef3a9 6. Test success path: - Reopen Upload profile photo. - Select a valid image and click Submit. - Confirm success message appears. - Confirm page scrolling is still enabled (no reload needed). https://github.com/user-attachments/assets/10964e9b-53a2-4137-a765-add1a6527027 ### Automated Testing & Documentation - Added Cypress regression assertions in the profile photo upload test to verify body does not retain the no-scroll class after submit (error and success scenarios). - No submitty.org documentation update is required for this bugfix. ### Other information - Breaking change: No. - Migrations required: No. - Security concerns: None identified. - Sysadmin action required: No.
GarvitKhandelwal31
added a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Apr 14, 2026
### Why is this Change Important & Necessary? Closes Submitty#12628. Uploading a new profile photo on My Profile could leave page scrolling disabled until a full reload. This is a UI regression that impacts usability and can make the page feel stuck after a successful upload. ### What is the New Behavior? After submitting the profile photo form (both success and error paths), the modal closes through the shared popup close handler so scroll state is correctly restored. The page remains scrollable immediately, without requiring a refresh. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Start Submitty in Vagrant and log in. 2. Navigate to My Profile. 3. Confirm the page is scrollable (if content exceeds viewport). 4. Click Upload profile photo. 5. Test error path: - Click Submit without selecting a file. - Confirm error message appears. - Confirm page scrolling is still enabled. https://github.com/user-attachments/assets/b716d45f-603d-46a6-bac6-a5222c2ef3a9 6. Test success path: - Reopen Upload profile photo. - Select a valid image and click Submit. - Confirm success message appears. - Confirm page scrolling is still enabled (no reload needed). https://github.com/user-attachments/assets/10964e9b-53a2-4137-a765-add1a6527027 ### Automated Testing & Documentation - Added Cypress regression assertions in the profile photo upload test to verify body does not retain the no-scroll class after submit (error and success scenarios). - No submitty.org documentation update is required for this bugfix. ### Other information - Breaking change: No. - Migrations required: No. - Security concerns: None identified. - Sysadmin action required: No.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Closes #12628.
Uploading a new profile photo on My Profile could leave page scrolling disabled until a full reload. This is a UI regression that impacts usability and can make the page feel stuck after a successful upload.
What is the New Behavior?
After submitting the profile photo form (both success and error paths), the modal closes through the shared popup close handler so scroll state is correctly restored. The page remains scrollable immediately, without requiring a refresh.
What steps should a reviewer take to reproduce or test the bug or new feature?
Screen.Recording.2026-03-23.104155.mp4
Screen.Recording.2026-03-23.104456.mp4
Automated Testing & Documentation
Other information