[Refactor:Autograding] Deprecate submitty_count#12609
Draft
tijaruS wants to merge 18 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12609 +/- ##
=========================================
Coverage 21.10% 21.10%
Complexity 10115 10115
=========================================
Files 282 282
Lines 38265 38265
Branches 596 596
=========================================
Hits 8074 8074
Misses 29609 29609
Partials 582 582
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hello can anyone review this pr? @williamjallen |
GarvitKhandelwal31
left a comment
Contributor
There was a problem hiding this comment.
@tijaruS Please fix the CI/ Integration workflow, before I can start with the review.
This was referenced Jun 25, 2026
dagemcn
marked this pull request as draft
June 25, 2026 20:03
bmcutler
pushed a commit
to Submitty/DockerImages
that referenced
this pull request
Jul 13, 2026
### What is the current behavior? Fixes Submitty [Issue#11784](Submitty/Submitty#11784) - This one of the companion PRs to Submitty [PR#12609](Submitty/Submitty#12609). ### What is the new behavior? submitty_count is longer installed in preparation for deprecation. ### Other information? <!-- Is this a breaking change? --> This is a breaking change. Any autograding that uses the old submitty_count instead of submitty_count_ts will no longer work. <!-- How did you test --> 1. Follow the instructions on [this page](https://submitty.org/instructor/autograding/docker_images) up to step 6 with the Dockerfile modified in this PR. (you may be able to reuse the one I used `dagemcn/dockerimages:default-test` adding it through docker UI) 2. After you have added the new docker image with the DockerUI, update the config of any gradeable with `submitty_count` with ``` "autograding_method": "docker", "container_options": { "container_image": "IMAGE_NAME" }, ``` where `IMAGE_NAME` is the name of the image, for example, `dagemcn/dockerimages:default-test` if you reused mine. 3. Create a gradeable using submitty_count, (Tutorial examples 04, 06, and 07 all utilize submitty_count) 4. Test that submitty_count will not work in the config and that submitty_count_ts successfully runs 5. Also test that regular autograding works successfully on the image Attached is a zip of a sample solution and gradeable config with both submitty_count and submitty_count_ts commands present for testing. [example.zip](https://github.com/user-attachments/files/29638384/example.zip)
bmcutler
pushed a commit
to Submitty/DockerImagesRPI
that referenced
this pull request
Jul 13, 2026
### What is the current behavior? Fixes Submitty [Issue#11784](Submitty/Submitty#11784) - This one of the companion PRs to Submitty [PR#12609](Submitty/Submitty#12609). ### What is the new behavior? submitty_count is longer installed in preparation for deprecation. ### Other information? <!-- Is this a breaking change? --> This is a breaking change. Any autograding that uses the old submitty_count instead of submitty_count_ts will no longer work. <!-- How did you test --> 1. Follow the instructions on [this page](https://submitty.org/instructor/autograding/docker_images) up to step 6 with the Dockerfile modified in this PR. (you may be able to reuse the one I used `dagemcn/dockerimages:csci1200-test` adding it through docker UI) 2. After you have added the new docker image with the DockerUI, update the config of any gradeable with `submitty_count` with ``` "autograding_method": "docker", "container_options": { "container_image": "IMAGE_NAME" }, ``` where `IMAGE_NAME` is the name of the image, for example, `dagemcn/dockerimages:csci1200-test` if you reused mine. 3. Create a gradeable using submitty_count, (Tutorial examples 04, 06, and 07 all utilize submitty_count) 4. Test that submitty_count will not work in the config and that submitty_count_ts successfully runs 5. Also test that regular autograding works successfully on the image Attached is a zip of a sample solution and gradeable config with both submitty_count and submitty_count_ts commands present for testing. [example.zip](https://github.com/user-attachments/files/29638384/example.zip)
bmcutler
pushed a commit
to Submitty/Tutorial
that referenced
this pull request
Jul 13, 2026
### What is the current behavior? Fixes Submitty [Issue#11784](Submitty/Submitty#11784) - This one of the companion PRs to Submitty [PR#12609](Submitty/Submitty#12609). The tutorial courses 04 - Python Static Analysis, 06 - Loop Types, and 07 - Loop Depth all use `submitty_count` in their autograding configs. This command is being deprecated, so we should update it. ### What is the new behavior? `submitty_count` has been removed from `04 - Python Static Analysis` and `06 - Loop Types` and replaced with `submitty_count_ts` in preparation for deprecation. For `07 - Loop Depth`, there was no equivalent functionality present in `submitty_count_ts` so the testcase is entirely commented out. ### Other information? <!-- Is this a breaking change? --> This specific PR is not a breaking change. However, the other PRs accompanying this one are breaking PRs. <!-- How did you test --> Tested that all homework configs still build and their accompanying still submissions work as intended.
roye2
requested changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why is this Change Important & Necessary?
Fixes #11784
This change is necessary to fully deprecate
submitty_countfrom AnalysisTools as it has been replaced by the more modern Tree-sitter-basedsubmitty_count_ts. The old tool is being phased out, and this PR cleans up the remaining infrastructure and examples.Related to: https://submitty.org/instructor/autograding/static_analysis/count
Alongside this PR there are 3 other companion PRs in other Submitty repos.
DockerImages - PR#75 - merged
DockerImagesRPI - PR#41 - merged
Tutorial - PR#56 - merged
What is the New Behavior?
submitty_countis no longer in the allowed autograding commands by default.The autograder (
TestCase.cpp/TestCase.h) no longer contains specific logic or resource limit adjustments forsubmitty_count.All
submitty_countcommands in thepython_multipart_static_analysisexample and its associated tests have been updated to use thesubmitty_count_tssyntax.Submitty count is also no longer installed on the autograding-default docker image, the docker image for csci1200, and is no longer used in the tutorial examples.
What steps should a reviewer take to reproduce or test the bug or new feature?
vagrant destroyandvagrant upwith from scratchpython_multipart_static_analysisstill builds and autogrades correctly.submitty_countis no longer listed in/usr/local/submitty/config/allowed_autograding_commands_default.jsonafter running an installation.Also refer to the testing instructions in the 3 companion PRs. There will be instructions how to test the changes they made.
Automated Testing & Documentation
submitty_count_tsis already available on submitty.org but the page should be updated.Other Information
THIS IS A BREAKING CHANGE - any custom gradeables still manually using
submitty_countwill need theirconfig.jsonupdated to usesubmitty_count_ts.There are no migrations.
No security concerns.