Skip to content

[Bugfix:Submission] Fix non-VCS repo error#12608

Merged
bmcutler merged 19 commits into
Submitty:mainfrom
RishikaBothra:fix/team-page-vcs-repo-message
May 5, 2026
Merged

[Bugfix:Submission] Fix non-VCS repo error#12608
bmcutler merged 19 commits into
Submitty:mainfrom
RishikaBothra:fix/team-page-vcs-repo-message

Conversation

@RishikaBothra

@RishikaBothra RishikaBothra commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

Closes #12579

This change is important because, in team gradeables even when the assignment doesn't say to submit it as Git/VCS repo it states the error message ->Your repo doesn't exist contact your instructor... .This message should only appear for VCS assignments. Not for Non-VCS(file) assignment

What is the New Behavior?

Before => There was error in team gradeables that repo doesn't exist even if the assignment was Non-VCS
image

After=> Now it first checks if the assignment is of GIT/VCS if yes then only shows that error if not then it does not shows that error.
image

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. Login as student
  2. Go in any courses (for eg.sample)
  3. In the section of gradeables you will see a gradeables with blue box named MANAGE TEAM (for eg.Open Team Homework)
image 4. Click the MANAGE TEAM button image 5. Before fix: "Your repository does not exist" error incorrectly appears 6. After fix: No repository message appears

Automated Testing & Documentation

A Cypress test at:
site/cypress/e2e/Cypress-Gradeable/team_repository_message.spec.js

  • Non-VCS team gradeables: repo message should NOT appear
  • VCS team gradeables without repo: error message should appear
  • VCS team gradeables with repo: git clone instructions should appear

Other information

  • No breaking
  • No migrations
  • No security concerns

@IDzyre

IDzyre commented Mar 24, 2026

Copy link
Copy Markdown
Member

Hey @RishikaBothra, thank you for your contribution!

Please update your PR title to use our required format
[<TYPE>:<MODULE>] <SUBJECT>, where <SUBJECT> is 40 chars max.
See also: https://submitty.org/developer/getting_started/make_a_pull_request

Please also use our PR description template:
https://raw.githubusercontent.com/Submitty/Submitty/refs/heads/main/.github/PULL_REQUEST_TEMPLATE.md

Also, ensure tests are passing in CI.

Once this pull request adheres to all Submitty conventions, we will proceed with a full review.

@codecov

codecov Bot commented Mar 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.67%. Comparing base (9cd4e2f) to head (9a2a287).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12608   +/-   ##
=========================================
  Coverage     21.67%   21.67%           
  Complexity     9807     9807           
=========================================
  Files           268      268           
  Lines         36722    36722           
  Branches        490      490           
=========================================
  Hits           7960     7960           
  Misses        28276    28276           
  Partials        486      486           
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.02% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.73% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RishikaBothra RishikaBothra changed the title [Bugfix] : Remove the error coming in team gradeables of repo does not exist even when it is file submission(Non-VCS) [Bugfix:team-gradeables] Fix non-VCS repo error Mar 25, 2026
@RishikaBothra

Copy link
Copy Markdown
Contributor Author

Hey @RishikaBothra, thank you for your contribution!

Please update your PR title to use our required format [<TYPE>:<MODULE>] <SUBJECT>, where <SUBJECT> is 40 chars max. See also: https://submitty.org/developer/getting_started/make_a_pull_request

Please also use our PR description template: https://raw.githubusercontent.com/Submitty/Submitty/refs/heads/main/.github/PULL_REQUEST_TEMPLATE.md

Also, ensure tests are passing in CI.

Once this pull request adheres to all Submitty conventions, we will proceed with a full review.

Hi @IDzyre . I did the change in the name of the PR as u suggest and also corrected the CI test case error.

@RishikaBothra RishikaBothra changed the title [Bugfix:team-gradeables] Fix non-VCS repo error [Bugfix:team-Submission] Fix non-VCS repo error Mar 25, 2026
@RishikaBothra RishikaBothra changed the title [Bugfix:team-Submission] Fix non-VCS repo error [Bugfix:Submission] Fix non-VCS repo error Mar 25, 2026
@RishikaBothra

Copy link
Copy Markdown
Contributor Author

Hi @IDzyre . Fixed the new issues which came in CI test

Comment thread site/cypress/e2e/Cypress-Gradeable/team_repository_message.spec.js Outdated
@RishikaBothra

Copy link
Copy Markdown
Contributor Author

Hi @IDzyre,
The CSS Lint failures appear to be coming from files that were not modified as part of this PR, but from existing CSS files in the codebase. Could you please advise on how I should proceed with this?

Comment thread .github/workflows/ci.yml Outdated
@github-project-automation github-project-automation Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Mar 29, 2026
@williamjallen

Copy link
Copy Markdown
Member

@RishikaBothra CSS lint is back to passing with the most recent changes from main.

@automateprojectmangement automateprojectmangement Bot moved this from Work in Progress to In Review in Submitty Development Mar 30, 2026
@github-actions github-actions Bot added the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Apr 27, 2026
@roye2
roye2 dismissed williamjallen’s stale review April 30, 2026 19:03

changes requested were done

@roye2
roye2 self-requested a review April 30, 2026 19:03

@roye2 roye2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes and this did prevent the message from displaying when it shouldn't. Additionally, the message still displays if the repository really does not exist on a team gradeable. Thanks for writing a Cypress test about this. I also verified that it works as intended.

@github-project-automation github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Apr 30, 2026
@github-actions github-actions Bot removed the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label May 1, 2026
@bmcutler
bmcutler merged commit b4303a1 into Submitty:main May 5, 2026
26 checks passed
@github-project-automation github-project-automation Bot moved this from Awaiting Maintainer Review to Done in Submitty Development May 5, 2026
prestoncarman added a commit that referenced this pull request May 21, 2026
* main: (50 commits)
  [Bugfix:Developer] Fix Broken CI (#12851)
  [Bugfix:System] Restore TCLAPP (#12850)
  [Bugfix:Submission] Fix non-VCS repo error (#12608)
  [Feature:Submission] Jupyter warnings outside notebook (#12523)
  [Bugfix:InstructorUI] Removed feature flag for Bulk Late Days (#12826)
  [Bugfix:Forum] Fix stats header rendering (#12698)
  [Bugfix:Autograding] Fix negative number tolerance (#12569)
  [Bugfix:HelpQueue] Always use Abbreviated Names in OH (#12820)
  [Bugfix:Autograding] Fix regrade team detection (#12737)
  [Dependency] Bump Lichen from v23.09.00 to v26.04.01 (#12823)
  [Dependency] Bump RainbowGrades from v25.10.00 to v26.04.01 (#12824)
  [Feature:Developer] Remove misc Java utils and TCLAPP (#12819)
  [Bugfix:TAGrading] Fix 2-panel open-document select (#12577)
  [Dependency] Bump AnalysisToolsTS from v23.10.00 to v26.04.00 (#12822)
  [Bugfix:Developer] Fix bump_repo permissions (#12821)
  [Bugfix:InstructorUI] Change Colors to match in Docker UI table (#12739)
  [Bugfix:Forum] Reduce Page Caching (#12339)
  [Bugfix:System] File lost when running install clean fix (#12158)
  [Bugfix:Submission] No File Rubric submit all user groups (#12812)
  [Dependency] Bump twig/markdown-extra from 3.23.0 to 3.24.0 in /site (#12721)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

repository error message on manage team page

5 participants