[Bugfix:Submission] Fix non-VCS repo error#12608
Conversation
…heck and improve user guidance
|
Hey @RishikaBothra, thank you for your contribution! Please update your PR title to use our required format Please also use our PR description template: Also, ensure tests are passing in CI. Once this pull request adheres to all Submitty conventions, we will proceed with a full review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12608 +/- ##
=========================================
Coverage 21.67% 21.67%
Complexity 9807 9807
=========================================
Files 268 268
Lines 36722 36722
Branches 490 490
=========================================
Hits 7960 7960
Misses 28276 28276
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Hi @IDzyre . I did the change in the name of the PR as u suggest and also corrected the CI test case error. |
|
Hi @IDzyre . Fixed the new issues which came in CI test |
|
Hi @IDzyre, |
|
@RishikaBothra CSS lint is back to passing with the most recent changes from main. |
roye2
left a comment
There was a problem hiding this comment.
I tested the changes and this did prevent the message from displaying when it shouldn't. Additionally, the message still displays if the repository really does not exist on a team gradeable. Thanks for writing a Cypress test about this. I also verified that it works as intended.
* main: (50 commits) [Bugfix:Developer] Fix Broken CI (#12851) [Bugfix:System] Restore TCLAPP (#12850) [Bugfix:Submission] Fix non-VCS repo error (#12608) [Feature:Submission] Jupyter warnings outside notebook (#12523) [Bugfix:InstructorUI] Removed feature flag for Bulk Late Days (#12826) [Bugfix:Forum] Fix stats header rendering (#12698) [Bugfix:Autograding] Fix negative number tolerance (#12569) [Bugfix:HelpQueue] Always use Abbreviated Names in OH (#12820) [Bugfix:Autograding] Fix regrade team detection (#12737) [Dependency] Bump Lichen from v23.09.00 to v26.04.01 (#12823) [Dependency] Bump RainbowGrades from v25.10.00 to v26.04.01 (#12824) [Feature:Developer] Remove misc Java utils and TCLAPP (#12819) [Bugfix:TAGrading] Fix 2-panel open-document select (#12577) [Dependency] Bump AnalysisToolsTS from v23.10.00 to v26.04.00 (#12822) [Bugfix:Developer] Fix bump_repo permissions (#12821) [Bugfix:InstructorUI] Change Colors to match in Docker UI table (#12739) [Bugfix:Forum] Reduce Page Caching (#12339) [Bugfix:System] File lost when running install clean fix (#12158) [Bugfix:Submission] No File Rubric submit all user groups (#12812) [Dependency] Bump twig/markdown-extra from 3.23.0 to 3.24.0 in /site (#12721) ...
Why is this Change Important & Necessary?
Closes #12579
This change is important because, in team gradeables even when the assignment doesn't say to submit it as Git/VCS repo it states the error message ->Your repo doesn't exist contact your instructor... .This message should only appear for VCS assignments. Not for Non-VCS(file) assignment
What is the New Behavior?
Before => There was error in team gradeables that repo doesn't exist even if the assignment was Non-VCS

After=> Now it first checks if the assignment is of GIT/VCS if yes then only shows that error if not then it does not shows that error.

What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
A Cypress test at:
site/cypress/e2e/Cypress-Gradeable/team_repository_message.spec.js
Other information