[Bugfix:InstructorUI] Always show correct calendar view#12606
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12606 +/- ##
=========================================
Coverage 21.66% 21.66%
+ Complexity 9638 9637 -1
=========================================
Files 268 268
Lines 36223 36222 -1
Branches 486 487 +1
=========================================
Hits 7847 7847
+ Misses 27894 27892 -2
- Partials 482 483 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Eli-J-Schwartz
changed the title
Eli-J-Schwartz
changed the title
Eli-J-Schwartz
approved these changes
Mar 24, 2026
Eli-J-Schwartz
left a comment
Eli-J-Schwartz
left a comment
Contributor
There was a problem hiding this comment.
I tested the functionality, and this change works completely. See the original PR for example screenshots. The code change is very simple, and looks like it works properly. The only failing test is a known issue in the main branch, and is unrelated to this PR.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
GarvitKhandelwal31
pushed a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Mar 29, 2026
### Why is this Change Important & Necessary? Fixes Submitty#12605 - A user can correctly see any calendar view ### What is the New Behavior? Old Behavior: <img width="1710" height="1107" alt="Screenshot 2026-03-16 at 10 04 48 PM" src="https://github.com/user-attachments/assets/c6142efd-ebd2-4d09-8243-f6f17cac3dac" /> New Behavior: <img width="1710" height="1107" alt="Screenshot 2026-03-18 at 8 45 30 PM" src="https://github.com/user-attachments/assets/112ac015-6295-48fd-ac65-22486a1576b7" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Open the web app in any browser 2. Log in as any user and go to the calendar tab 3. Click on the month button in the top right and switch to any view 4. Should correctly display now ### Automated Testing & Documentation -Small change ### Other information NA Co-authored-by: Skyler <[email protected]>
GarvitKhandelwal31
pushed a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Apr 14, 2026
### Why is this Change Important & Necessary? Fixes Submitty#12605 - A user can correctly see any calendar view ### What is the New Behavior? Old Behavior: <img width="1710" height="1107" alt="Screenshot 2026-03-16 at 10 04 48 PM" src="https://github.com/user-attachments/assets/c6142efd-ebd2-4d09-8243-f6f17cac3dac" /> New Behavior: <img width="1710" height="1107" alt="Screenshot 2026-03-18 at 8 45 30 PM" src="https://github.com/user-attachments/assets/112ac015-6295-48fd-ac65-22486a1576b7" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Open the web app in any browser 2. Log in as any user and go to the calendar tab 3. Click on the month button in the top right and switch to any view 4. Should correctly display now ### Automated Testing & Documentation -Small change ### Other information NA Co-authored-by: Skyler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Fixes #12605
What is the New Behavior?
Old Behavior:
New Behavior:
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
-Small change
Other information
NA