[UI/UX:System] Fix March duck and use shamrock#12593
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12593 +/- ##
=========================================
Coverage 21.66% 21.66%
Complexity 9637 9637
=========================================
Files 268 268
Lines 36222 36222
Branches 487 487
=========================================
Hits 7847 7847
Misses 27892 27892
Partials 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Eli-J-Schwartz
approved these changes
Mar 16, 2026
Eli-J-Schwartz
left a comment
Eli-J-Schwartz
left a comment
Contributor
There was a problem hiding this comment.
Changes appear correctly when tested, as shown in the screenshot below.
The three-leaved clover is the correct one for St. Patrick's Day, according to wikipedia.
Failing tests are due to issues in main, not in this PR.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
SkyBlue43
pushed a commit
to SkyBlue43/Submitty
that referenced
this pull request
Mar 19, 2026
### Why is this Change Important & Necessary? Fixes Submitty#12592. The four-leaf clover, while similar to the shamrock, isn't the correct symbol for the holiday and should be changed. ### What is the New Behavior? This new image uses the shamrock. ### What steps should a reviewer take to reproduce or test the bug or new feature? None needed ### Automated Testing & Documentation No testing should be needed, but I am unfamiliar with the repository so I may be wrong ### Other information _Lá Fhéile Pádraig sona dhuit!_
GarvitKhandelwal31
pushed a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Mar 29, 2026
### Why is this Change Important & Necessary? Fixes Submitty#12592. The four-leaf clover, while similar to the shamrock, isn't the correct symbol for the holiday and should be changed. ### What is the New Behavior? This new image uses the shamrock. ### What steps should a reviewer take to reproduce or test the bug or new feature? None needed ### Automated Testing & Documentation No testing should be needed, but I am unfamiliar with the repository so I may be wrong ### Other information _Lá Fhéile Pádraig sona dhuit!_
GarvitKhandelwal31
pushed a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Apr 14, 2026
### Why is this Change Important & Necessary? Fixes Submitty#12592. The four-leaf clover, while similar to the shamrock, isn't the correct symbol for the holiday and should be changed. ### What is the New Behavior? This new image uses the shamrock. ### What steps should a reviewer take to reproduce or test the bug or new feature? None needed ### Automated Testing & Documentation No testing should be needed, but I am unfamiliar with the repository so I may be wrong ### Other information _Lá Fhéile Pádraig sona dhuit!_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Fixes #12592. The four-leaf clover, while similar to the shamrock, isn't the correct symbol for the holiday and should be changed.
What is the New Behavior?
This new image uses the shamrock.
What steps should a reviewer take to reproduce or test the bug or new feature?
None needed
Automated Testing & Documentation
No testing should be needed, but I am unfamiliar with the repository so I may be wrong
Other information
Lá Fhéile Pádraig sona dhuit!