[Bugfix:Submission] Staff highlight by GarvitKhandelwal31 · Pull Request #12589 · Submitty/Submitty

GarvitKhandelwal31 · 2026-03-15T14:20:34Z

Why is this Change Important & Necessary?

What is the New Behavior?

All course staff entries (including limited-access graders) are highlighted in blue on the leaderboard, and remain unranked.

What steps should a reviewer take to reproduce or test the bug or new feature?

Log in as instructor.
Go to http://localhost:1511/courses/s26/sample/gradeable/leaderboard
Submit once as grader and once as ta using “Make Submission for a Student”.
Wait for autograding to complete.
Open http://localhost:1511/courses/s26/sample/gradeable/leaderboard/leaderboard
Confirm both grader and ta rows are blue and unranked.

Automated Testing & Documentation

Not covered by automated tests. No documentation changes needed.

Other information

No migrations. Not a breaking change. No known security impact.

Copilot

Pull request overview

This PR modernizes Doctrine caching/config usage to avoid deprecated doctrine/cache, updates dependencies accordingly, and includes a handful of related fixes/improvements across the web UI, PHPStan configuration, and setup tooling.

Changes:

Replace ORMSetup::createAttributeMetadataConfiguration(...) usage with explicit Doctrine\ORM\Configuration + Symfony Cache adapters.
Update PHP dependencies (notably doctrine/dbal and add psr/cache) and adjust composer.lock.
Add robustness tweaks in the submission timer JS and adjust leaderboard grader highlighting logic; add a new system install script.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
site/tests/phpstan/DoctrineExtensionTester.php	Switch Doctrine config setup to explicit ORMConfiguration + AttributeDriver + ArrayAdapter for cache
site/public/js/submission-page.js	Add `buildCourseUrlSafe()` fallback to avoid reliance on server.js load order
site/phpstan-baseline.neon	Add baseline suppression for a new/changed PHPStan finding
site/composer.lock	Remove `doctrine/cache` and bump `doctrine/dbal` lock data
site/composer.json	Bump `doctrine/dbal` and add `psr/cache` requirement
site/app/templates/submission/homework/leaderboard/LeaderboardTable.twig	Treat limited-access graders as graders in leaderboard styling/ranking logic
site/app/models/RainbowCustomizationJSON.php	Remove inline PHPStan ignore and keep object iteration logic for JSON save
site/app/libraries/Core.php	Update Doctrine EntityManager configuration to use Symfony cache + explicit config
.setup/install_system.sh	Add a new all-in-one installation/provisioning script

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

GarvitKhandelwal31 · 2026-03-15T14:28:46Z

Pull request overview

This PR modernizes Doctrine caching/config usage to avoid deprecated doctrine/cache, updates dependencies accordingly, and includes a handful of related fixes/improvements across the web UI, PHPStan configuration, and setup tooling.

Changes:

Replace ORMSetup::createAttributeMetadataConfiguration(...) usage with explicit Doctrine\ORM\Configuration + Symfony Cache adapters.

Update PHP dependencies (notably doctrine/dbal and add psr/cache) and adjust composer.lock.

Add robustness tweaks in the submission timer JS and adjust leaderboard grader highlighting logic; add a new system install script.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Show a summary per file
File Description
site/tests/phpstan/DoctrineExtensionTester.php Switch Doctrine config setup to explicit ORMConfiguration + AttributeDriver + ArrayAdapter for cache
site/public/js/submission-page.js Add buildCourseUrlSafe() fallback to avoid reliance on server.js load order
site/phpstan-baseline.neon Add baseline suppression for a new/changed PHPStan finding
site/composer.lock Remove doctrine/cache and bump doctrine/dbal lock data
site/composer.json Bump doctrine/dbal and add psr/cache requirement
site/app/templates/submission/homework/leaderboard/LeaderboardTable.twig Treat limited-access graders as graders in leaderboard styling/ranking logic
site/app/models/RainbowCustomizationJSON.php Remove inline PHPStan ignore and keep object iteration logic for JSON save
site/app/libraries/Core.php Update Doctrine EntityManager configuration to use Symfony cache + explicit config
.setup/install_system.sh Add a new all-in-one installation/provisioning script
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can ignore this, I mistakenly pushed from a different branch.

codecov · 2026-03-17T00:08:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.66%. Comparing base (b70fe3d) to head (acae68d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #12589   +/-   ##
=========================================
  Coverage     21.66%   21.66%           
  Complexity     9639     9639           
=========================================
  Files           268      268           
  Lines         36226    36226           
  Branches        487      487           
=========================================
  Hits           7847     7847           
  Misses        27896    27896           
  Partials        483      483

Flag	Coverage Δ
autograder	`21.32% <ø> (ø)`
js	`2.04% <ø> (ø)`
migrator	`100.00% <ø> (ø)`
php	`20.68% <ø> (ø)`
python_submitty_utils	`80.08% <ø> (ø)`
submitty_daemon_jobs	`91.13% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

GarvitKhandelwal31 · 2026-03-17T06:58:38Z

PHPStan failure in check 7c385aa is unrelated to this PR. It reports:
app/views/submission/TeamView.php:29 — “Only booleans are allowed in a ternary operator condition, app\models\Team|null given.”
That line uses $team == null ? null : $team->getTeamName() and is outside this change. I can open a separate PR to adjust it to $team !== null ? $team->getTeamName() : null if desired.

GarvitKhandelwal31 · 2026-03-24T02:30:33Z

Hi @Christian2147, thanks for running the workflows. Any other changes required from my side?

Christian2147

I tested it in both light mode and dark mode and different users, and this seems to be working great from what I can tell.

### Why is this Change Important & Necessary? Fixes Submitty#12583 ### What is the New Behavior? All course staff entries (including limited-access graders) are highlighted in blue on the leaderboard, and remain unranked. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Log in as instructor. 2. Go to http://localhost:1511/courses/s26/sample/gradeable/leaderboard 3. Submit once as `grader` and once as `ta` using “Make Submission for a Student”. 4. Wait for autograding to complete. 5. Open http://localhost:1511/courses/s26/sample/gradeable/leaderboard/leaderboard 6. Confirm both `grader` and `ta` rows are blue and unranked. <img width="1897" height="955" alt="image" src="https://github.com/user-attachments/assets/b7dc0277-b88c-4ea4-a88c-86b50f6897b3" /> ### Automated Testing & Documentation Not covered by automated tests. No documentation changes needed. ### Other information No migrations. Not a breaking change. No known security impact.

Copilot AI review requested due to automatic review settings March 15, 2026 14:20

github-project-automation Bot added this to Submitty Development Mar 15, 2026

github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Mar 15, 2026

automateprojectmangement Bot moved this from Seeking Reviewer to In Review in Submitty Development Mar 15, 2026

Copilot started reviewing on behalf of GarvitKhandelwal31 March 15, 2026 14:21 View session

Fix leaderboard staff highlight

101196d

GarvitKhandelwal31 force-pushed the fix/leaderboard-staff-highlight branch from bcf2499 to 101196d Compare March 15, 2026 14:22

Copilot AI reviewed Mar 15, 2026

View reviewed changes

Merge branch 'main' into fix/leaderboard-staff-highlight

7c385aa

Merge branch 'main' into fix/leaderboard-staff-highlight

891b4d7

Christian2147 self-assigned this Mar 20, 2026

Christian2147 mentioned this pull request Mar 20, 2026

BugFix(leaderboard-highlight): fix leaderboard highlighting for all course staff to blue #12612

Closed

GarvitKhandelwal31 mentioned this pull request Mar 21, 2026

[BugFix] : Fix the certain not highlighted course staff on leaderboard #12617

Closed

Merge branch 'main' into fix/leaderboard-staff-highlight

0d25b7a

Merge branch 'main' into fix/leaderboard-staff-highlight

acae68d

Christian2147 approved these changes Mar 24, 2026

View reviewed changes

github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Mar 24, 2026

bmcutler merged commit 3efe6e6 into Submitty:main Mar 24, 2026
25 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Bugfix:Submission] Staff highlight#12589

[Bugfix:Submission] Staff highlight#12589
bmcutler merged 5 commits into
Submitty:mainfrom
GarvitKhandelwal31:fix/leaderboard-staff-highlight

GarvitKhandelwal31 commented Mar 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

GarvitKhandelwal31 commented Mar 15, 2026

Pull request overview

Reviewed changes

Uh oh!

codecov Bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

GarvitKhandelwal31 commented Mar 17, 2026

Uh oh!

GarvitKhandelwal31 commented Mar 24, 2026 •

edited

Loading

Uh oh!

Christian2147 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

GarvitKhandelwal31 commented Mar 15, 2026

Why is this Change Important & Necessary?

What is the New Behavior?

What steps should a reviewer take to reproduce or test the bug or new feature?

Automated Testing & Documentation

Other information

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

GarvitKhandelwal31 commented Mar 15, 2026

Pull request overview

Reviewed changes

Uh oh!

codecov Bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

GarvitKhandelwal31 commented Mar 17, 2026

Uh oh!

GarvitKhandelwal31 commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Christian2147 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented Mar 17, 2026 •

edited

Loading

GarvitKhandelwal31 commented Mar 24, 2026 •

edited

Loading