Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.64%. Comparing base (9cb25d6) to head (5040657).
⚠️ Report is 47 commits behind head on main.

@@             Coverage Diff              @@
##               main   #12585      +/-   ##
============================================
- Coverage     21.66%   21.64%   -0.02%     
- Complexity     9637     9654      +17     
============================================
  Files           268      268              
  Lines         36222    36245      +23     
  Branches        487      487              
============================================
- Hits           7847     7846       -1     
- Misses        27892    27916      +24     
  Partials        483      483              

Thanks for the PR. Looks like a good design. (I haven't tested)

Just looking at the images, the phrase "Total files cannot exceed 100mb" is confusing/misleading. I assume this the size of files uploaded with one click. So perhaps we should instead say "Maximum file size total per upload is 100mb" or similar.

Also, that upload limit size is configured for the server in various files:

https://submitty.org/sysadmin/installation/system_customization#increasing-the-max-number-of-files-that-can-be-uploaded-at-once

Is that 100mb hardcoded or is it actually reading the setting in the configuration file (which may have been altered from the default).

Thanks for the PR. Looks like a good design. (I haven't tested)

Just looking at the images, the phrase "Total files cannot exceed 100mb" is confusing/misleading. I assume this the size of files uploaded with one click. So perhaps we should instead say "Maximum file size total per upload is 100mb" or similar.

Also, that upload limit size is configured for the server in various files:

https://submitty.org/sysadmin/installation/system_customization#increasing-the-max-number-of-files-that-can-be-uploaded-at-once

Is that 100mb hardcoded or is it actually reading the setting in the configuration file (which may have been altered from the default).

The 100 MB is based on a variable from the config. That was not something I added in this PR, but the upload limit and max storage are both configurable from the config file.

In my testing it seems this is working as intended, the file capacity is filling up as I upload materials. If 1000 MB is a default value you have not chosen to hardcode, then I think implementation makes sense.

A few notes I have:

1. I think the warning before you hit the limit at 900 MB should be yellow/orange, and then the "exceeded limit" message can be red.

2. I agree that the wording about the combined limits is somewhat confusing, and would benefit from the phrase "per upload".

I changed it so that from 600 to 900 the text is orange, but at 900 it is still red. My thoughts are that when the instructor is at 900 it should have the same urgency as when they are past the limit, so it encourages them to trim/migrate the course materials before they run out of space.