[Bugfix:TAGrading] Fix 2-panel open-document select#12577
Merged
williamjallen merged 3 commits intoMay 1, 2026
Merged
Conversation
…en-document select In 2-panel mode, the open-document dropdown showed "left" and "bottom left" instead of "left" and "right" (with "right" and "bottom right" only reachable by scrolling). Two issues caused this: 1. CSS `display:none` on `<option>` elements is unreliable across browsers (confirmed in Safari), so hidden options remained in the DOM. 2. `size=2` clipped the visible area to the first two DOM positions (leftTop, leftBottom), pushing rightTop out of view. Replace the CSS hide/show approach with dynamic DOM reconstruction: rebuild the select's options each call based on the current layout, setting `size` to the exact option count so all options are always visible without scrolling. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
QuackHonk
self-requested a review
March 24, 2026 19:00
automateprojectmangement
Bot
moved this from Seeking Reviewer
to In Review
in Submitty Development
QuackHonk
removed their request for review
March 24, 2026 19:06
github-actions
Bot
added
the
Abandoned PR - Needs New Owner
williamjallen
previously requested changes
Apr 30, 2026
github-project-automation
Bot
moved this from In Review
to Work in Progress
in Submitty Development
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12577 +/- ##
=========================================
Coverage 21.67% 21.67%
Complexity 9809 9809
=========================================
Files 268 268
Lines 36730 36728 -2
Branches 490 489 -1
=========================================
Hits 7960 7960
+ Misses 28284 28283 -1
+ Partials 486 485 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
williamjallen
approved these changes
May 1, 2026
github-project-automation
Bot
moved this from Work in Progress
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
prestoncarman
added a commit
that referenced
this pull request
May 21, 2026
* main: (50 commits) [Bugfix:Developer] Fix Broken CI (#12851) [Bugfix:System] Restore TCLAPP (#12850) [Bugfix:Submission] Fix non-VCS repo error (#12608) [Feature:Submission] Jupyter warnings outside notebook (#12523) [Bugfix:InstructorUI] Removed feature flag for Bulk Late Days (#12826) [Bugfix:Forum] Fix stats header rendering (#12698) [Bugfix:Autograding] Fix negative number tolerance (#12569) [Bugfix:HelpQueue] Always use Abbreviated Names in OH (#12820) [Bugfix:Autograding] Fix regrade team detection (#12737) [Dependency] Bump Lichen from v23.09.00 to v26.04.01 (#12823) [Dependency] Bump RainbowGrades from v25.10.00 to v26.04.01 (#12824) [Feature:Developer] Remove misc Java utils and TCLAPP (#12819) [Bugfix:TAGrading] Fix 2-panel open-document select (#12577) [Dependency] Bump AnalysisToolsTS from v23.10.00 to v26.04.00 (#12822) [Bugfix:Developer] Fix bump_repo permissions (#12821) [Bugfix:InstructorUI] Change Colors to match in Docker UI table (#12739) [Bugfix:Forum] Reduce Page Caching (#12339) [Bugfix:System] File lost when running install clean fix (#12158) [Bugfix:Submission] No File Rubric submit all user groups (#12812) [Dependency] Bump twig/markdown-extra from 3.23.0 to 3.24.0 in /site (#12721) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
In 2-panel side-by-side mode, clicking a panel button to open a new document showed incorrect options in the dropdown. Users saw "Open as left panel" and "Open as bottom left panel" — with "Open as right
panel" only reachable by scrolling — making it non-obvious how to open a document in the right panel. Confirmed in Safari.
Two interacting issues caused this:
display:noneon<option>elements is not respected cross-browser (Safari, Firefox), so options that should be hidden remained visible in the DOM.size=2attribute clipped the visible list to the first two DOM positions (leftTop,leftBottom), pushingrightTopout of view.Fixes #11968
What is the New Behavior?
Instead of toggling a CSS
hideclass on static options,updatePanelOptions()now dynamically rebuilds the<option>elements based on the current layout. Only options applicable to the active panelmode are inserted into the DOM, and
sizeis set to the exact option count so no scrolling is needed.What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
No automated tests currently cover this UI behavior. A GitHub issue should be opened to track adding Cypress coverage for panel option visibility across layout modes.
Other information
Not a breaking change. No migrations or security concerns. The
valueattributes on each<option>are unchanged, so the existing change event handler that reads$(this).val()continues to work withoutmodification.