[Feature:Submission] Create empty submission for all students#12576
[Feature:Submission] Create empty submission for all students#12576roye2 wants to merge 41 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12576 +/- ##
============================================
- Coverage 21.64% 21.61% -0.03%
- Complexity 9654 9788 +134
============================================
Files 268 268
Lines 36244 36618 +374
Branches 487 490 +3
============================================
+ Hits 7845 7915 +70
- Misses 27916 28217 +301
- Partials 483 486 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…ithub.com/Submitty/Submitty into create-empty-submissions-for-all-students
|
I marked the PR as ready for review. I know the CI gradeable test is flaky. If anyone can help me understand why my code is failing the CI System test, that would be great. |
John-Roy123
left a comment
There was a problem hiding this comment.
Testing this PR on a smaller screen size (14 in screen) the bulk upload header looks like

The button is being put onto its own line despite there being room for it in line with the other buttons, making the page look more disorganized.
I also noticed while using on Firefox, the type of popup used for confirmation has the "do not let localhost:1511 send popups anymore". If a user for whatever reason has selected that, the button no longer works, and they will no longer be able to make bulk blank submissions.
…ithub.com/Submitty/Submitty into create-empty-submissions-for-all-students
|
I've added a PR for the documentation and fixed all known bugs: |
…ithub.com/Submitty/Submitty into create-empty-submissions-for-all-students
|
The question mark button currently links to another page while the documentation is still unmerged. |
…ithub.com/Submitty/Submitty into create-empty-submissions-for-all-students
|
@bmcutler I was able to hide the option on team gradeables and I also verified that the function was only looping over the users in the course. As it turns out, (luckily) the function I used to get the users only returned the table of users from the course (null sections included.) |
JManion32
left a comment
There was a problem hiding this comment.
Looks great! I have a few small comments, but overall, the code is intuitive and the functionality is very well done. I'm re-running the failing CI tests right now, and will approve later today.
JManion32
left a comment
There was a problem hiding this comment.
Great work! Code and functionality work well. This is a significant quality of life feature for course management. We encountered some small behaviors that differ between Chrome and Firefox, but none were created by this PR. I will create an issue for it, but its low priority.
|
I updated the question mark button to link to the documentation page for the new feature. As far as I am concerned this PR is now ready to go. |
Added documentation page for the Submit All with Placeholder feature instructors have access to on Bulk Upload type gradeables. This feature is being added in PR #12576 in the Submitty site. Submitty/Submitty#12576 Screenshot: <img width="1918" height="916" alt="image" src="https://github.com/user-attachments/assets/e53739fd-41b5-4913-9617-ec7f8045a387" /> --------- Co-authored-by: Barb Cutler <[email protected]>
|
More info on how I fixed the CI System failure: |
### Why is this Change Important & Necessary? #Closes #11144 ### What is the New Behavior? Added team functionality to my earlier changes in PR #12576 Now, after making teams on a Team Bulk Upload Gradeable, an instructor can use this feature to have no-file submissions generated for each team. A placeholder pdf will be submitted to enable the use of rubric for grading. <img width="1640" height="307" alt="image" src="https://github.com/user-attachments/assets/44be8097-6db9-4b23-b0a6-5b7febacd730" /> The submissions can be graded using a rubric like any other team submission. <img width="1643" height="788" alt="image" src="https://github.com/user-attachments/assets/c5fcde6d-dabd-4e4c-83d3-a4f901e52af4" /> ### What steps should a reviewer take to reproduce or test the bug or new feature? Note, please use submitty_install rather than submitty_install_site as a pdf has been added to the non-site codebase. On a Team Bulk Upload Gradeable: 1. As instructor, create teams for students. (navigate to the submissions / grading view and click on the edit teams pencil icon) 2. Navigate to the Bulk Upload tab and select the button for No File Rubric Grading 3. After submitting, observe that you can grade the new team submissions. ### Automated Testing & Documentation I have not added any automated testing for this PR. ### Other information More information can be found in PR #12576
Why is this Change Important & Necessary?
Closes #11144 .
Currently, there is no way to autogenerate submissions for all users in a course to enable the Submitty grading capabilities. An example of when this would be useful is for an assignment (like a presentation) where students do not have anything to submit to Submitty, but the instructor still wishes to grade them through Submitty. Previously, in such a scenario instructors would have to manually submit for each student.
What is the New Behavior?
An instructor can now make a "blank" submission for all students on a gradeable. The button is depicted here.

And the confirmation message:

A small banner message will be displayed and updated as the submissions process:

The submission will be in the form of a placeholder PDF. Once the button has been pressed and the submissions have been uploaded, the rubric grading can be used.
What steps should a reviewer take to reproduce or test the bug or new feature?
Create a 'Bulk Upload' style gradeable and test the submission and gradeability. Note that the new submissions will replace any currently active versions. Note: Since a part of this change includes adding a PDF to the code, testers will need to run 'submitty_install' in their VM for the changes to work correctly.
Automated Testing & Documentation
There is currently no automated testing associated with this change.
Pressing this button on a team gradeable makes a submission for each student, regardless of team association.
I was not able to break the team functionality, but it isn't implemented correctly either.
Eventually, a link to the Submitty.org documentation should be added to describe the purpose of this button to the user.
Other information
This is not a breaking change.