Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.62%. Comparing base (c78aa07) to head (43ba3e9).

@@            Coverage Diff            @@
##               main   #12571   +/-   ##
=========================================
  Coverage     21.62%   21.62%           
  Complexity     9817     9817           
=========================================
  Files           268      268           
  Lines         36808    36808           
  Branches        490      490           
=========================================
  Hits           7960     7960           
  Misses        28362    28362           
  Partials        486      486           

Hi @IDzyre, I've addressed the following issues:

• Fixed the PR title to [Feature:Developer] Add bulk upload submissions
• Fixed Cypress (System): updated the submission count in autograding_status_1.spec.js from 101 to 105 to reflect the 3 new PDF submissions added
• Fixed Cypress (UI): updated gradeable section counts in navigation_page.spec.js to reflect bulk_upload_test moving from the future section to items_being_graded

However, the following CI failures are still present and I'm not sure if they are related to my changes or pre-existing:

• Cypress (Feature)
• Cypress (Gradeable)
• Cypress (TAGrading) — all failures are timeout/element-not-found errors in the TA grading interface (e.g. grading-rubric-btn, grading-rubric, notebook-view) which don't seem related to my changes
• Cypress (UI) — student_info_panel.spec.js and navigation_page.spec.js still failing

I've checked CI #8131 on main and all tests passed there. Could you help clarify whether these remaining failures are pre-existing or caused by my changes? A new CI run (#8160) is also awaiting your approval to verify my latest fixes.

Hi @IDzyre, I've addressed the following issues:

• Fixed the PR title to [Feature:Developer] Add bulk upload submissions
• Fixed Cypress (System): updated the submission count in autograding_status_1.spec.js from 101 to 105 to reflect the 3 new PDF submissions added
• Fixed Cypress (UI): updated gradeable section counts in navigation_page.spec.js to reflect bulk_upload_test moving from the future section to items_being_graded

However, the following CI failures are still present and I'm not sure if they are related to my changes or pre-existing:

• Cypress (Feature)
• Cypress (Gradeable)
• Cypress (TAGrading) — all failures are timeout/element-not-found errors in the TA grading interface (e.g. grading-rubric-btn, grading-rubric, notebook-view) which don't seem related to my changes
• Cypress (UI) — student_info_panel.spec.js and navigation_page.spec.js still failing

I've checked CI #8131 on main and all tests passed there. Could you help clarify whether these remaining failures are pre-existing or caused by my changes? A new CI run (#8160) is also awaiting your approval to verify my latest fixes.

This is a known issue with Submitty's testing. Since the sample course script uses a seeded random generation of submissions, changing the sample courses in any way can disrupt the existing testing infrastructure, because the submissions can change. You should run the tests locally to see if the changes you made affect the tests, and update them accordingly.

@IDzyre Thank you for the explanation! I investigated further and here is what I found:

The random seed in gradeable.py is based on each gradeable's ID hash (hashlib.md5 of self.id), so adding PDF submissions to pdf_exam/submissions/ only affects bulk_upload_test and does not alter the random sequence for other gradeables.

After reviewing all the CI logs carefully, the remaining failures are in files I did not touch:

• navigation_page.spec.js - should display instructor buttons correctly: expects a REGRADE button on grades_released_homework_autota and grades_released_homework
• student_info_panel.spec.js: Submission Number: 2 / 3 not found for student mccule in grading_homework
• edit_gradeable.spec.js: #submission-version-select not found
• discussion_post.spec.js, files_panel.spec.js, grade_inquiries.spec.js, late_days_cache.spec.js, student_version_conflict.spec.js: all element-not-found timeouts
• student_activity_download.spec.js: date mismatch on pre-existing 9996-12-31 dates I did not modify

The fixes I made (autograding_status_1.spec.js and section counts in navigation_page.spec.js) are now passing in CI. Could you confirm if the remaining failures are pre-existing on your end?

@IDzyre Thank you for the explanation! I investigated further and here is what I found:

The random seed in gradeable.py is based on each gradeable's ID hash (hashlib.md5 of self.id), so adding PDF submissions to pdf_exam/submissions/ only affects bulk_upload_test and does not alter the random sequence for other gradeables.

After reviewing all the CI logs carefully, the remaining failures are in files I did not touch:

• navigation_page.spec.js - should display instructor buttons correctly: expects a REGRADE button on grades_released_homework_autota and grades_released_homework
• student_info_panel.spec.js: Submission Number: 2 / 3 not found for student mccule in grading_homework
• edit_gradeable.spec.js: #submission-version-select not found
• discussion_post.spec.js, files_panel.spec.js, grade_inquiries.spec.js, late_days_cache.spec.js, student_version_conflict.spec.js: all element-not-found timeouts
• student_activity_download.spec.js: date mismatch on pre-existing 9996-12-31 dates I did not modify

The fixes I made (autograding_status_1.spec.js and section counts in navigation_page.spec.js) are now passing in CI. Could you confirm if the remaining failures are pre-existing on your end?

You should be able to see if the tests are failing locally or on main, and given that main passed all the tests failing on your branch, I feel that it is affecting it somehow.

Hi, just checking in — I've addressed the review feedback, and this PR is still active on my end. Happy to make any additional changes if needed. Let me know!

I've decided it's best to close this PR. After further testing I determined it did not provide any useful testing data, considering there were no submissions already provided on the gradeable. I'm also concerned this would break existing tests. We can reopen this PR or a new one to address the issue at another time.