[UI/UX] Fix sticky column freeze and overlap on Bulk Late Days table (#12534)#12543
Closed
tanupriyasingh1 wants to merge 1 commit into
Closed
[UI/UX] Fix sticky column freeze and overlap on Bulk Late Days table (#12534)#12543tanupriyasingh1 wants to merge 1 commit into
tanupriyasingh1 wants to merge 1 commit into
Conversation
Contributor
|
I did a functionality review of this PR. As the PR says, only the first 4 columns stick to the left of the visible display when scrolling. However, there is some overlap between the first 4 columns when scrolling, that makes the table hard to read. See the screenshot below, and note the the leftmost column, which should contain the user ids, is almost completely covered: |
github-actions
Bot
added
the
Abandoned PR - Needs New Owner
Member
|
closed due to inactivity |
github-project-automation
Bot
moved this from Seeking Reviewer
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12534.
The Bulk Late Days table had position sticky incorrectly applied to 5 columns instead of 4. The 5th column (first gradeable) was being frozen unintentionally and the border-right separator was on the wrong column.
What Changed
How to Test
Notes