Skip to content

[UI/UX:Submission] Fix bulk-late sticky cols#12539

Merged
bmcutler merged 15 commits into
Submitty:mainfrom
GarvitKhandelwal31:bulk-late-delay
May 25, 2026
Merged

[UI/UX:Submission] Fix bulk-late sticky cols#12539
bmcutler merged 15 commits into
Submitty:mainfrom
GarvitKhandelwal31:bulk-late-delay

Conversation

@GarvitKhandelwal31

@GarvitKhandelwal31 GarvitKhandelwal31 commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

Fixes #12534.

On the Bulk Late Days page, horizontal scrolling did not preserve the correct frozen columns.
The first user-info columns overlapped, and an assignment column could incorrectly appear frozen. This made the table hard to read and use for instructors.

What is the New Behavior?

The Bulk Late Days table now keeps only the intended first four columns frozen on horizontal scroll:

  1. User ID
  2. Given Name
  3. Family Name
  4. Initial

The remaining columns scroll normally, column ordering is preserved, and sticky-column overlap is resolved.

Recording.2026-03-06.004219.mp4

What steps should a reviewer take to reproduce or test the bug or new feature?

  1. Login as instructor.
  2. Go to course sample.
  3. Open Bulk Late Days.
  4. Horizontally scroll the table.
  5. Confirm:
    • First four user-info columns remain frozen.
    • Gradeable/event columns scroll.
    • No overlap between frozen columns.
    • Column order remains correct while scrolling.

Automated Testing & Documentation

  • Manual UI testing performed on the Bulk Late Days page.
  • Existing automated tests do not currently assert sticky-column CSS behavior during horizontal scroll.
  • No submitty.org documentation changes are required for this UI bugfix.

Other information

  • Not a breaking change.
  • No migrations.
  • No sysadmin action required.
  • No security impact identified.

Copilot AI review requested due to automatic review settings March 5, 2026 19:18
@github-project-automation github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Mar 5, 2026
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to In Review in Submitty Development Mar 5, 2026
Copilot AI reviewed Mar 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@tanupriyasingh1 tanupriyasingh1 mentioned this pull request Mar 6, 2026
Closed
williamjallen
williamjallen requested changes Mar 7, 2026
View reviewed changes
Comment thread site/public/css/latedaystableplugin.css
Comment thread site/public/css/latedaystableplugin.css Outdated
#late-day-table th,
#late-day-table td {
display: table-cell;
box-sizing: border-box !important;

@williamjallen williamjallen Mar 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you find a way to remove the !important, perhaps by targeting the cell with a more specific selector?

Comment thread site/public/css/latedaystableplugin.css Outdated
Comment thread site/app/views/admin/LateDayView.php Outdated
]);
}
}

@williamjallen williamjallen Mar 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this whitespace change.

Comment thread site/public/css/latedaystableplugin.css
@github-project-automation github-project-automation Bot moved this from In Review to Work in Progress in Submitty Development Mar 7, 2026
@GarvitKhandelwal31
GarvitKhandelwal31 force-pushed the bulk-late-delay branch 2 times, most recently from 8bf5de2 to 8f20095 Compare March 7, 2026 18:00
@GarvitKhandelwal31
GarvitKhandelwal31 force-pushed the bulk-late-delay branch 3 times, most recently from 022c6f5 to 9096f03 Compare March 7, 2026 18:34
@GarvitKhandelwal31

GarvitKhandelwal31 commented Mar 7, 2026

Copy link
Copy Markdown
Contributor Author

@williamjallen Addressed your remarks.

@williamjallen

williamjallen commented Mar 13, 2026

Copy link
Copy Markdown
Member

@GarvitKhandelwal31 Can you please review #12543 and comment on the pros and cons of each of these two approaches?

@github-project-automation github-project-automation Bot moved this from Work in Progress to Done in Submitty Development Mar 13, 2026
@williamjallen williamjallen reopened this Mar 13, 2026
@GarvitKhandelwal31

GarvitKhandelwal31 commented Mar 14, 2026

Copy link
Copy Markdown
Contributor Author

@williamjallen
Pros / Cons

Approach in #12543 (global simple-grading.css)

Pros: lower immediate complexity.
Cons: broad blast radius; can affect any page using simple-grading.css; less tailored to Bulk Late Days table behavior.

Approach in #12539 (my approach) (scoped to Bulk Late Days)

Pros: targeted to #late-day-table; avoids cross-page side effects; explicit behavior for this specific table.
Cons: larger CSS footprint; more custom logic to maintain.

@GarvitKhandelwal31 GarvitKhandelwal31 mentioned this pull request Mar 21, 2026
Closed
@github-actions github-actions Bot added the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Apr 2, 2026
@GarvitKhandelwal31

GarvitKhandelwal31 commented Apr 3, 2026

Copy link
Copy Markdown
Contributor Author

@JManion32 Hey, sorry for directly tagging you. Can you please review this PR whenever you have time.

@codecov

codecov Bot commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.67%. Comparing base (4ca4e71) to head (ab47ecf).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12539   +/-   ##
=========================================
  Coverage     21.67%   21.67%           
  Complexity     9802     9802           
=========================================
  Files           268      268           
  Lines         36724    36724           
  Branches        489      489           
=========================================
  Hits           7960     7960           
  Misses        28279    28279           
  Partials        485      485
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.02% <ø> (ø)
migrator 100.00% <ø> (ø)
php 20.73% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Eli-J-Schwartz

Eli-J-Schwartz commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

I think this looks a lot better than the old version, and it works in both light and dark mode. Please fix the failing linter check, and then I think this is good to merge.

Eli-J-Schwartz
Eli-J-Schwartz approved these changes May 1, 2026
View reviewed changes

@Eli-J-Schwartz Eli-J-Schwartz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the CSS linting issues and re-tested the changes. Everything seems to be working correctly.

@Eli-J-Schwartz

Eli-J-Schwartz commented May 1, 2026

Copy link
Copy Markdown
Contributor

Looks like a lot of tests are failing because of rate-limiting with the apt database. Try running the tests later.

@GarvitKhandelwal31 GarvitKhandelwal31 removed the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label May 1, 2026
@GarvitKhandelwal31 GarvitKhandelwal31 moved this from Done to Awaiting Maintainer Review in Submitty Development May 19, 2026
williamjallen
williamjallen approved these changes May 24, 2026
View reviewed changes

@williamjallen williamjallen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks reasonable to me.

@williamjallen williamjallen moved this from Awaiting Maintainer Review to Ready to Merge in Submitty Development May 24, 2026
@bmcutler
bmcutler merged commit d9c3f15 into Submitty:main May 25, 2026
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@williamjallen williamjallen williamjallen approved these changes
@Eli-J-Schwartz Eli-J-Schwartz Eli-J-Schwartz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Submitty Development
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Left column in Bulk Late Days Usage table does not persist as expected

5 participants

@GarvitKhandelwal31 @williamjallen @Eli-J-Schwartz @bmcutler