[Testing:TAGrading] Add E2E Overridden Banner Tests by Khine12 · Pull Request #12535 · Submitty/Submitty

Khine12 · 2026-03-05T05:22:39Z

Why is this Change Important & Necessary?

The overridden banner had no E2E tests. This PR adds test coverage
to verify the banner displays correctly for both graders and students.

What is the New Behavior?

Added data-testid="overridden-grades-student-banner" to SubmitBox.twig
Added tests to existing grade_override.spec.js to verify the student-facing overridden banner appears on the submission page

What steps should a reviewer take to reproduce or test the bug or new feature?

Run: npx cypress run --headless --browser electron --spec cypress/e2e/Cypress-Feature/grade_override.spec.js
All tests should pass.

Automated Testing & Documentation

Tests added to grade_override.spec.js verifying the student banner appears when a grade override exists.

Other information

No breaking changes. No migrations needed. No security concerns.

codecov · 2026-03-05T06:09:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.66%. Comparing base (3f846d7) to head (2dc2404).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #12535   +/-   ##
=========================================
  Coverage     21.66%   21.66%           
  Complexity     9637     9637           
=========================================
  Files           268      268           
  Lines         36222    36222           
  Branches        487      487           
=========================================
  Hits           7847     7847           
  Misses        27892    27892           
  Partials        483      483

Flag	Coverage Δ
autograder	`21.32% <ø> (ø)`
js	`2.04% <ø> (ø)`
migrator	`100.00% <ø> (ø)`
php	`20.68% <ø> (ø)`
python_submitty_utils	`80.08% <ø> (ø)`
submitty_daemon_jobs	`91.13% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JManion32

Hey @Khine12, thank you for your contribution!

Can we add this to grade_override.spec.js instead of creating a new file? Please also adjust the title to match our conventions. I suggest [Testing:TAGrading]. You can also remove the issue number from the title since you are linking it in the description to get it below the 40 char limit.

Khine12 · 2026-03-05T07:28:44Z

@JManion32 Thank you for the feedback! I've moved the tests to grade_override.spec.js and updated the title to match your conventions.

Khine12 · 2026-03-05T23:26:25Z

Hi @JManion32, I've addressed your feedback — moved the tests to grade_override.spec.js and updated the title convention. The Cypress (UI) failure is in docker_ui.spec.js which is unrelated to this PR's changes. Could you please take another look when you get a chance?
Thank you!

IDzyre · 2026-03-06T17:29:47Z

Hi @JManion32, I've addressed your feedback — moved the tests to grade_override.spec.js and updated the title convention. The Cypress (UI) failure is in docker_ui.spec.js which is unrelated to this PR's changes. Could you please take another look when you get a chance? Thank you!

Since you changed the files, could you update the description to be accurate?

IDzyre · 2026-03-10T17:18:32Z

+                cy.logout();
+                cy.login('student');
+                cy.visit(['sample', 'gradeable', gradeable]);
+                cy.get('[data-testid="overridden-grades-student-banner"]').should('be.visible');


We should probably also test the content of the banner too

"Done! I've added content assertions to also verify the banner text."

They haven't been added.

"Done! The banner content assertions have now been added to verify the text."

Khine12 · 2026-03-10T20:46:18Z

The banner content assertions have been added to line 64 to address the review feedback.
Additionally, the CI / Cypress (Gradeable) failure is a pre-existing issue unrelated to this PR. The same test fails on main with the identical error: expected '<td.align-left>' to contain 'Joe'. This appears to be a flaky test in the existing test suite.

…e12/Submitty into e2e-overridden-banner-tests

Khine12 · 2026-03-14T03:08:24Z

The 3 failing checks (Cypress Autograding-Tutorial, Gradeable, UI) are unrelated to my changes — my PR only touches site/cypress/e2e/Cypress-TAGrading/overridden_status_banner.spec.js. The Autograding-Tutorial failure is a Docker connectivity issue (0 / 5 submissions graded), the Gradeable failure is a flaky visibility issue in hotkey.spec.js, and the UI failure appears to be a pre-existing issue. Could a maintainer rerun the failing checks?

bmcutler · 2026-03-22T02:24:18Z

@JManion32 or @IDzyre can one of you please re-review and approve if its ready to go?

IDzyre

Test looks good, assuming that it is adding all that needs to be tested for the issue.

Requested changes addressed.l

### Why is this Change Important & Necessary? Closes Submitty#11811 The overridden banner had no E2E tests. This PR adds test coverage to verify the banner displays correctly for both graders and students. ### What is the New Behavior? - Added `data-testid="overridden-grades-student-banner"` to `SubmitBox.twig` - Added tests to existing `grade_override.spec.js` to verify the student-facing overridden banner appears on the submission page ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Run: `npx cypress run --headless --browser electron --spec cypress/e2e/Cypress-Feature/grade_override.spec.js` 2. All tests should pass. ### Automated Testing & Documentation Tests added to `grade_override.spec.js` verifying the student banner appears when a grade override exists. ### Other information No breaking changes. No migrations needed. No security concerns. --------- Co-authored-by: Barb Cutler <[email protected]>

[Feature:Testing] Add E2E tests for Overridden Banner Submitty#11811

7163cc5

github-project-automation Bot added this to Submitty Development Mar 5, 2026

github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Mar 5, 2026

JManion32 previously requested changes Mar 5, 2026

View reviewed changes

github-project-automation Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Mar 5, 2026

[Testing:TAGrading] Add E2E Overridden Banner Tests

2017ef0

Khine12 changed the title ~~[Feature:Testing] Add E2E tests for Overridden Banner #11811~~ [Testing:TAGrading] Add E2E Overridden Banner Tests Mar 5, 2026

Khine12 mentioned this pull request Mar 5, 2026

Write tests to make sure legal first name & legal last name are never displayed #8435

Closed

Khine12 changed the title ~~[Testing:TAGrading] Add E2E Overridden Banner Tests~~ [TAGrading:Testing] Add E2E Overridden Banner Tests Mar 5, 2026

IDzyre reviewed Mar 6, 2026

View reviewed changes

Comment thread site/cypress/e2e/Cypress-Feature/grade_override.spec.js Outdated

Khine12 changed the title ~~[TAGrading:Testing] Add E2E Overridden Banner Tests~~ [Testing:TAGrading] Add E2E Overridden Banner Tests Mar 6, 2026

[Testing:TAGrading] Remove unnecessary timeout in overridden banner test

ce9b2cc

Khine12 force-pushed the e2e-overridden-banner-tests branch from 828a94e to ce9b2cc Compare March 6, 2026 23:06

Merge branch 'main' into e2e-overridden-banner-tests

1b68af6

IDzyre reviewed Mar 10, 2026

View reviewed changes

Khine12 added 4 commits March 10, 2026 17:00

Merge branch 'main' into e2e-overridden-banner-tests

ca0e6a1

Merge branch 'main' into e2e-overridden-banner-tests

59ad969

[Testing:TAGrading] Add banner content assertions to E2E test

c0ab23a

Merge branch 'e2e-overridden-banner-tests' of https://github.com/Khin…

4d34b81

…e12/Submitty into e2e-overridden-banner-tests

Khine12 requested a review from JManion32 March 11, 2026 23:04

automateprojectmangement Bot moved this from Work in Progress to In Review in Submitty Development Mar 11, 2026

Khine12 requested a review from IDzyre March 11, 2026 23:04

Khine12 added 2 commits March 13, 2026 14:31

Merge branch 'main' into e2e-overridden-banner-tests

53f179f

Merge branch 'main' into e2e-overridden-banner-tests

328d1e8

IDzyre moved this from In Review to Awaiting Maintainer Review in Submitty Development Mar 13, 2026

Merge branch 'main' into e2e-overridden-banner-tests

2dc2404

bmcutler moved this from Awaiting Maintainer Review to In Review in Submitty Development Mar 22, 2026

IDzyre approved these changes Mar 22, 2026

View reviewed changes

williamjallen merged commit 6073b20 into Submitty:main Mar 23, 2026
25 checks passed

Khine12 deleted the e2e-overridden-banner-tests branch March 28, 2026 08:26

Khine12 mentioned this pull request Mar 31, 2026

Grader vs Full Access Grader #11366

Closed

Uh oh!

Conversation

Khine12 commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why is this Change Important & Necessary?

What is the New Behavior?

What steps should a reviewer take to reproduce or test the bug or new feature?

Automated Testing & Documentation

Other information

Uh oh!

codecov Bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JManion32 left a comment

Choose a reason for hiding this comment

Uh oh!

Khine12 commented Mar 5, 2026

Uh oh!

Khine12 commented Mar 5, 2026

Uh oh!

Uh oh!

IDzyre commented Mar 6, 2026

Uh oh!

IDzyre Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Khine12 Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

IDzyre Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Khine12 Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Khine12 commented Mar 10, 2026

Uh oh!

Khine12 commented Mar 14, 2026

Uh oh!

bmcutler commented Mar 22, 2026

Uh oh!

IDzyre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Khine12 commented Mar 5, 2026 •

edited

Loading

codecov Bot commented Mar 5, 2026 •

edited

Loading