[Feature:Submission] Jupyter warnings outside notebook#12523
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12523 +/- ##
=========================================
Coverage 21.67% 21.67%
+ Complexity 9807 9803 -4
=========================================
Files 268 268
Lines 36722 36721 -1
Branches 490 490
=========================================
Hits 7960 7960
+ Misses 28276 28275 -1
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Hi @williamjallen , I've fixed the PHPStan errors. Could you please re-run the CI? Thanks! |
|
Hey, Please look at the CI failure. |
|
@williamjallen I investigated all the failing Cypress tests — none of them The data-testid="notebook-view" element does not exist anywhere in Could you please confirm these are pre-existing CI failures? |
|
not abandoned |
williamjallen
left a comment
There was a problem hiding this comment.
Great work on this! I tested it and it works as described. Code looks great as well.
* main: (50 commits) [Bugfix:Developer] Fix Broken CI (#12851) [Bugfix:System] Restore TCLAPP (#12850) [Bugfix:Submission] Fix non-VCS repo error (#12608) [Feature:Submission] Jupyter warnings outside notebook (#12523) [Bugfix:InstructorUI] Removed feature flag for Bulk Late Days (#12826) [Bugfix:Forum] Fix stats header rendering (#12698) [Bugfix:Autograding] Fix negative number tolerance (#12569) [Bugfix:HelpQueue] Always use Abbreviated Names in OH (#12820) [Bugfix:Autograding] Fix regrade team detection (#12737) [Dependency] Bump Lichen from v23.09.00 to v26.04.01 (#12823) [Dependency] Bump RainbowGrades from v25.10.00 to v26.04.01 (#12824) [Feature:Developer] Remove misc Java utils and TCLAPP (#12819) [Bugfix:TAGrading] Fix 2-panel open-document select (#12577) [Dependency] Bump AnalysisToolsTS from v23.10.00 to v26.04.00 (#12822) [Bugfix:Developer] Fix bump_repo permissions (#12821) [Bugfix:InstructorUI] Change Colors to match in Docker UI table (#12739) [Bugfix:Forum] Reduce Page Caching (#12339) [Bugfix:System] File lost when running install clean fix (#12158) [Bugfix:Submission] No File Rubric submit all user groups (#12812) [Dependency] Bump twig/markdown-extra from 3.23.0 to 3.24.0 in /site (#12721) ...
Why is this Change Important & Necessary?
Previously, warnings for oversized or partially skipped Jupyter notebooks were
injected as markdown cells inside the rendered notebook itself. This was
inconsistent with Submitty's existing UI patterns for displaying messages, and
made the warnings easy to miss or confuse with actual notebook content.
Closes #11928
What is the New Behavior?
NotebookUtils::jupyterToSubmittyNotebook()now returns a structured arraywith keys:
cells,size_exceeded,skipped_content_count,skipped_output_countinstead of injecting warning markdown cells directly.
MiscController.phpunpacks these flags and passes them to the Twig template.Notebook.twignow displays a red alert banner above the notebook when thefile exceeds 10MB, and a yellow alert banner when any content/outputs were
skipped — using Submitty's existing alert styles.
No functional change — same warnings are shown, just displayed outside the
notebook in a cleaner, consistent way.
What steps should a reviewer take to reproduce or test the bug or new feature?
truncated outputs to a gradeable
To test size exceeded case:
Automated Testing & Documentation
This is a UI consistency improvement with no functional behavior change.
No documentation update required on submitty.org.
Other information
jupyterToSubmittyNotebook()return type changed from flat array tostructured array — only called in one place (MiscController.php) so
no other files affected