### Why is this Change Important & Necessary?

Fixes Submitty#12505

In `TeamController::showPage()`, the method
[getUserById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:150:4-158:5)
is called inside two separate `foreach` loops once per team member and
once per user seeking a team. Each call executes an individual `SELECT`
query against the database, resulting in an N+1 query pattern.

For a team with 5 members and 20 students seeking teams, this executes
**25 individual queries** where **1 batch query** would suffice.

The batch method
[getUsersById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:6361:4-6395:5)
already exists in
[DatabaseQueries.php](cci:7://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:0:0-0:0)
and is used elsewhere in the codebase (e.g.,
`ElectronicGraderController::importTeams()`), but was not utilized here.

### What is the New Behavior?

**Before:** Two loops each calling
[getUserById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:150:4-158:5)
per user (N+1 pattern)

**After:** A single batch
[getUsersById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:6361:4-6395:5)
call before the loops, then lookups from the pre-fetched map

No UI changes the page renders identically. The only difference is fewer
database queries.

### What steps should a reviewer take to reproduce or test the bug or
new feature?

1. Navigate to a team assignment's team management page:
`/courses/{semester}/{course}/gradeable/{gradeable_id}/team`
2. Verify that team members are listed correctly
3. Verify that users seeking a team are listed correctly
4. Verify that team invitations still display properly

### Automated Testing & Documentation

- No new tests are required this is a refactor with no functional change
- Existing Cypress E2E tests for team management should continue to pass
- No documentation changes needed

### Other information

- **Not a breaking change** same data is returned in the same order,
just fetched more efficiently
- **No migrations needed** uses the existing
[getUsersById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:6361:4-6395:5)
method from
[DatabaseQueries.php](cci:7://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:0:0-0:0)
- **No security concerns** no change in data access patterns or
permissions

---------

Co-authored-by: Ashutosh <[email protected]>

### Why is this Change Important & Necessary?

Fixes Submitty#12505

In `TeamController::showPage()`, the method
[getUserById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:150:4-158:5)
is called inside two separate `foreach` loops once per team member and
once per user seeking a team. Each call executes an individual `SELECT`
query against the database, resulting in an N+1 query pattern.

For a team with 5 members and 20 students seeking teams, this executes
**25 individual queries** where **1 batch query** would suffice.

The batch method
[getUsersById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:6361:4-6395:5)
already exists in
[DatabaseQueries.php](cci:7://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:0:0-0:0)
and is used elsewhere in the codebase (e.g.,
`ElectronicGraderController::importTeams()`), but was not utilized here.

### What is the New Behavior?

**Before:** Two loops each calling
[getUserById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:150:4-158:5)
per user (N+1 pattern)

**After:** A single batch
[getUsersById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:6361:4-6395:5)
call before the loops, then lookups from the pre-fetched map

No UI changes the page renders identically. The only difference is fewer
database queries.

### What steps should a reviewer take to reproduce or test the bug or
new feature?

1. Navigate to a team assignment's team management page:
`/courses/{semester}/{course}/gradeable/{gradeable_id}/team`
2. Verify that team members are listed correctly
3. Verify that users seeking a team are listed correctly
4. Verify that team invitations still display properly

### Automated Testing & Documentation

- No new tests are required this is a refactor with no functional change
- Existing Cypress E2E tests for team management should continue to pass
- No documentation changes needed

### Other information

- **Not a breaking change** same data is returned in the same order,
just fetched more efficiently
- **No migrations needed** uses the existing
[getUsersById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:6361:4-6395:5)
method from
[DatabaseQueries.php](cci:7://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:0:0-0:0)
- **No security concerns** no change in data access patterns or
permissions

---------

Co-authored-by: Ashutosh <[email protected]>

### Why is this Change Important & Necessary?

Fixes Submitty#12505

In `TeamController::showPage()`, the method
[getUserById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:150:4-158:5)
is called inside two separate `foreach` loops once per team member and
once per user seeking a team. Each call executes an individual `SELECT`
query against the database, resulting in an N+1 query pattern.

For a team with 5 members and 20 students seeking teams, this executes
**25 individual queries** where **1 batch query** would suffice.

The batch method
[getUsersById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:6361:4-6395:5)
already exists in
[DatabaseQueries.php](cci:7://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:0:0-0:0)
and is used elsewhere in the codebase (e.g.,
`ElectronicGraderController::importTeams()`), but was not utilized here.

### What is the New Behavior?

**Before:** Two loops each calling
[getUserById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:150:4-158:5)
per user (N+1 pattern)

**After:** A single batch
[getUsersById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:6361:4-6395:5)
call before the loops, then lookups from the pre-fetched map

No UI changes the page renders identically. The only difference is fewer
database queries.

### What steps should a reviewer take to reproduce or test the bug or
new feature?

1. Navigate to a team assignment's team management page:
`/courses/{semester}/{course}/gradeable/{gradeable_id}/team`
2. Verify that team members are listed correctly
3. Verify that users seeking a team are listed correctly
4. Verify that team invitations still display properly

### Automated Testing & Documentation

- No new tests are required this is a refactor with no functional change
- Existing Cypress E2E tests for team management should continue to pass
- No documentation changes needed

### Other information

- **Not a breaking change** same data is returned in the same order,
just fetched more efficiently
- **No migrations needed** uses the existing
[getUsersById()](cci:1://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:6361:4-6395:5)
method from
[DatabaseQueries.php](cci:7://file:///c:/Users/BIT/Desktop/Submitty/site/app/libraries/database/DatabaseQueries.php:0:0-0:0)
- **No security concerns** no change in data access patterns or
permissions

---------

Co-authored-by: Ashutosh <[email protected]>