[Feature:System] Verify migration datestamps by jndlansh · Pull Request #12474 · Submitty/Submitty

jndlansh · 2026-02-25T19:58:23Z

Why is this Change Important & Necessary?

Migration files are executed in chronological order based on their datestamp. If a pull request containing a migration remains open for an extended period before merging, its datestamp may become stale. When merged later, this can cause the migration to execute out of order on systems updating from older versions, potentially leading to dependency failures.

This change introduces a CI check to prevent stale migration files from being merged.

What is the New Behavior?

A new GitHub Action runs on pull requests that modify files under:
migration/migrator/migrations/**

The workflow:

Identifies migration files added or modified in the PR
Validates that filenames follow the expected format (YYYYMMDDHHMMSS_description.py)
Fails the check if any migration file is older than 7 days (default threshold)
Prints a clear message explaining how to rename the file

The maximum allowed age can be configured via the MAX_MIGRATION_AGE_DAYS environment variable.

What steps should a reviewer take to reproduce or test the bug or new feature?

Create a branch and add a migration file with a timestamp older than 7 days.
Open a pull request.
Confirm that the GitHub Action fails and reports the file as stale.

To verify the passing case:

Rename the migration file to use a current timestamp.
Push the change.
Confirm the GitHub Action passes.

Unit tests for the verification script can be run locally using:
pytest migration/tests/test_verify_migration_datestamp.py

Automated Testing & Documentation

Unit tests have been added for:

Filename parsing (valid and invalid formats)
Fresh vs stale migration detection
Custom age threshold handling
Git diff filtering logic

All tests pass locally.

Other information

No breaking change.
No database schema changes are introduced by this PR.
No security concerns are introduced.
This PR adds CI validation only and does not affect runtime behaviour.

JManion32 · 2026-02-26T21:52:51Z

Hey @jndlansh, thank you for your contribution, and thorough pull request description. Please update your title to match Submitty conventions: [<TYPE>:<MODULE>] <SUBJECT>. More information can be found here.

jndlansh · 2026-02-27T02:51:14Z

Thanks @JManion32 for correcting my PR title. I hope now it complies with the rules and regulations.

jndlansh · 2026-02-27T04:46:20Z

Hi @williamschen23, could you please approve the workflows for this PR when you have a moment so the CI checks can initiate? That would be great.

codecov · 2026-02-28T03:53:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.48%. Comparing base (d0682c2) to head (9458de7).

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #12474   +/-   ##
=========================================
  Coverage     21.48%   21.48%           
  Complexity     9842     9842           
=========================================
  Files           268      268           
  Lines         36851    36851           
  Branches        495      495           
=========================================
  Hits           7919     7919           
  Misses        28441    28441           
  Partials        491      491

Flag	Coverage Δ
autograder	`21.32% <ø> (ø)`
js	`2.01% <ø> (ø)`
migrator	`100.00% <ø> (ø)`
php	`20.52% <ø> (ø)`
python_submitty_utils	`80.08% <ø> (ø)`
submitty_daemon_jobs	`91.13% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

williamjallen · 2026-02-28T03:58:53Z

@jndlansh Please see failing CI.

jndlansh · 2026-02-28T05:09:05Z

hey @williamjallen
I have tried to fix the linting and unit test errors, could you kindly approve the workflows again. This time all the tests should pass.
https://drive.google.com/file/d/14YJKfv8YECtMW7yyFujsBSf7pDtWuhZC/view?usp=drive_link

williamjallen · 2026-03-01T00:40:06Z

@jndlansh Please see failing CI. You can test your changes on your own fork for faster iteration with our CI checks.

jndlansh · 2026-03-01T10:56:08Z

@jndlansh Please see failing CI. You can test your changes on your own fork for faster iteration with our CI checks.

I am not able to run CI checks on my fork, it shows no workflow runs, could you please guide me on how to do that @williamjallen ?

Newer : Now I have passed the CI tests on my VM, it that alright or i need to check in my fork?

…testamp

jndlansh · 2026-03-05T02:18:20Z

Hey @williamjallen !

Could you please approve the workflows, I have passed the CI checks.

jndlansh · 2026-03-09T17:50:14Z

hey @williamjallen could you please review my PR?

JManion32

Code changes seem reasonable, but I have a few changes to request before I test everything more thoroughly. The big change is adding the new job to ci.yml.

jndlansh · 2026-03-23T17:14:31Z

Hey @JManion32, I have reverted all the unnecessary changes and moved the verify_migration_datestamp.yml file to ci.yml .

Could you please review the changes made.

dandrecollins07-ctrl

Fixed ci.yml lint issue, also with one small requested change. Tested locally and the functionality works. Approving.

GarvitKhandelwal31

Looks good to me as well.

Add GitHub Action to verify migration file datestamp freshness

d31b192

github-project-automation Bot added this to Submitty Development Feb 25, 2026

github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Feb 25, 2026

jndlansh mentioned this pull request Feb 25, 2026

Verify Migration File datestamp using a Github Action test #12446

Closed

Merge branch 'main' into feature/verify-migration-datestamp

a2f98a7

jndlansh marked this pull request as draft February 26, 2026 02:48

automateprojectmangement Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Feb 26, 2026

jndlansh marked this pull request as ready for review February 26, 2026 04:35

jndlansh marked this pull request as draft February 26, 2026 04:36

automateprojectmangement Bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Feb 26, 2026

automateprojectmangement Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Feb 26, 2026

jndlansh marked this pull request as ready for review February 26, 2026 07:00

automateprojectmangement Bot moved this from Work in Progress to Seeking Reviewer in Submitty Development Feb 26, 2026

jndlansh changed the title ~~CI: Verify migration datestamps~~ [Feature:System] Verify migration datestamps Feb 27, 2026

Fix Python lint, YAML lint, and unit test issues/CI fails

9c98d8a

jndlansh added 3 commits March 1, 2026 23:51

Fix Python lint, YAML lint, and unit test issues; update migration da…

790d336

…testamp

changes to resolve CI check errors

6052f30

Python Lint checks

ecbe638

williamjallen requested changes Mar 7, 2026

View reviewed changes

Comment thread site/public/js/server.js Outdated

github-project-automation Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Mar 7, 2026

reverted extraneous changes in site/public/js/serrver.js

b98cb1b

jndlansh added 2 commits March 7, 2026 17:25

Fixed CI check errors (Autograding-tut)

af62dbc

Revert SubmitBox.twig to main, only keep initializeTimer change

f0dfe75

jndlansh requested a review from williamjallen March 9, 2026 17:49

automateprojectmangement Bot moved this from Work in Progress to In Review in Submitty Development Mar 9, 2026

Merge branch 'main' into feature/verify-migration-datestamp

ff1ba5d

JManion32 requested changes Mar 22, 2026

View reviewed changes

github-project-automation Bot moved this from In Review to Work in Progress in Submitty Development Mar 22, 2026

moved new job to ci.yml and reverted all the unwanted changes

1cd2247

github-actions Bot added the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Apr 7, 2026

Merge branch 'main' into feature/verify-migration-datestamp

ba22b86

GarvitKhandelwal31 reviewed Jun 12, 2026

View reviewed changes

Comment thread .github/scripts/verify_migration_datestamp.py Outdated

dandrecollins07-ctrl self-assigned this Jun 15, 2026

dandrecollins07-ctrl added 3 commits June 15, 2026 10:02

Merge branch 'main' into feature/verify-migration-datestamp

69528ff

Fix migration datestamp review feedback

d9f6be1

Fix trailing space

9458de7

dandrecollins07-ctrl approved these changes Jun 15, 2026

View reviewed changes

GarvitKhandelwal31 approved these changes Jun 15, 2026

View reviewed changes

github-actions Bot removed the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Jun 16, 2026

bmcutler merged commit 738850a into Submitty:main Jun 19, 2026
24 of 27 checks passed

Uh oh!

Conversation

jndlansh commented Feb 25, 2026 • edited by JManion32 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why is this Change Important & Necessary?

What is the New Behavior?

What steps should a reviewer take to reproduce or test the bug or new feature?

Automated Testing & Documentation

Other information

Uh oh!

JManion32 commented Feb 26, 2026

Uh oh!

jndlansh commented Feb 27, 2026

Uh oh!

jndlansh commented Feb 27, 2026

Uh oh!

codecov Bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

williamjallen commented Feb 28, 2026

Uh oh!

jndlansh commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

williamjallen commented Mar 1, 2026

Uh oh!

jndlansh commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jndlansh commented Mar 5, 2026

Uh oh!

Uh oh!

jndlansh commented Mar 9, 2026

Uh oh!

JManion32 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jndlansh commented Mar 23, 2026

Uh oh!

Uh oh!

dandrecollins07-ctrl left a comment

Choose a reason for hiding this comment

Uh oh!

GarvitKhandelwal31 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jndlansh commented Feb 25, 2026 •

edited by JManion32

Loading

codecov Bot commented Feb 28, 2026 •

edited

Loading

jndlansh commented Feb 28, 2026 •

edited

Loading

jndlansh commented Mar 1, 2026 •

edited

Loading