[Feature:InstructorUI] GUI for instructors to archive course by davidyim03 · Pull Request #12453 · Submitty/Submitty

davidyim03 · 2026-02-20T23:55:25Z

Why is this Change Important & Necessary?

What is the New Behavior?

Before, there were no ways for the instructors to archive/unarchive courses in the GUI, it had to be done through manually modifying the DB.
A new checkbox was added in the danger zone in the course configurations so that instructors can archive and unarchive courses in the configurations tab.

An unarchivable field was added to the courses table since the original issue suggests that unarchiving may cause problems due to space limitations. This field can be modified through directly modifying the DB, and once the field is set to False, the course cannot be unarchived.

What steps should a reviewer take to reproduce or test the bug or new feature?

Log in as instructor and go to course configuration to click to archive/unarchive courses

Automated Testing & Documentation

Completed manual testing of archiving and unarchiving and checked if field gets modified correspondingly.
Since UI was edited, modified PHP testing to include the new field unarchivable and all tests pass.

Other information

New migration file added to add unarchivable field to courses table

…y for modification added

bmcutler · 2026-02-21T16:20:35Z

@davidyim03

The text you have next to archive course is incorrect.
The course is not 'hidden from the course list' -- the course is only visible to 'instructor' users in that course.
The system does not block new submissions to archived courses -- we would like that to be true -- we would prefer users with access to archived courses do not make any changes to the course, but this is not currently enforced and will be complicated to implement.

davidyim03 · 2026-02-21T17:16:09Z

@bmcutler do you think things like converting files to read only and backing up data should also be mentioned in the instructions so that instructor can take appropriate actions?

currently modified description to

codecov · 2026-03-04T04:40:02Z

Codecov Report

❌ Patch coverage is 20.00000% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.48%. Comparing base (8fa4355) to head (c4485a8).

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12453      +/-   ##
============================================
- Coverage     21.48%   21.48%   -0.01%     
- Complexity     9842     9851       +9     
============================================
  Files           268      268              
  Lines         36851    36888      +37     
  Branches        495      495              
============================================
+ Hits           7919     7924       +5     
- Misses        28441    28473      +32     
  Partials        491      491

Flag	Coverage Δ
autograder	`21.32% <ø> (ø)`
js	`2.01% <ø> (ø)`
migrator	`100.00% <ø> (ø)`
php	`20.51% <20.00%> (-0.01%)`	⬇️
python_submitty_utils	`80.08% <ø> (ø)`
submitty_daemon_jobs	`91.13% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

IDzyre · 2026-03-04T04:53:40Z

+        return MultiResponse::JsonOnlyResponse(
+            JsonResponse::getSuccessResponse([
+                'message' => 'Course archived successfully'
+            ])
+        );


You should just return JsonResponse::getSuccessResponse() directly

davidyim03 · 2026-03-17T06:13:03Z

Added new changes to incorporate feedback
Few things however: I've noticed some inconsistencies throughout the codebase regarding semester and term so I couldn't fully change all the wordings in my code to term since that might lead to having to change files unrelated to this PR

davidyim03 · 2026-03-29T01:58:07Z

Fix: all linters now pass, cypress test fails on (Feature, Gradeable), but those are unrelated to the files I've modified so it might be a flaky test?

IDzyre · 2026-03-29T21:31:49Z

The CSS lint is failing due to an issue that was fixed on the main branch, so if you merge main into your PR that should pass. Also, the title module isn't passing the documentation tests. Also, yes one of the gradeable tests is currently failing on main, and will be fixed soon.

Eli-J-Schwartz

I tested this locally, and it seemed to work correctly; when I toggled the button, it switched from being available to being archived. I had to manually hard reload the page to see the actual button toggle change; do you know why this happens? Also, I noticed that there seem to be some changes from unrelated PRs in this one, such as changes to course_tables.sql. Finally, please fix the failing tests.

mattLif

Feature works as intended, and code looks good.

IDzyre · 2026-06-08T22:13:25Z

+  "/courses/<term>/<course>/config",
+  "/api/courses/<term>/<course>/config",


Is there a way to not add these to the performance warnings?

Added a db query and updated ConfigurationController accordingly to reduce db queries to less than 20, let me know what you think of this approach.

I think that is a valid approach, to combine the queries into one.

mattLif

Functionality still works, and changes look good. I'm approving.

Stale, comments addressed, but didn't test enough to explicitly approve.

davidyim03 and others added 6 commits February 20, 2026 01:20

DB migration new unarchivable flag to course, backend API and DB quer…

911c7f2

…y for modification added

js and frontend added

a1705d8

Merge branch 'Submitty:main' into main

52b31c1

modified php CICD testing to reflect change in DB course table

c4a9287

Merge branch 'main' of https://github.com/davidyim03/Submitty

01ebb8c

minor fixes before PR

b6909cc

github-project-automation Bot added this to Submitty Development Feb 20, 2026

github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Feb 20, 2026

davidyim03 closed this Feb 20, 2026

davidyim03 reopened this Feb 20, 2026

davidyim03 closed this Feb 20, 2026

davidyim03 changed the title ~~[Feature: InstructorUI] GUI for instructors to archive/unarchive course~~ [Feature: InstructorUI] GUI for instructors to archive course Feb 20, 2026

davidyim03 reopened this Feb 21, 2026

davidyim03 and others added 2 commits February 21, 2026 11:17

Merge branch 'Submitty:main' into main

97caf39

warning description fix

5ed8441

IDzyre requested changes Mar 4, 2026

View reviewed changes

davidyim03 and others added 3 commits March 17, 2026 00:40

Merge branch 'Submitty:main' into main

f8d05f0

PR feedback incorporated

3a77053

Merge branch 'main' of https://github.com/davidyim03/Submitty

653d5bb

IDzyre previously requested changes Mar 17, 2026

View reviewed changes

Comment thread migration/migrator/migrations/master/20260220140000_add_course_unarchivable.py Outdated

Comment thread site/app/controllers/admin/ConfigurationController.php

davidyim03 and others added 6 commits March 17, 2026 15:30

fixed migration to prevent data loss

940314f

Merge branch 'Submitty:main' into main

ee02ad8

db dump

eaa7019

Merge branch 'main' of https://github.com/davidyim03/Submitty

8d2f2e8

js linter fix

0d94ff8

php linter fix

605f110

davidyim03 added 3 commits March 25, 2026 13:09

db dump

d991f7a

dump fix

62ac0d3

cypress fix

e9d8b44

github-actions Bot added the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Apr 13, 2026

Eli-J-Schwartz requested changes Apr 30, 2026

View reviewed changes

Merge branch 'main' into main

d1f15d6

dagemcn changed the title ~~[Feature: InstructorUI] GUI for instructors to archive course~~ [Feature:InstructorUI] GUI for instructors to archive course Jun 5, 2026

dagemcn added 2 commits June 5, 2026 10:04

new dump with new dumper

2bebdd8

removed stray line from migration in other PR

cf9125e

dagemcn approved these changes Jun 8, 2026

View reviewed changes

Correct Confirmation Pop-up When Archiving a Course

27e8977

mattLif approved these changes Jun 8, 2026

View reviewed changes

IDzyre reviewed Jun 8, 2026

View reviewed changes

github-actions Bot removed the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Jun 9, 2026

dagemcn and others added 3 commits June 17, 2026 16:08

consolidating queries

367fff5

Merge branch 'main' into main

4549972

php lint

c4485a8

mattLif approved these changes Jun 18, 2026

View reviewed changes

bmcutler merged commit abd1ba5 into Submitty:main Jun 19, 2026
17 of 26 checks passed

		"/courses/<term>/<course>/config",
		"/api/courses/<term>/<course>/config",

Uh oh!

Conversation

davidyim03 commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why is this Change Important & Necessary?

What is the New Behavior?

What steps should a reviewer take to reproduce or test the bug or new feature?

Automated Testing & Documentation

Other information

Uh oh!

bmcutler commented Feb 21, 2026

Uh oh!

davidyim03 commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

IDzyre Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidyim03 commented Mar 17, 2026

Uh oh!

Uh oh!

Uh oh!

davidyim03 commented Mar 29, 2026

Uh oh!

IDzyre commented Mar 29, 2026

Uh oh!

Eli-J-Schwartz left a comment

Choose a reason for hiding this comment

Uh oh!

mattLif left a comment

Choose a reason for hiding this comment

Uh oh!

IDzyre Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

dagemcn Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IDzyre Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

mattLif left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

davidyim03 commented Feb 20, 2026 •

edited

Loading

davidyim03 commented Feb 21, 2026 •

edited

Loading

codecov Bot commented Mar 4, 2026 •

edited

Loading

dagemcn Jun 17, 2026 •

edited

Loading