Skip to content

[Feature:System] Change Postgres version to 14#12452

Merged
bmcutler merged 64 commits into
mainfrom
db-check-postgres
Jun 4, 2026
Merged

[Feature:System] Change Postgres version to 14#12452
bmcutler merged 64 commits into
mainfrom
db-check-postgres

Conversation

@Rkoester47

@Rkoester47 Rkoester47 commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Why is this Change Important & Necessary?

Currently, the version of postgres used in our CI testing is conflicting with the latest version, and is causing issues with migrations.

What is the New Behavior?

After unifying the version used between development VM, CI tests and production, migrations will no longer be impacted negatively.

What steps should a reviewer take to reproduce or test the bug or new feature?

Verify that the appropriate steps have been taken to ensure all relevant instances of Postgres are version 14.
We should also verify that nothing is broken when a migration is run and the DB check passes.

Automated Testing & Documentation

No automated testing.

Other information

@github-project-automation github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Feb 20, 2026
@automateprojectmangement automateprojectmangement Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Feb 20, 2026
@Rkoester47 Rkoester47 changed the title Upgrade postgres? [Developer:System] Upgrade postgres possibly? Feb 20, 2026
@codecov

codecov Bot commented Feb 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.62%. Comparing base (403c54a) to head (7f9c250).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #12452   +/-   ##
=========================================
  Coverage     21.62%   21.62%           
  Complexity     9819     9819           
=========================================
  Files           268      268           
  Lines         36812    36812           
  Branches        490      490           
=========================================
  Hits           7960     7960           
  Misses        28366    28366           
  Partials        486      486           
Flag Coverage Δ
autograder 21.32% <ø> (ø)
js 2.02% <ø> (ø)
migrator 100.00% <100.00%> (ø)
php 20.67% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rkoester47 Rkoester47 changed the title [Developer:System] Upgrade postgres possibly? [Developer:System] Upgrade to postgres version 17 Feb 22, 2026

@Christian2147 Christian2147 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Rkoester47 , thank you for your contribution!

Please update your PR title to use our required format
[<TYPE>:<MODULE>] <SUBJECT>, where <SUBJECT> is 40 chars max.
See also: https://submitty.org/developer/getting_started/make_a_pull_request

Please also use our PR description template:
https://raw.githubusercontent.com/Submitty/Submitty/refs/heads/main/.github/PULL_REQUEST_TEMPLATE.md

Since your changes affect the user interface, please include relevant screenshots before and after your change to demonstrate that you tested and debugged your PR. This will help reviewers check your work.

Be sure to link the issue that you are addressing in this PR. If the issue is completely closed with this PR say “Fixes #1234”, if it only partially addresses the issue, “work related to issue #1234

Once this pull request adheres to all Submitty conventions, we will proceed with a full review.

@Rkoester47

Copy link
Copy Markdown
Contributor Author

Hey @Rkoester47 , thank you for your contribution!

Please update your PR title to use our required format [<TYPE>:<MODULE>] <SUBJECT>, where <SUBJECT> is 40 chars max. See also: https://submitty.org/developer/getting_started/make_a_pull_request

Please also use our PR description template: https://raw.githubusercontent.com/Submitty/Submitty/refs/heads/main/.github/PULL_REQUEST_TEMPLATE.md

Since your changes affect the user interface, please include relevant screenshots before and after your change to demonstrate that you tested and debugged your PR. This will help reviewers check your work.

Be sure to link the issue that you are addressing in this PR. If the issue is completely closed with this PR say “Fixes #1234”, if it only partially addresses the issue, “work related to issue #1234

Once this pull request adheres to all Submitty conventions, we will proceed with a full review.

This PR is a draft and a work in progress. It will be formatted correctly once I mark it ready for review.

@Rkoester47 Rkoester47 closed this Feb 24, 2026
@github-project-automation github-project-automation Bot moved this from Work in Progress to Done in Submitty Development Feb 24, 2026
@Rkoester47 Rkoester47 reopened this Feb 24, 2026
@Rkoester47 Rkoester47 changed the title [Developer:System] Upgrade to postgres version 17 [Developer:System] Change Postgres version to 14 Feb 26, 2026
The VM and production prostres version is 14.20
@Rkoester47 Rkoester47 changed the title [Developer:System] Change Postgres version to 14 [Feature:System] Change Postgres version to 14 Feb 26, 2026
DB check is failing, it seems like the version change requires the restrict tokens. Will revert if this is the incorrect solution.
@JManion32

Copy link
Copy Markdown
Contributor

@Rkoester47 What's the status of this? Let me know if there's anything I can do to help.

@dagemcn dagemcn removed the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Jun 2, 2026
@dagemcn dagemcn moved this from Done to In Review in Submitty Development Jun 3, 2026
@dagemcn dagemcn moved this from In Review to Seeking Reviewer in Submitty Development Jun 3, 2026
Comment thread migration/migrator/cleaner.sh Outdated
@@ -0,0 +1,2 @@
#!/bin/bash

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagemcn
We can remove this file altogether?

@bmcutler
bmcutler merged commit 3edad87 into main Jun 4, 2026
25 of 26 checks passed
@bmcutler
bmcutler deleted the db-check-postgres branch June 4, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants