[UI/UX:InstructorUI] Condense Autograding Testcase Buttons#12436
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12436 +/- ##
=========================================
Coverage 21.66% 21.66%
Complexity 9637 9637
=========================================
Files 268 268
Lines 36222 36222
Branches 487 487
=========================================
Hits 7847 7847
Misses 27892 27892
Partials 483 483
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Rkoester47
left a comment
Rkoester47
left a comment
There was a problem hiding this comment.
I tested the changes made on this PR and they are working as described. I think it was a good idea to consolidate the buttons on this page, and the solution here is efficient and clean. The functionality of the page is intact and the look and intuitiveness have been improved. Good work fixing up these buttons.
Regarding your implementation, it seems like you left a block of your own commented out code in the branch. If this didn't end up being needed for your implementation, perhaps we should remove it from AutogradingPanel.ts.
github-project-automation
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
Thank you for pointing this out. I have removed the commented code. |
github-project-automation
Bot
moved this from Work in Progress
to Awaiting Maintainer Review
in Submitty Development
|
See my note on the original issue -- we don't want to combine expand all & collapse all. |
bmcutler
moved this from Awaiting Maintainer Review
to Work in Progress
in Submitty Development
JManion32
left a comment
JManion32
left a comment
There was a problem hiding this comment.
Any chance we can knock out this little bug where the hover doesn't span the length of the container here? Should be a small CSS change.
Functionality looks good, and I apologize for sending you on a wild goose chase with the Expand All and Collapse All buttons.
Once you revert that whitespace change and possibly fix that little UI bug, I'll approve.
automateprojectmangement
Bot
moved this from Work in Progress
to In Review
in Submitty Development
JManion32
left a comment
JManion32
left a comment
There was a problem hiding this comment.
I tested it again and it looks good, I just have a few more very small code changes to request.
github-project-automation
Bot
moved this from In Review
to Work in Progress
in Submitty Development
JManion32
left a comment
JManion32
left a comment
There was a problem hiding this comment.
Code and changes look good.
github-project-automation
Bot
moved this from Work in Progress
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
…12436) ### Why is this Change Important & Necessary? Closes Submitty#12432 ### What is the New Behavior? <img width="1764" height="660" alt="image" src="https://github.com/user-attachments/assets/8cb224c9-299c-4c2c-abd3-5c005f555bc4" /> Before, there was an extraneous regrade button that could be placed into the drop down menu. After: <img width="867" height="216" alt="image" src="https://github.com/user-attachments/assets/5962e4eb-d013-41d8-b5b8-bdd7cc55cbd6" /> The regrade active version has been placed into the drop down menu. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Log in as instructor 2. Go to any graded gradeable. 3. Click any student with autograding complete 4. See buttons ### Automated Testing & Documentation Manual Testing: Tested with Opera on Linux to verify accuracy of new changes. No automated testing for this change. ### Other information This is not a breaking change. There are no known security vulnerabilities with this change.
…12436) ### Why is this Change Important & Necessary? Closes Submitty#12432 ### What is the New Behavior? <img width="1764" height="660" alt="image" src="https://github.com/user-attachments/assets/8cb224c9-299c-4c2c-abd3-5c005f555bc4" /> Before, there was an extraneous regrade button that could be placed into the drop down menu. After: <img width="867" height="216" alt="image" src="https://github.com/user-attachments/assets/5962e4eb-d013-41d8-b5b8-bdd7cc55cbd6" /> The regrade active version has been placed into the drop down menu. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Log in as instructor 2. Go to any graded gradeable. 3. Click any student with autograding complete 4. See buttons ### Automated Testing & Documentation Manual Testing: Tested with Opera on Linux to verify accuracy of new changes. No automated testing for this change. ### Other information This is not a breaking change. There are no known security vulnerabilities with this change.
…12436) ### Why is this Change Important & Necessary? Closes Submitty#12432 ### What is the New Behavior? <img width="1764" height="660" alt="image" src="https://github.com/user-attachments/assets/8cb224c9-299c-4c2c-abd3-5c005f555bc4" /> Before, there was an extraneous regrade button that could be placed into the drop down menu. After: <img width="867" height="216" alt="image" src="https://github.com/user-attachments/assets/5962e4eb-d013-41d8-b5b8-bdd7cc55cbd6" /> The regrade active version has been placed into the drop down menu. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Log in as instructor 2. Go to any graded gradeable. 3. Click any student with autograding complete 4. See buttons ### Automated Testing & Documentation Manual Testing: Tested with Opera on Linux to verify accuracy of new changes. No automated testing for this change. ### Other information This is not a breaking change. There are no known security vulnerabilities with this change.
4 participants
Why is this Change Important & Necessary?
Closes #12432
What is the New Behavior?
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
Manual Testing: Tested with Opera on Linux to verify accuracy of new changes.
No automated testing for this change.
Other information
This is not a breaking change.
There are no known security vulnerabilities with this change.