[Testing:Notifications] E2E Notification Testing#12430
Open
JManion32 wants to merge 16 commits into
Open
Conversation
Functions for putting the UI in the correct state, and resetting as best as possible at the end.
Working on reducing time by calling the API directly
POST request now creates announcements properly, deletion still being worked out
automateprojectmangement
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12430 +/- ##
============================================
- Coverage 21.36% 21.30% -0.07%
- Complexity 10025 10055 +30
============================================
Files 277 277
Lines 37508 37621 +113
Branches 513 513
============================================
Hits 8014 8014
- Misses 28992 29105 +113
Partials 502 502
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JManion32
changed the title
github-actions
Bot
added
the
Abandoned PR - Needs New Owner
JManion32
removed
the
Abandoned PR - Needs New Owner
Testing that this test doesn't intervene with others since I cannot fully delete the forum announcements I create.
bmcutler
pushed a commit
that referenced
this pull request
Apr 15, 2026
### Why is this Change Important & Necessary? A small feature on the home page notifications panel is the course button, which should redirect the user to that course's notification page. Currently, it redirects the user to the origin of the notification just like the rest of the button. <img width="1097" height="470" alt="image" src="https://github.com/user-attachments/assets/d7eb8eea-042a-47d1-839b-67b932e33272" /> ### What is the New Behavior? Clicking the course button now redirects to that course's notification page. ### What steps should a reviewer take to reproduce or test the bug or new feature? On main: Click the course button. Redirect to notification origin. Feature branch. Click the course button, Redirect to that course's notification page. ### Automated Testing & Documentation #12430 is in progress and will test this feature. ### Other information This is not a breaking change.
github-actions
Bot
added
the
Abandoned PR - Needs New Owner
JManion32
removed
the
Abandoned PR - Needs New Owner
github-actions
Bot
added
the
Abandoned PR - Needs New Owner
JManion32
removed
the
Abandoned PR - Needs New Owner
github-actions
Bot
added
the
Abandoned PR - Needs New Owner
JManion32
removed
the
Abandoned PR - Needs New Owner
Added 5 tests to cover the notification system
JManion32
marked this pull request as ready for review
July 5, 2026 20:10
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
Removed for loop in mark individual noti seen, probably won't fix the ci issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Closes #11908
The notifications system does not have E2E testing. As the system continues to support more features, it is increasingly important to have a complete automated test.
What is the New Behavior?
Implemented testing for notification displaying and management. New tests include:
Implementation Details:
NotificationsDisplay.vueandNotification.vuethat I caught while creating the tests.mark seen and additional unseen messagetest, I had to create notifications in 2 separate courses. I chose TESTING as the second course, since it looks like we use it in a few other tests. Because of this, I usedtato create the announcements instead ofinstructorbecause they were registered in TESTING.What steps should a reviewer take to reproduce or test the bug or new feature?
notifications.spec.jsmultiple times locally, and verify that is consistently works. If any test in the suite fails, report it.Automated Testing & Documentation
The notifications system is now adequately tested.
Other information
This is not a breaking change.
Potential Future Additions: