[Refactor:Autograding] Remove python-dateutil dependency#12426
Merged
Conversation
Farhanxikram
approved these changes
Feb 13, 2026
Farhanxikram
left a comment
Farhanxikram
left a comment
There was a problem hiding this comment.
Functionality review:
- python-dateutil has been removed from the system requirements file
- I used grep to search for "From dateutils" and there were no instances of that, I also checked "import dateutils" and all dateutils were imported from submitty utillities and not sourced externally
- I pip removed python's date utils from my VM and the tests passed, and dates were completely fine on the webpage side (I was able to edit assignments as an instructor and change dates completely fine)
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
Contributor
Author
|
Thank you for the review and the detailed feedback, @Farhanxikram! |
HasTheDev
changed the title
HasTheDev
changed the base branch from
main
to
patch_customization_migration
February 15, 2026 12:09
HasTheDev
changed the base branch from
patch_customization_migration
to
main
February 15, 2026 12:09
HasTheDev
changed the base branch from
main
to
patch_customization_migration
February 15, 2026 12:33
HasTheDev
changed the base branch from
patch_customization_migration
to
main
February 15, 2026 12:33
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12426 +/- ##
============================================
- Coverage 21.65% 21.65% -0.01%
Complexity 9638 9638
============================================
Files 268 268
Lines 36233 36230 -3
Branches 486 486
============================================
- Hits 7847 7845 -2
+ Misses 27904 27903 -1
Partials 482 482
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Work in Progress
in Submitty Development
williamschen23
previously requested changes
Feb 17, 2026
williamschen23
left a comment
williamschen23
left a comment
Contributor
There was a problem hiding this comment.
Lint still fails, please fix!
williamschen23
moved this from Work in Progress
to Awaiting Maintainer Review
in Submitty Development
Contributor
Author
|
Hi @Farhanxikram! Thanks so much for approving the code! It looks like the CI workflows are currently paused and 'awaiting approval' to run. Could someone please trigger them when they have a second? I'll keep an eye on the results. |
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
GarvitKhandelwal31
pushed a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Mar 29, 2026
) ### Why is this Change Important & Necessary? This PR removes the python-dateutil dependency. We already have a strong internal submitty_utils/dateutils parser, so using an external library for the same task is not necessary. Moving to a single parser simplifies the codebase and makes us less dependent on external tools. Closes Submitty#11344 ### What is the New Behavior? The functionality doesn't change for normal users. The backend has been changed to use the internal Submitty utilities for all date string parsing instead of the external dateutil library. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Check that python-dateutil isn't listed in .setup/pip/system_requirements.txt. 2. Verify that there aren't any import dateutil statements left in the Python source code (I've checked this with grep). 3. Run any action involving date parsing to make sure no ModuleNotFoundError appears. ### Automated Testing & Documentation 1. Unit Tests: I ran the internal utility tests locally: python3 -m unittest python_submitty_utils/tests/test_dateutils.py. All 15 tests passed. 2. End-to-End: Verified basic submission cycles in a local Vagrant environment. 3. Documentation: No changes to submitty.org are needed for this backend change. Other information Breaking Change? No. Migrations? No. Security? Yes, slightly improved by reducing the number of third-party packages. --------- Co-authored-by: HAMMU2025 <[email protected]> Co-authored-by: Barb Cutler <[email protected]>
GarvitKhandelwal31
pushed a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Apr 14, 2026
) ### Why is this Change Important & Necessary? This PR removes the python-dateutil dependency. We already have a strong internal submitty_utils/dateutils parser, so using an external library for the same task is not necessary. Moving to a single parser simplifies the codebase and makes us less dependent on external tools. Closes Submitty#11344 ### What is the New Behavior? The functionality doesn't change for normal users. The backend has been changed to use the internal Submitty utilities for all date string parsing instead of the external dateutil library. ### What steps should a reviewer take to reproduce or test the bug or new feature? 1. Check that python-dateutil isn't listed in .setup/pip/system_requirements.txt. 2. Verify that there aren't any import dateutil statements left in the Python source code (I've checked this with grep). 3. Run any action involving date parsing to make sure no ModuleNotFoundError appears. ### Automated Testing & Documentation 1. Unit Tests: I ran the internal utility tests locally: python3 -m unittest python_submitty_utils/tests/test_dateutils.py. All 15 tests passed. 2. End-to-End: Verified basic submission cycles in a local Vagrant environment. 3. Documentation: No changes to submitty.org are needed for this backend change. Other information Breaking Change? No. Migrations? No. Security? Yes, slightly improved by reducing the number of third-party packages. --------- Co-authored-by: HAMMU2025 <[email protected]> Co-authored-by: Barb Cutler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
This PR removes the python-dateutil dependency. We already have a strong internal submitty_utils/dateutils parser, so using an external library for the same task is not necessary. Moving to a single parser simplifies the codebase and makes us less dependent on external tools.
Closes #11344
What is the New Behavior?
The functionality doesn't change for normal users. The backend has been changed to use the internal Submitty utilities for all date string parsing instead of the external dateutil library.
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
Other information
Breaking Change? No.
Migrations? No.
Security? Yes, slightly improved by reducing the number of third-party packages.