[UI/UX:Submission] "My Late Days" Page Update by John-Roy123 · Pull Request #12361 · Submitty/Submitty

John-Roy123 · 2026-01-31T02:08:09Z

Why is this Change Important & Necessary?

When Student users are looking for how many late days they currently have, they would either have to wait until an assignment was already past due to see how many late days they had or they could look at the "My Late Days" page, which had their current number of of late days at the very bottom right. For classes with many late-day additions, the relevant information to the user would be buried at the very bottom. This new change puts the relevant information to the user as the first thing they see.

What is the New Behavior?

Before:

After:

What steps should a reviewer take to reproduce or test the bug or new feature?

Open the "My Late Days" page

Automated Testing & Documentation

UI change, tests don't cover this change

Other information

This is an HTML change that talks to the HomeworkView API

- Added explanation of table for user to better understand how to read the table - Added users # of late days at the top, so when users click "My Late Days", the first thing they see is how many late days they have

codecov · 2026-01-31T02:09:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.64%. Comparing base (2879a09) to head (2251771).
⚠️ Report is 76 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12361      +/-   ##
============================================
- Coverage     21.73%   21.64%   -0.10%     
- Complexity     9623     9654      +31     
============================================
  Files           268      268              
  Lines         36167    36244      +77     
  Branches        486      487       +1     
============================================
- Hits           7862     7845      -17     
- Misses        27823    27916      +93     
- Partials        482      483       +1

Flag	Coverage Δ
autograder	`21.32% <ø> (-0.07%)`	⬇️
js	`2.04% <ø> (-0.01%)`	⬇️
migrator	`100.00% <ø> (ø)`
php	`20.66% <ø> (-0.11%)`	⬇️
python_submitty_utils	`80.08% <ø> (ø)`
submitty_daemon_jobs	`91.13% <ø> (+0.41%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JManion32

This is a massive QOL improvement, I just have a few nitpicks (please push back if you feel otherwise):

Why change the <h1>? "My" is consistent with other pages:

In my opinion, we shouldn't use you at all here. From what I've seen, most of the site uses a documentation/"neutral" style of wording (a great example is the Manage Sections page) where we never explicitly reference the user.

Overall, I think this is a great change, but we should keep the paragraph/wording concise, and consistent with the rest of Submitty.

John-Roy123 · 2026-02-01T23:19:11Z

@JManion32 Thank you for the feedback, I changed the h1 because it was "My Late Day Usage" which also didn't match the title of the page and looked odd next to "You have X late days remaining". In my most recent commit I changed it to "My Late Days" and changed the h3 to also be neutral instead of 2nd person. I also made the other changes you suggested

-Previously If statement would break page if late_days was not defined, changed the if statement to only affect h3 component

John-Roy123 · 2026-02-01T23:26:34Z

@cjreed121 Thank you for pointing that out. I moved the if statement so that only the h3 element is not rendered in the case where late_days is not defined.

cjreed121 · 2026-02-02T03:36:14Z

    }
 }
+
+.content > * + * {


This is quite a complicated selector. What are you trying to select? Can it be simpler?

It just selects everything after the first element. If I just did ".content > * " it would add a top margin before "My Late Days" which isn't necessary and would make it inconsistent with every other page, so " * + * " selects everything after that for the top margin.

This selector needs to be more specific. Please add a descriptive class to the particular element you're trying to style.

Rkoester47

I think these changes are intuitive and helpful for quickly seeing where you stand with late days. I believe updating the page header to match the title at the top is a good move for site consistency. After implementing requested changes, your code looks good and the feature is working properly for me.

JManion32

A few more wording changes:

Always use term instead of semester, as not all schools use the semester system.
The first and last sentences seem redundant to me. What about something that combines them, like:

The table below provides a detailed history of your
late day balance throughout the term. Depending
on your course policy, you may have a fixed
amount, or the opportunity to earn additional days.

Other than that, this looks good, and will definitely improve the student experience. Great work!

JManion32

Wording / changes look good to me. This is a significant quality of life improvement for the Late Days page. Great work!

bmcutler · 2026-02-20T18:03:35Z

@cjreed121 do you approve the final version of this PR?

williamjallen · 2026-02-28T04:25:03Z

    }
 }
+
+.content > * + * {


This selector needs to be more specific. Please add a descriptive class to the particular element you're trying to style.

williamjallen

Please also add a Cypress test as well.

williamjallen · 2026-03-07T01:47:18Z

+
    {% include 'LateDaysTablePlugin.twig' %}
-</div>
+</div>


This whitespace change should be reverted.

This still needs to be addressed.

williamjallen · 2026-03-07T01:49:28Z

+    <h3>
+    Number of late days remaining: {{ late_days.getLateDaysRemaining() }}
+    </h3>
+    <p>The table below provides a detailed history of your
+late day balance throughout the term. Depending
+on your course policy, you may have a fixed
+amount or the opportunity to earn additional days.
+    </p>


Can you please clean up the formatting here?

Suggested change

<h3>

Number of late days remaining: {{ late_days.getLateDaysRemaining() }}

</h3>

<p>The table below provides a detailed history of your

late day balance throughout the term. Depending

on your course policy, you may have a fixed

amount or the opportunity to earn additional days.

</p>

<h3>

Number of late days remaining: {{ late_days.getLateDaysRemaining() }}

</h3>

<p>

The table below provides a detailed history of your

late day balance throughout the term. Depending

on your course policy, you may have a fixed

amount or the opportunity to earn additional days.

</p>

John-Roy123 · 2026-03-10T20:50:20Z

Please also add a Cypress test as well.

Thank you for your review! Could you be a little more specific about what you had in mind for a Cypress test for this change?

williamjallen · 2026-03-13T02:02:28Z

+}
+
+.late-description{
+    margin: 0.5rem, 0, 0.5rem, 0; 


You can use margin: 0.5rem, 0; to be more concise. https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/margin

williamjallen · 2026-03-13T02:02:46Z

+
    {% include 'LateDaysTablePlugin.twig' %}
-</div>
+</div>


This still needs to be addressed.

williamjallen · 2026-03-13T02:09:52Z

Please also add a Cypress test as well.

Thank you for your review! Could you be a little more specific about what you had in mind for a Cypress test for this change?

You should add a test which verifies that the correct number of late days remaining is displayed. The most difficult part will be figuring out how to manipulate the UI to result in 0, 1, and 2 late days remaining.

John-Roy123 · 2026-03-21T19:12:09Z

Please also add a Cypress test as well.

Thank you for your review! Could you be a little more specific about what you had in mind for a Cypress test for this change?

You should add a test which verifies that the correct number of late days remaining is displayed. The most difficult part will be figuring out how to manipulate the UI to result in 0, 1, and 2 late days remaining.

Hi William, I made the text change you suggested and created an E2E test to show that the late day page updates when late days are given or removed from a student. Let me know if there is anything else this PR needs before it can be merged.

Rkoester47

I checked the changes you've made and this branch still looks good to me. I ran the new cypress test locally, and it passed for me. I am approving this PR again.

Late Day Page Update

97d1875

- Added explanation of table for user to better understand how to read the table - Added users # of late days at the top, so when users click "My Late Days", the first thing they see is how many late days they have

github-project-automation Bot added this to Submitty Development Jan 31, 2026

github-project-automation Bot moved this to Seeking Reviewer in Submitty Development Jan 31, 2026

John-Roy123 changed the title ~~[UI/UX] "My Late Days" Page Update~~ [CourseMaterials] "My Late Days" Page Update Jan 31, 2026

John-Roy123 changed the title ~~[CourseMaterials] "My Late Days" Page Update~~ [UI/UX:CourseMaterials] "My Late Days" Page Update Jan 31, 2026

JManion32 requested changes Jan 31, 2026

View reviewed changes

Comment thread site/app/templates/LateDaysTable.twig Outdated

Comment thread site/app/templates/LateDaysTable.twig Outdated

github-project-automation Bot moved this from Seeking Reviewer to Work in Progress in Submitty Development Jan 31, 2026

John-Roy123 added 2 commits January 31, 2026 10:02

Changed phrasing

09cbbae

Text change

5196058

cjreed121 changed the title ~~[UI/UX:CourseMaterials] "My Late Days" Page Update~~ [UI/UX:Submission] "My Late Days" Page Update Jan 31, 2026

cjreed121 requested changes Jan 31, 2026

View reviewed changes

Comment thread site/app/templates/LateDaysTable.twig Outdated

If statement change

82fbb7c

-Previously If statement would break page if late_days was not defined, changed the if statement to only affect h3 component

cjreed121 reviewed Feb 2, 2026

View reviewed changes

Comment thread site/app/templates/LateDaysTable.twig Outdated

Removed redundant if statement

4e003bb

cjreed121 requested changes Feb 2, 2026

View reviewed changes

John-Roy123 and others added 3 commits February 3, 2026 16:23

Reverts new line changes

11a7c3e

Remove unnecessary blank line in HomeworkView.php

85b65b5

Merge branch 'main' into late-day-page-update

042f917

Rkoester47 approved these changes Feb 4, 2026

View reviewed changes

JManion32 requested changes Feb 6, 2026

View reviewed changes

Text Change

2ecd57a

JManion32 approved these changes Feb 6, 2026

View reviewed changes

Merge branch 'main' into late-day-page-update

bb48be0

williamjallen requested changes Feb 28, 2026

View reviewed changes

Improved selector clarity

9ca7814

williamjallen requested changes Mar 7, 2026

View reviewed changes

William suggestions except cypress

7c90881

williamjallen requested changes Mar 13, 2026

View reviewed changes

John-Roy123 added 2 commits March 13, 2026 16:12

text changes

a475478

Added E2E test

b20b676

John-Roy123 added 3 commits March 21, 2026 15:18

Lint fixes

03a8e21

CSS Lint and Minor JS Lint Fix

ce0f842

Last lint change

33c32ac

Rkoester47 approved these changes Mar 27, 2026

View reviewed changes

John-Roy123 moved this from Work in Progress to Awaiting Maintainer Review in Submitty Development Apr 2, 2026

bmcutler requested a review from williamjallen April 3, 2026 17:27

automateprojectmangement Bot moved this from Awaiting Maintainer Review to In Review in Submitty Development Apr 3, 2026

Rkoester47 requested a review from cjreed121 April 3, 2026 21:49

John-Roy123 moved this from In Review to Awaiting Maintainer Review in Submitty Development Apr 3, 2026

Update LateDaysTable.twig

2251771

bmcutler merged commit f532a4f into main Apr 9, 2026
23 of 24 checks passed

bmcutler deleted the late-day-page-update branch April 9, 2026 04:10

github-project-automation Bot moved this from Awaiting Maintainer Review to Done in Submitty Development Apr 9, 2026

Uh oh!

Conversation

John-Roy123 commented Jan 31, 2026

Why is this Change Important & Necessary?

What is the New Behavior?

What steps should a reviewer take to reproduce or test the bug or new feature?

Automated Testing & Documentation

Other information

Uh oh!

codecov Bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JManion32 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

John-Roy123 commented Feb 1, 2026

Uh oh!

John-Roy123 commented Feb 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

John-Roy123 Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rkoester47 left a comment

Choose a reason for hiding this comment

Uh oh!

JManion32 left a comment

Choose a reason for hiding this comment

Uh oh!

JManion32 left a comment

Choose a reason for hiding this comment

Uh oh!

bmcutler commented Feb 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

williamjallen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

John-Roy123 commented Mar 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

williamjallen commented Mar 13, 2026

Uh oh!

John-Roy123 commented Mar 21, 2026

Uh oh!

Rkoester47 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

codecov Bot commented Jan 31, 2026 •

edited

Loading

John-Roy123 Feb 3, 2026 •

edited

Loading