[Refactor:Developer] Increase default ram and cpus for speed#12149
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12149 +/- ##
=========================================
Coverage 21.67% 21.67%
Complexity 9807 9807
=========================================
Files 268 268
Lines 36722 36722
Branches 490 490
=========================================
Hits 7960 7960
Misses 28276 28276
Partials 486 486
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| VM_MEMORY = ENV.fetch('VM_MEMORY', ON_CI ? '1024' : '2048').to_i | ||
| VM_CPUS = ENV.fetch('VM_CPUS', ON_CI ? '1' : '2').to_i | ||
| VM_MEMORY = ENV.fetch('VM_MEMORY', ON_CI ? '1024' : '4096').to_i | ||
| VM_CPUS = ENV.fetch('VM_CPUS', ON_CI ? '1' : '4').to_i |
There was a problem hiding this comment.
This will scale poorly if running a worker setup (e.g. 3 workers => 16G of ram + 16 vcpus)
Most dev machines will not be able to handle this.
What issues were the previous specs causing, and are they widespread enough to the point where we need to change the default?
There was a problem hiding this comment.
I agree that we should change the default. Doing so will make incremental install_submitty runs, initial VM setup, and autograding faster at a minimum.
You do raise a good point about multiple workers though. Can we set a higher limit for the primary VM and keep the current limits for the workers?
github-project-automation
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
github-actions
Bot
added
the
Abandoned PR - Needs New Owner
github-project-automation
Bot
moved this from Work in Progress
to Done
in Submitty Development
5 participants
Why is this Change Important & Necessary?
Developer machines have gotten a lot stronger since some of our defaults were set, and this is causing both bugs that seem to be due to lack of resources and a slower development experience in general.
What is the New Behavior?
The default ram for the vagrant box has been changed from 2GB to 4GB and the cpus have been changed from 2 to 4.
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
Other information