[Bugfix:InstructorUI] Fix checkpoint dates#11983
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11983 +/- ##
=========================================
Coverage 21.67% 21.67%
Complexity 9491 9491
=========================================
Files 267 267
Lines 36272 36272
Branches 474 474
=========================================
Hits 7863 7863
Misses 27939 27939
Partials 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
lavalleeale
approved these changes
Aug 8, 2025
lavalleeale
left a comment
lavalleeale
left a comment
Contributor
There was a problem hiding this comment.
tested locally and code change lgtm
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
Contributor
|
Can confirm that this works |
martig7
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
#11539 added this line. This line does not work for checkpoint gradeables as
gradeable.jsdoes not get included. This would cause all the dates to fail as the event listeners below it are in control of the datesWhat is the New Behavior?
We should only load bulk uploads if we have an electronic gradeable
What steps should a reviewer take to reproduce or test the bug or new feature?
Visit the checkpoint gradeable edit page. Notice error in console. Go to dates, notice that you cannot change any as a refresh will clear it
Automated Testing & Documentation
#11982
Other information