[Bugfix:InstructorUI] Fix Admin Gradeable's Team Lock Date#11981
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #11981 +/- ##
=========================================
Coverage 21.75% 21.75%
Complexity 9459 9459
=========================================
Files 267 267
Lines 36146 36146
Branches 474 474
=========================================
Hits 7863 7863
Misses 27813 27813
Partials 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jeffrey-cordero
approved these changes
Aug 6, 2025
jeffrey-cordero
left a comment
Contributor
There was a problem hiding this comment.
The small fix looks good, as the error no longer persists because the return type now matches all the other date setters. An issue should be made for catching this in a simple Cypress test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
#11702 Magic Methods PR stated that team_lock_date is ?DateTime, which is true, but getting the value actually returns a DateTime, casuing a frog robot crash
What is the New Behavior?
Like all other dates, team lock date now returns the correct value,
?\DateTimeWhat steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
We should check creating and modifying dates for a checkpoint gradeables
#11982 11982
Other information