[Feature:TAGrading] Add Image Annotation#11921
Conversation
automateprojectmangement
Bot
moved this from Seeking Reviewer
to In Review
in Submitty Development
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #11921 +/- ##
============================================
- Coverage 21.29% 21.06% -0.24%
- Complexity 10098 10128 +30
============================================
Files 278 279 +1
Lines 37794 38219 +425
Branches 516 585 +69
============================================
+ Hits 8050 8051 +1
- Misses 29241 29596 +355
- Partials 503 572 +69
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
After testing this PR and making some fixes to get it merge-ready, I found a missing feature that constitutes its own issue/PR after this one is merged. In this PR, students will only see at most one annotated image per image file they submit, even if multiple graders make annotations to the same file. This causes problems when multiple graders try to annotate the same problem, or two graders are annotating different problems on the same page. Leaving this image to find the issue again easily. All the work needed to fix this issue will probably be in \site\ts\ImageAnnotationEmbedded.ts. |
this current change does not work. I tried to use addInternalCss and addVendorJs here could not yet get them to work
jquery is already installed globally
the getPath only ran if this route was invoked on a non-anonymous file path, but the only use of this route is on an anonymous file path, so this line is never reached. Furthermore, if it was reached, then the getPath could cause an arbitrary read because it does not perform sanitation on the input file_path when its third parameter is false.
it seems that eslint is not picking up on a number of issues that are being picked up locally
This reverts commit fc31b89.
for clarity
automateprojectmangement
Bot
moved this from Work in Progress
to Seeking Reviewer
in Submitty Development
automateprojectmangement
Bot
moved this from Seeking Reviewer
to In Review
in Submitty Development
mattLif
left a comment
mattLif
left a comment
There was a problem hiding this comment.
Code looks good after reviewing. Tested feature with an uploaded image and observed the expected behavior. Just be sure to mention in documentation that annotations are only sent to student once rubric is fully graded. Also noticed that there's conflicts with multiple annotations, but that is being fixed in a future PR. I'm approving.
github-actions
Bot
removed
the
Abandoned PR - Needs New Owner
10 participants
Why is this Change Important & Necessary?
PDF Annotation was recently removed, and so as a replacement we agreed to instead support image annotation.
What is the New Behavior?
What steps should a reviewer take to reproduce or test the bug or new feature?
Bulk upload to a gradable on the new branch, and assign the result to a student. Go to their submisson, and open up an image. This page should now show, and editing the image should render the changes. These changes should persist across instances. Downloading should download the image with the annotations built on top.
The student can now see their annotated image from the gradable at the bottom of the page, which is the same as with pdf annotation:
Automated Testing & Documentation
This feature will likely need submitty.org documentation.
Other information
A future PR/issue should store this annotated image somewhere without having to build to see the annotated image.