[Bugfix:Autograding] Fix team autograding#11919
Merged
Merged
Conversation
bmcutler
approved these changes
Jul 27, 2025
bmcutler
left a comment
bmcutler
left a comment
Member
There was a problem hiding this comment.
Yay! Thanks @williamschen23
This appears to have resolved the issue on production machine.
github-project-automation
Bot
moved this from Seeking Reviewer
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #11919 +/- ##
=============================================
+ Coverage 21.74% 35.79% +14.04%
=============================================
Files 268 20 -248
Lines 35758 2478 -33280
Branches 458 0 -458
=============================================
- Hits 7777 887 -6890
+ Misses 27527 1591 -25936
+ Partials 454 0 -454
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
bmcutler
pushed a commit
that referenced
this pull request
Mar 22, 2026
### Why is this Change Important & Necessary? Fixes #11920 An issue where team submissions would cause an error, resolved by PR #11919 . Currently there is no cypress test to catch the error in the future. ### What is the New Behavior? This test checks to make sure no such error happens again for team autograding submissions ### What steps should a reviewer take to reproduce or test the bug or new feature? Review the code and make sure the test is passing. ### Automated Testing & Documentation ### Other information This is not a breaking change. --------- Co-authored-by: Rkoester47 <[email protected]>
IDzyre
pushed a commit
to IDzyre/Submitty
that referenced
this pull request
Mar 22, 2026
### Why is this Change Important & Necessary? Fixes Submitty#11920 An issue where team submissions would cause an error, resolved by PR Submitty#11919 . Currently there is no cypress test to catch the error in the future. ### What is the New Behavior? This test checks to make sure no such error happens again for team autograding submissions ### What steps should a reviewer take to reproduce or test the bug or new feature? Review the code and make sure the test is passing. ### Automated Testing & Documentation ### Other information This is not a breaking change. --------- Co-authored-by: Rkoester47 <[email protected]>
GarvitKhandelwal31
pushed a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Mar 25, 2026
### Why is this Change Important & Necessary? Fixes Submitty#11920 An issue where team submissions would cause an error, resolved by PR Submitty#11919 . Currently there is no cypress test to catch the error in the future. ### What is the New Behavior? This test checks to make sure no such error happens again for team autograding submissions ### What steps should a reviewer take to reproduce or test the bug or new feature? Review the code and make sure the test is passing. ### Automated Testing & Documentation ### Other information This is not a breaking change. --------- Co-authored-by: Rkoester47 <[email protected]>
GarvitKhandelwal31
pushed a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Mar 29, 2026
### Why is this Change Important & Necessary? Fixes Submitty#11920 An issue where team submissions would cause an error, resolved by PR Submitty#11919 . Currently there is no cypress test to catch the error in the future. ### What is the New Behavior? This test checks to make sure no such error happens again for team autograding submissions ### What steps should a reviewer take to reproduce or test the bug or new feature? Review the code and make sure the test is passing. ### Automated Testing & Documentation ### Other information This is not a breaking change. --------- Co-authored-by: Rkoester47 <[email protected]>
GarvitKhandelwal31
pushed a commit
to GarvitKhandelwal31/Submitty
that referenced
this pull request
Apr 14, 2026
### Why is this Change Important & Necessary? Fixes Submitty#11920 An issue where team submissions would cause an error, resolved by PR Submitty#11919 . Currently there is no cypress test to catch the error in the future. ### What is the New Behavior? This test checks to make sure no such error happens again for team autograding submissions ### What steps should a reviewer take to reproduce or test the bug or new feature? Review the code and make sure the test is passing. ### Automated Testing & Documentation ### Other information This is not a breaking change. --------- Co-authored-by: Rkoester47 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this Change Important & Necessary?
Regression came from #11578
Current production is broken right now with team gradeables. This is because the update portion of the team gradeable does not have a
connection.commit(), which the non-team gradeable has. Putting the commit statement outside of both if and else if is going to fix the issue.Whenever you submit a team gradeable, you will see the
Something went wrong will this submissionbanner. When you take a closer look in theelectronic_gradeable_datatable, the value ofcompletedwill always be false. We can manually check the grades that we received inresults/grades.txtto see that we actually received a grade for the assignment. As mentioned before, this is because the table is not being updated when the job finishes, and thus the user recieves the error.What is the New Behavior?
Putting the commit statement outside of both if and else if is going to fix the issue. This ensures that insertions and updates will both be commited.
The autoload_with=engine vs db is a semantic difference as it doesnt impact the overall issue. SQLAlchemy takes both conection and engine, but as engine was more widely used and recommended in sqlalchemy, we should use this instead.
What steps should a reviewer take to reproduce or test the bug or new feature?
Automated Testing & Documentation
We should do a cypress autograding test of team gradeables so that it doesnt get broken in the future.
Other information
check_refresh for team gradeables is broken. It will need to be fixed before we make the autograding test, as cypress relies on the automatic refreshs in order to detect new elements