[Bugfix:Submission] Fix Overridden Banner display#11809
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11809 +/- ##
=========================================
Coverage 20.67% 20.68%
- Complexity 9176 9179 +3
=========================================
Files 263 263
Lines 35222 35229 +7
Branches 461 461
=========================================
+ Hits 7282 7286 +4
- Misses 27483 27486 +3
Partials 457 457
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The documentation indicates this message should be visible to student: What is broken right now? Does no message at all appear? The message you've typed could be confusing to students who don't know the Submitty term/feature "Overridden". Manual grading TA comments & feedback (if any) are likely still accurate and important feedback to the student. How about: The image on submitty.org shoudl be updated. |
github-project-automation
Bot
moved this from Seeking Reviewer
to Done
in Submitty Development
github-project-automation
Bot
moved this from Done
to Seeking Reviewer
in Submitty Development
github-project-automation
Bot
moved this from Seeking Reviewer
to Work in Progress
in Submitty Development
No banner appears because the boolean is set is false. I will update the rest. |
| <div class='content overridden-message'> | ||
| <p>NOTE: The numeric score for this assignment has been overridden by your instructor.</p> | ||
| <p>Your numeric score for the assignment will be visible in 'Rainbow Grades'.</p> | ||
| <p>Please see your instructor if you have for questions about your grade for this assignment.</p> |
There was a problem hiding this comment.
sorry I had a garbled last sentence in my review...
"Please see your instructor if you have questions about your grade for this assignment."
|
also I was going to say that 'Rainbow Grades' shouldn't be in quotes, but should be a link to the rainbow grades page. |
|
Looks good so far, except for the final sentence, where the
|
|
Without rainbow grades: |
jeffrey-cordero
left a comment
jeffrey-cordero
left a comment
There was a problem hiding this comment.
The banner for overridden grades on the student view looks clear. The Rainbow Grades line correctly links to the proper endpoint, and it's not displayed at all when Rainbow Grades is disabled for a given course.
github-project-automation
Bot
moved this from Work in Progress
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
3 participants
Why is this Change Important & Necessary?
Fix #10331
On the student side, they will have no indication that their grade has been overridden, unless the instructor updates rainbowgrades. Now, there will be a banner on top of the submission page to indicate a grade override.
What is the New Behavior?
Without rainbow grades:
With rainbow grades:
What steps should a reviewer take to reproduce or test the bug or new feature?
Overriden a student
notice that they will have no indication that their grade is overridden.
Test new code.
See new banner
Automated Testing & Documentation
#11811
Other information