[Refactor:Submission] Split pdf image generation into new job#11537
Merged
Conversation
automateprojectmangement
Bot
moved this from Seeking Reviewer
to In Review
in Submitty Development
lavalleeale
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11537 +/- ##
============================================
+ Coverage 22.09% 22.13% +0.03%
Complexity 8845 8845
============================================
Files 246 247 +1
Lines 31840 31874 +34
Branches 79 79
============================================
+ Hits 7036 7056 +20
- Misses 24728 24742 +14
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
11 tasks
github-actions
Bot
added
the
Abandoned PR - Needs New Owner
lavalleeale
removed
the
Abandoned PR - Needs New Owner
bmcutler
approved these changes
Apr 11, 2025
bmcutler
left a comment
bmcutler
left a comment
Member
There was a problem hiding this comment.
seemed to work the same when tested
github-project-automation
Bot
moved this from In Review
to Awaiting Maintainer Review
in Submitty Development
github-project-automation
Bot
moved this from Awaiting Maintainer Review
to Done
in Submitty Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
What is the current behavior?
Pdf splitting and image generation is done in a single job
What is the new behavior?
Pdf splitting now calls the GeneratePdfImages job to turn the split pdf into images.
Other information?
This will be part of a series of PRs to eventually support redaction of tests for limited access graders, the job needs to be split to be able to rerun the image generation if the redaction list changes