[UI/UX:Forum] Responsive Category Labels#11379
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11379 +/- ##
=========================================
Coverage 22.12% 22.12%
Complexity 8807 8807
=========================================
Files 246 246
Lines 31758 31758
Branches 79 79
=========================================
Hits 7027 7027
Misses 24655 24655
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. |
max1dyer
left a comment
max1dyer
left a comment
There was a problem hiding this comment.
The visual changes look good and make the necessary changes. When minimizing the screen the comments do not wrap and the title of thread box is always visible.
Before:
After:
My only comment is I'm not sure changing the padding to 6px vs 5px is necessary. Visually it doesn't really improve anything I can see. Is there a reason for this specific change?
I was testing the padding locally, and I forgot to remove it remotely for this PR. I also don't see much differences in the increase in padding, so I reverted the changes. |
max1dyer
left a comment
max1dyer
left a comment
There was a problem hiding this comment.
Visual changes look good and function the same with code changes you made since last review.
williamjallen
left a comment
williamjallen
left a comment
There was a problem hiding this comment.
Code looks good to me. Fixing the date overflow as shown in @max1dyer's screenshot would be a good next improvement. If you don't have the capacity or interest to do it, it would probably be a good first or second issue for one of our new developers.
polibear21
left a comment
polibear21
left a comment
There was a problem hiding this comment.
The changes look good, and the behavior works like shown. I agree that the date wrapping function could be changed to be displayed under the category labels if the horizontal size gets smaller.
5 participants
Please check if the PR fulfills these requirements:
What is the current behavior?
Category labels for the discussion forum thread list that are too long in terms of text for small viewports end up wrapping onto the next line, where the expected behavior is for each box to correspond to one category, which is displayed via the category,
long label to display, below.What is the new behavior?
Longer labels remain in a single box, where if the container is too long for a small viewport, the user may scroll horizontally to view the thread content.
Other information?
Fixes #10874