[Testing:InstructorUI] Added Cypress test for locked gradeable by subCode321 · Pull Request #11364 · Submitty/Submitty

subCode321 · 2025-01-25T05:56:35Z

added a cypress test for checking appropriate message to be displayed upon clicking a locked gradeable.

Please check if the PR fulfills these requirements:

Tests for the changes have been added/updated (if possible)
Documentation has been updated/added if relevant
Screenshots are attached to Github PR if visual/UI changes were made

What is the current behavior?

There was no way to test the alert on clicking on a locked gradeable.

What is the new behavior?

Fixes #11160
Cypress tests and matches the appropriate message to be displayed for the locked gradeable upon being clicked.

Other information?

added a cypress test for checking appropriate message to be displayed upon clicking a locked gradeable.

codecov · 2025-01-25T05:57:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.12%. Comparing base (b62b721) to head (a6996a6).
Report is 28 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11364      +/-   ##
============================================
+ Coverage     22.10%   22.12%   +0.01%     
- Complexity     8947     8949       +2     
============================================
  Files           247      247              
  Lines         32235    32243       +8     
  Branches         83       83              
============================================
+ Hits           7125     7133       +8     
  Misses        25031    25031              
  Partials         79       79

Flag	Coverage Δ
autograder	`21.60% <ø> (ø)`
js	`27.17% <ø> (ø)`
migrator	`100.00% <ø> (ø)`
php	`19.12% <ø> (+0.02%)`	⬆️
python_submitty_utils	`80.08% <ø> (ø)`
submitty_daemon_jobs	`88.88% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fixed minor lint issues

removed data-testid from input values.

the excessive query calls were causing the cypress UI test to fail

had commented out the previous tests

changed gradeableid

subCode321 · 2025-01-25T17:09:13Z

@williamschen23 , sorry for pinging on weekend, but I just wanted to know if there's any procedure for debugging site errors in Cypress as they have very little information to check and debug. Is there any forum in Zulip where I can ask?

used data test id for gradeable-lock and also changed test gradeable to cypress test gradeable.

…ubmitty into add-cypress-feature

removed arbitrary waiting time

removed subscript from cypress_test_gradeable

williamschen23

For me, I would rather make a new gradeable in the course config that has a lock on another gradeable. Creating a gradeable comes with verifying that the creation of gradeable works, which was already done in another test

I will defer the review to @IDzyre

IDzyre · 2025-01-28T00:43:14Z

Do we not already have a gradeable that is 'locked' ? The sample course is (i think) supposed to have examples for instructors to follow when it comes to different types of gradeables. I would be in favor of having another gradeable created with the setup_sample_course script, if there is not already one made.

williamschen23 · 2025-01-28T00:48:39Z

There are team-locked gradeables, none of them are for pre-requisite gradeables. I also don't see the field in courses.yml, so we might need to add that...

subCode321 · 2025-01-29T09:46:58Z

There are team-locked gradeables, none of them are for pre-requisite gradeables. I also don't see the field in courses.yml, so we might need to add that...

I have done that. Added two locked gradeables using the sample.yml file

subCode321 · 2025-01-29T09:47:12Z

Do we not already have a gradeable that is 'locked' ? The sample course is (i think) supposed to have examples for instructors to follow when it comes to different types of gradeables. I would be in favor of having another gradeable created with the setup_sample_course script, if there is not already one made.

done.

subCode321 · 2025-01-29T09:47:40Z

For me, I would rather make a new gradeable in the course config that has a lock on another gradeable. Creating a gradeable comes with verifying that the creation of gradeable works, which was already done in another test

I will defer the review to @IDzyre

Now, the cypress testing is done on the existing locked gradeables, for all 3 levels.

subCode321 · 2025-02-04T05:44:48Z

@williamschen23 , sorry for pinging. I made the changes you had requested for (i.e to create a locked gradeable using the script). However, the creation of one extra course is causing the metrics of other courses to change, due to which the cypress tests are failing. Could you guide me further on how to proceed with fixing these tests?

williamschen23 · 2025-02-04T20:36:10Z

@williamschen23 , sorry for pinging. I made the changes you had requested for (i.e to create a locked gradeable using the script). However, the creation of one extra course is causing the metrics of other courses to change, due to which the cypress tests are failing. Could you guide me further on how to proceed with fixing these tests?

This is all based off of memory, but doing
recreate_sample_courses --test_only_grading
rebuilds the courses and you can see where the error is. The cypress tests will be under npx cypress open and you can run them to see what happens. Pretty sure for that test, you can only run it once.
In addition, can you add the field to courses.yml? I think that the file is for all possible options, but feel free to correct me if I'm wrong.

subCode321 · 2025-02-19T02:24:17Z

Hey, I'm working on this. Will update today

subCode321 · 2025-02-23T12:33:46Z

@williamschen23 I've updated the PR but unable to repro this one last test failure. Would need your help in understanding the root cause involved here

JManion32

I ran recreate_sample_courses and verified that the new Cypress test works correctly.

cypress test for locked gradeable

c25dc2c

added a cypress test for checking appropriate message to be displayed upon clicking a locked gradeable.

subCode321 added 5 commits January 25, 2025 11:43

fixed lint issues

51e5b34

fixed minor lint issues

fixed cypress system test issues

48cd063

removed data-testid from input values.

removed excessive query calls

f61d6ef

the excessive query calls were causing the cypress UI test to fail

uncommented out the previous tests

7cd5d9a

had commented out the previous tests

changed gradeableid

4f0374c

changed gradeableid

add calendar to ignored performance warning

749a54c

subCode321 commented Jan 25, 2025

View reviewed changes

Comment thread site/app/templates/admin/admin_gradeable/AdminGradeableAuto.twig Outdated

subCode321 commented Jan 25, 2025

View reviewed changes

Comment thread site/cypress/e2e/Cypress-UI/navigation_page.spec.js Outdated

subCode321 added 4 commits January 26, 2025 08:59

used data test id

18e6b2f

used data test id for gradeable-lock and also changed test gradeable to cypress test gradeable.

Merge branch 'add-cypress-feature' of https://github.com/subCode321/S…

ac14244

…ubmitty into add-cypress-feature

fixed lint issues

ae1bb2d

removed arbitrary waiting time

removed subscript

f861070

removed subscript from cypress_test_gradeable

subCode321 requested a review from williamschen23 January 26, 2025 06:25

williamschen23 reviewed Jan 27, 2025

View reviewed changes

created locked gradeables and then ran cypress testing

f097b1c

fixed lint issues

6df42b9

subCode321 requested a review from williamschen23 January 29, 2025 09:50

subCode321 added 2 commits January 29, 2025 19:23

fixed cypress ui test

8bcff46

fixed cypress feature

7e432be

github-actions Bot added the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Feb 19, 2025

subCode321 and others added 7 commits February 19, 2025 07:56

Merge branch 'main' into add-cypress-feature

83dda9b

changes to config

6c28b62

more changes

4b120db

remove unwanted courses

d76902f

remove unused

e6f810d

remove more unused

b42b695

fix tests

235a1e4

williamschen23 added 11 commits May 29, 2025 12:20

remove sample.yml

4127a5f

move course to testing, reset cypress tests

0508327

merge main

6a081e7

fix yml

774acda

fix test

a0e7677

correctly change testing.yml

ef5978b

finish cypress test

e309023

add missing yaml

34ad51e

fix diff

e438b45

improve rainbow grades test

8992718

courses.yml to pass yaml

a6996a6

JManion32 removed the Abandoned PR - Needs New Owner No activity on PR for more than 2 weeks -- seeking new owner to complete label Jun 2, 2025

JManion32 approved these changes Jun 2, 2025

View reviewed changes

github-project-automation Bot moved this from In Review to Awaiting Maintainer Review in Submitty Development Jun 2, 2025

williamschen23 mentioned this pull request Jun 2, 2025

Cypress test for non-zero autograding lock #11696

Closed

bmcutler merged commit 1c49edb into Submitty:main Jun 2, 2025

github-project-automation Bot moved this from Awaiting Maintainer Review to Done in Submitty Development Jun 2, 2025

Uh oh!

Conversation

subCode321 commented Jan 25, 2025 • edited by hyeenaa Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Please check if the PR fulfills these requirements:

What is the current behavior?

What is the new behavior?

Other information?

Uh oh!

codecov Bot commented Jan 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

subCode321 commented Jan 25, 2025

Uh oh!

Uh oh!

Uh oh!

williamschen23 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IDzyre commented Jan 28, 2025

Uh oh!

williamschen23 commented Jan 28, 2025

Uh oh!

subCode321 commented Jan 29, 2025

Uh oh!

subCode321 commented Jan 29, 2025

Uh oh!

subCode321 commented Jan 29, 2025

Uh oh!

subCode321 commented Feb 4, 2025

Uh oh!

williamschen23 commented Feb 4, 2025

Uh oh!

subCode321 commented Feb 19, 2025

Uh oh!

subCode321 commented Feb 23, 2025

Uh oh!

JManion32 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

subCode321 commented Jan 25, 2025 •

edited by hyeenaa

Loading

codecov Bot commented Jan 25, 2025 •

edited

Loading

williamschen23 left a comment •

edited

Loading