Skip to content

[Bugfix:Submission] Grader submission during beta#11356

Merged
bmcutler merged 1 commit into
mainfrom
grader-submission
Jan 29, 2025
Merged

[Bugfix:Submission] Grader submission during beta#11356
bmcutler merged 1 commit into
mainfrom
grader-submission

Conversation

@williamschen23

@williamschen23 williamschen23 commented Jan 23, 2025

Copy link
Copy Markdown
Contributor

What is the current behavior?

Graders, aka limited access graders, are not able to submit during beta. I believe that they should, since they can see the gradeable when it is in the "TA Beta".

What is the new behavior?

Graders can submit

Other information?

You can log in as grader and that would be a limited access grader.
Many student mentors complained about this, so we should make this more consistent.

@codecov

codecov Bot commented Jan 23, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.12%. Comparing base (2cf3a18) to head (97298df).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #11356   +/-   ##
=========================================
  Coverage     22.12%   22.12%           
  Complexity     8807     8807           
=========================================
  Files           246      246           
  Lines         31760    31760           
  Branches         79       79           
=========================================
  Hits           7027     7027           
  Misses        24657    24657           
  Partials         76       76           
Flag Coverage Δ
autograder 21.56% <ø> (ø)
js 26.85% <ø> (ø)
migrator 100.00% <ø> (ø)
php 19.13% <100.00%> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hinyan17 hinyan17 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works as intended, graders can now upload without error messages

@williamjallen

Copy link
Copy Markdown
Member

@bmcutler Have you approved this design change?

@williamschen23

williamschen23 commented Jan 26, 2025

Copy link
Copy Markdown
Contributor Author

@bmcutler Have you approved this design change?

Many of the changes of grader vs full access grader are of my own opinion, but it would be nice if you could voice it to barb during your meetings (I cannot attend, unfortunately). Thats why I opened #11366

@williamjallen

Copy link
Copy Markdown
Member

I'll try to remember to bring it up with Barb on Monday. Feel free to add notes to the document for the meeting if you have specific arguments to make. I seem to vaguely recall there being a motivation for the design being the way it is, but Barb is the ultimate authority on these kinds of design decisions.

@bmcutler

Copy link
Copy Markdown
Member

Yes, limited access and full access graders should both be able to submit to gradeables in the 'beta' category.
Limited access graders should not be able to view the submissions by students until grading opens.

@williamschen23

Copy link
Copy Markdown
Contributor Author

Limited access graders should not be able to view the submissions by students until grading opens.

will file another issue for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants