Skip to content

[Feature:Developer] Add Archived Sample Course#10932

Merged
bmcutler merged 6 commits into
mainfrom
archived_course
Oct 7, 2024
Merged

[Feature:Developer] Add Archived Sample Course#10932
bmcutler merged 6 commits into
mainfrom
archived_course

Conversation

@IDzyre

@IDzyre IDzyre commented Sep 12, 2024

Copy link
Copy Markdown
Member

Please check if the PR fulfills these requirements:

  • Documentation has been updated/added if relevant

What is the current behavior?

Currently there are no courses, or way to make courses archived with the Setup Sample Courses scripts. #10778 required a sample archived course to verify during testing where the Self Registration courses show up on the My Courses page.

What is the new behavior?

A sample Archived course has been added, and the setup sample courses scripts have been updated to allow for archiving courses.

Comment thread sbin/create_course.sh

archived=0
while :; do
case $1 in

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of extraneous for just one case, but #10778 adds more.

@williamjallen

Copy link
Copy Markdown
Member

I just kicked off this vagrant up job to verify that the archived course can be built successfully.

@IDzyre

IDzyre commented Sep 20, 2024

Copy link
Copy Markdown
Member Author

I just kicked off this vagrant up job to verify that the archived course can be built successfully.

I will re-run a vagrant up job once #10964 is merged.

@williamschen23

Copy link
Copy Markdown
Contributor

vagrant up is here

@IDzyre
IDzyre requested a review from ziesski September 30, 2024 15:20
@bmcutler
bmcutler merged commit ee751a2 into main Oct 7, 2024
@bmcutler
bmcutler deleted the archived_course branch October 7, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants