[Testing:Submission] Cypress test for Navigation Buttons#10795
Conversation
|
Mergeable after newer navigation buttons |
|
Continue after #10852 |
|
@IDzyre I'm not sure whether or not this should be merged or not. Since the CI does not use any autograding, most of the navigation buttons show up as 'OVERDUE SUBMISSION'. However, validating that the button should/should not exist should be important. |
Co-authored-by: Cameron Peterson <[email protected]>
I think that having the buttons exist on the screen is slightly more important than what the buttons say. I will do a more thorough review tonight and then discuss in the meeting tomorrow with Barb and William to see their opinion |
| // Grade Released Homework, Grade Released Test, | ||
| it('should display instructor buttons correctly', () => { | ||
| cy.login('instructor'); | ||
| cy.visit(`/courses/${getCurrentSemester()}/sample`); |
There was a problem hiding this comment.
This can just be cy.visit(['sample']);
Same with other places of this.
|
Am waiting until I finish making a course in sample that has pre-req checking ig |
github-actions
Bot
added
the
Abandoned PR - Needs New Owner
For the sake of less clutter, will be another PR |
williamschen23
removed
the
Abandoned PR - Needs New Owner
|
Also, it doesn't seem necessary to have a add another ID to the button class, will remove it in a future commit |
IDzyre
left a comment
IDzyre
left a comment
There was a problem hiding this comment.
Once these changes are addressed, it looks good. Good work on finding a way to reduce duplicated code.
|
Turns out we passed in a name into buttons that wasn't being used, but it is okay to use as a test-id |
IDzyre
left a comment
IDzyre
left a comment
There was a problem hiding this comment.
Looks good, thanks for the PR.
2 participants
What is the current behavior?
No tests for navigation buttons and navigation colors
What is the new behavior?
Tests for these changes
NOTE TO SELF: it uses the grade only flag, not the normal create courses flag.