Skip to content

[Feature:System] Add Self Registration Courses#10778

Merged
bmcutler merged 94 commits into
mainfrom
self_register
Nov 12, 2024
Merged

[Feature:System] Add Self Registration Courses#10778
bmcutler merged 94 commits into
mainfrom
self_register

Conversation

@IDzyre

@IDzyre IDzyre commented Jul 29, 2024

Copy link
Copy Markdown
Member

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added/updated (if possible)
  • Documentation has been updated/added if relevant
  • Screenshots are attached to Github PR if visual/UI changes were made

Related to #3950

What is the current behavior?

Submitty only allows for Instructors to add users manually to each course, which requires a few steps, and if the instructor is busy, they may not add the student for a while.

What is the new behavior?

image
image

This is also related to #10097, which in combination will allow for users to create an account, and join courses on their own.

In order to create a Self Registration course, you have to go to Course Settings, scroll all the way down to the Danger Zone, and check the Enable Self Registration box, and then go to Manage Sections, and check a radio button under Default Section, and then click Submit. Users who are not already in the course will see it under 'My Self Registration Courses'.

@IDzyre IDzyre self-assigned this Jul 31, 2024
@IDzyre
IDzyre marked this pull request as ready for review August 12, 2024 19:21
Comment thread migration/migrator/data/submitty_db.sql Outdated

@williamjallen williamjallen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look pretty good overall here. I did a preliminary review, but stopped after leaving comments about potential schema changes. Once those comments are resolved, I'll do a more thorough code review.

Comment thread site/app/controllers/course/CourseRegistrationController.php Outdated
Comment thread site/app/controllers/course/CourseRegistrationController.php Outdated
Comment thread site/app/controllers/course/CourseRegistrationController.php Outdated
Comment thread site/app/libraries/database/DatabaseQueries.php
Comment thread site/app/libraries/database/DatabaseQueries.php Outdated
Comment thread site/app/libraries/database/DatabaseQueries.php Outdated

@DarthNyan DarthNyan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions answered. Looks good to me.

@chenjohnny-cs chenjohnny-cs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self registration worked fine on my local machine. I could enable/disable self registration, it wouldn't allow for other users registered for the class already to join and all of the features seem to be there. Haven't taken a look at the code yet, but the functionality seems fine for now.

Comment thread site/app/libraries/database/DatabaseQueries.php Outdated
bmcutler pushed a commit that referenced this pull request Oct 7, 2024
### Please check if the PR fulfills these requirements:

* [ ] Documentation has been updated/added if relevant

### What is the current behavior?
Currently there are no courses, or way to make courses archived with the
Setup Sample Courses scripts. #10778 required a sample archived course
to verify during testing where the Self Registration courses show up on
the My Courses page.

### What is the new behavior?
A sample Archived course has been added, and the setup sample courses
scripts have been updated to allow for archiving courses.

---------

Co-authored-by: Williams Chen <[email protected]>

@williamjallen williamjallen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me once the comments I left inline are addressed.

Comment thread .setup/bin/sample_courses/models/course/course_create.py Outdated
Comment thread site/app/libraries/database/DatabaseQueries.php Outdated
Comment thread site/app/templates/admin/Configuration.twig Outdated
Comment thread site/app/templates/admin/Configuration.twig Outdated

@williamjallen williamjallen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@bmcutler
bmcutler merged commit 2a8b128 into main Nov 12, 2024
@bmcutler
bmcutler deleted the self_register branch November 12, 2024 04:36
bmcutler pushed a commit to Submitty/submitty.github.io that referenced this pull request Feb 7, 2025
This PR adds documentation for
Submitty/Submitty#10778, which adds the ability
for users to register for courses if the instructor enables it in the
Course Settings page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants