Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.35%. Comparing base (3102c53) to head (4eddee1).
Report is 6 commits behind head on main.

@@             Coverage Diff              @@
##               main   #10260      +/-   ##
============================================
- Coverage     22.07%   20.35%   -1.72%     
- Complexity     8673     8675       +2     
============================================
  Files           224      200      -24     
  Lines         30764    28178    -2586     
============================================
- Hits           6792     5737    -1055     
+ Misses        23972    22441    -1531     

This PR has been inactive (no commits and no review comments) for 12 days. If there is no new activity in the next 48 hours, this PR will be labeled as Abandoned PR - Needs New Owner and either another developer will finish the PR or it will be closed.

Removed the visual testing for autograding section (markdown_test.spec.js)
I will test that section in separate pr

Once the tests pass in both CI and locally, I'll do a final review, but the progress looks good.

Once the tests pass in both CI and locally, I'll do a final review, but the progress looks good.

is that threshold value is good like i used 0.02 in this test?

Ideally it would be 0 thresh hold, but we can discuss it more in the meeting.

Seeing the comments at the bottom of the JS package, it would be difficult to get this working locally and in CI without using docker, which we don't plan to use/support. If we want to get it to work in just CI we could, but it would probably be hard to maintain.

Please notice
Be aware that despite forcing a screenshot resolution to a particular height and width for a test, if this test is run on different computers (i.e a 13" Mac vs PC attached to a 30" monitor), the results will be different. So it's extremely important that you standardize where the tests will run, both locally and CI.
One way to handle this is by running it with docker container. This project tests use a docker container to run the tests so it could be used as an example.

Closing this PR because unfortunately, due to differences in screen resolution (and perhaps also browser and native machine OS) the idea of performing automatic image comparisons will be challenging. It will be difficult for developers to debug problems and maintain these tests long term.

Closing this PR for now.
Perhaps this testing will be better supported and easier to do in the future, and we can re-implement/re-open this PR.