[Feature:System] Self Account Creation#10097
Conversation
|
This PR has been inactive (no commits and no review comments) for 12 days. If there is no new activity in the next 48 hours, this PR will be labeled as Abandoned PR - Needs New Owner and either another developer will finish the PR or it will be closed. |
github-actions
Bot
added
the
Abandoned PR - Needs New Owner
micpap25
removed
the
Abandoned PR - Needs New Owner
github-actions
Bot
added
the
Abandoned PR - Needs New Owner
Todos are included, needs someone with experience on auth
IDzyre
removed
the
Abandoned PR - Needs New Owner
github-actions
Bot
added
the
Abandoned PR - Needs New Owner
williamjallen
removed
the
Abandoned PR - Needs New Owner
bmcutler
left a comment
bmcutler
left a comment
There was a problem hiding this comment.
I tested it, and after manually changing the configs (would be easier if I actually read the docs) I thought it was working, but after I entered the verification code I got this frog robot:
(Maybe something is bugged about my configuration, but it should fail earlier if there is an admin config error)
This is fixed, I forgot to remove a line in the Doctrine entity file. |
bmcutler
left a comment
bmcutler
left a comment
There was a problem hiding this comment.
I haven't reviewed all the code in detail, but I tested it and I'm happy to merge it.
Except it's not passing the linter tests
And your PR notes don't include the need to add "accepted_emails" array.
And actually I have a small requested change for the config file.
This is what I used:
"user_id_requirements": {
"any_user_id": true,
"require_name": false,
"min_length": 6,
"max_length": 25,
"name_requirements": {
"given_first": false,
"given_name": 2,
"family_name": 4
},
"require_email": false,
"email_requirements": {
"whole_email": false,
"whole_prefix": false,
"prefix_count": 6
}
},
"accepted_emails" : [
"gmail.com"
]
I think the acepted_emails array should actually be nested inside of the "user_id_requirements" block. NOTE: It didn't work when I tried that.
github-project-automation
Bot
moved this from Seeking Reviewer
to Done
in Submitty Development
### Please check if the PR fulfills these requirements: * [ ] Tests for the changes have been added/updated (if possible) * [ ] Documentation has been updated/added if relevant * [x] Screenshots are attached to Github PR if visual/UI changes were made ### What is the current behavior? Related to #9982 Submitty is looking to add support for 'Submitty as a Service', a cloud hosted example version, so we need to allow for users to create accounts to log into Submitty with. ### What is the new behavior? If when installing Submitty, you use DatabaseAuthentication, and say 'yes' to self user account creation, on the login page, there is a button to a form to create a new user account.  ### Other information? <!-- Is this a breaking change? --> <!-- How did you test --> See [Docs for switching Authentication type](https://submitty.org/developer/development_instructions/miscellaneous) for help on how to review. Switch to DatabaseAuthentication. Add the following to `/usr/local/submitty/config/submitty.json` ```json "user_create_account": true, "user_id_requirements": { "any_user_id": true, "require_name": false, "min_length": 6, "max_length": 25, "name_requirements": { "given_first": false, "given_name": 2, "family_name": 4 }, "require_email": false, "email_requirements": { "whole_email": false, "whole_prefix": false, "prefix_count": 6 }, "accepted_emails": [ "gmail.com" ] } ``` --------- Co-authored-by: Michael Papadopoulos <[email protected]> Co-authored-by: IDzyre <[email protected]> Co-authored-by: Cameron Peterson <[email protected]> Co-authored-by: Barb Cutler <[email protected]>
13 participants
Please check if the PR fulfills these requirements:
What is the current behavior?
Related to #9982
Submitty is looking to add support for 'Submitty as a Service', a cloud hosted example version, so we need to allow for users to create accounts to log into Submitty with.
What is the new behavior?
If when installing Submitty, you use DatabaseAuthentication, and say 'yes' to self user account creation, on the login page, there is a button to a form to create a new user account.
Other information?
See Docs for switching Authentication type
for help on how to review.
Switch to DatabaseAuthentication.
Add the following to
/usr/local/submitty/config/submitty.json