What problem are you trying to solve with Submitty
Submitty stores each users legal first & last names as well as preferred first & last names.
If preferred is empty string (or null?) then the legal name is used.
If preferred is not empty, then that should always be used.
We've had bugs in the past, where legal name was displayed on some pages even when there was a preferred name.
We've also had an error where legal name was used to sort the users rather than preferred name, so even though preferred name was displayed, a student with a different legal vs preferred named appeared to be sorted incorrectly, which caused confusion.
We may currently have legal vs preferred name bugs. We want to fix them and avoid adding new bugs.
Let's write a bunch of tests.
E.g., lets set the legal name of several users (one at each level, student->instructor) to be specific tokens, and then search the html source for those tokens and make sure they never appear.
related to #8434 #8433 #8432 #8431
Note: since we are currently displaying names in a variety of different ways I think we are not sharing code effectively.
We should refactor to share code (write a common function and call it from everywhere else)
What problem are you trying to solve with Submitty
Submitty stores each users legal first & last names as well as preferred first & last names.
If preferred is empty string (or null?) then the legal name is used.
If preferred is not empty, then that should always be used.
We've had bugs in the past, where legal name was displayed on some pages even when there was a preferred name.
We've also had an error where legal name was used to sort the users rather than preferred name, so even though preferred name was displayed, a student with a different legal vs preferred named appeared to be sorted incorrectly, which caused confusion.
We may currently have legal vs preferred name bugs. We want to fix them and avoid adding new bugs.
Let's write a bunch of tests.
E.g., lets set the legal name of several users (one at each level, student->instructor) to be specific tokens, and then search the html source for those tokens and make sure they never appear.
related to #8434 #8433 #8432 #8431
Note: since we are currently displaying names in a variety of different ways I think we are not sharing code effectively.
We should refactor to share code (write a common function and call it from everywhere else)