Skip to content

Consolidate email footer text duplicate #11734

Description

@bmcutler

Describe the bug
The email footer text:
"This is an automated email notification, which is unable to receive replies. + ETC"
Is duplicated in multiple files in the code base. Let's do a refactor so it is in just one location, presumably the script that actually sends the email. We don't need to store this text in the database, it is not part of the actual email content.

git grep -i "this is an automated"
.setup/data/random/CourseEmailBody.txt:An Instructor/TA/Mentor has reopened your grade inquiry for gradeable, Grades Released Homework.\n\nta writes:\nThe answer is incorrect\n\n--\nNOTE: This is an automated email notification, which is unable to receive replies.\nPlease refer to the course syllabus for contact information for your teaching staff. Update your email notification settings for this course here: http://localhost:1511/courses/f21/sample/notifications/settings
.setup/data/random/CourseEmailBody.txt:\nSAMPLE\nhello?\n\n!\n\nAuthor: Quinn I. Click here for more info: http://localhost:1511/courses/f21/sample/forum/threads/10\n--\nNOTE: This is an automated email notification, which is unable to receive replies.\nPlease refer to the course syllabus for contact information for your teaching staff. Update your email notification settings for this course here: http://localhost:1511/courses/f21/sample/notifications/settings
sbin/send_notification.py: f"--\nNOTE: This is an automated "
site/app/models/Email.php: $body .= "\n\n--\nNOTE: This is an automated email notification, which is unable to receive replies.";
site/tests/app/models/EmailTester.php: private string $footer = "\n\n--\nNOTE: This is an automated email notification, which is unable to receive replies.\nPlease refer to the course syllabus for contact information for your teaching staff.\nUpdate your email notification settings for this course here: http://localhost/courses/f21/csci1100/notifications/settings";
site/tests/app/models/EmailTester.php: $expected_body = 'email body' . "\n\n--\nNOTE: This is an automated email notification, which is unable to receive replies.";

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions